From: Wesley Cheng <wcheng@codeaurora.org>
To: Alan Stern <stern@rowland.harvard.edu>
Cc: balbi@kernel.org, gregkh@linuxfoundation.org, robh+dt@kernel.org,
agross@kernel.org, bjorn.andersson@linaro.org,
linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
peter.chen@nxp.com, jackp@codeaurora.org
Subject: Re: [PATCH v6 1/4] usb: gadget: udc: core: Introduce check_config to verify USB configuration
Date: Mon, 25 Jan 2021 17:02:59 -0800 [thread overview]
Message-ID: <784ce67c-d4ef-63ae-8f81-c52fc5b2e794@codeaurora.org> (raw)
In-Reply-To: <20210122162447.GC43566@rowland.harvard.edu>
On 1/22/2021 8:24 AM, Alan Stern wrote:
> On Thu, Jan 21, 2021 at 08:01:37PM -0800, Wesley Cheng wrote:
>> Some UDCs may have constraints on how many high bandwidth endpoints it can
>> support in a certain configuration. This API allows for the composite
>> driver to pass down the total number of endpoints to the UDC so it can verify
>> it has the required resources to support the configuration.
>>
>> Signed-off-by: Wesley Cheng <wcheng@codeaurora.org>
>
>
>> --- a/include/linux/usb/gadget.h
>> +++ b/include/linux/usb/gadget.h
>> @@ -328,6 +328,7 @@ struct usb_gadget_ops {
>> struct usb_ep *(*match_ep)(struct usb_gadget *,
>> struct usb_endpoint_descriptor *,
>> struct usb_ss_ep_comp_descriptor *);
>> + int (*check_config)(struct usb_gadget *gadget, unsigned long ep_map);
>> };
>>
>> /**
>> @@ -607,6 +608,7 @@ int usb_gadget_connect(struct usb_gadget *gadget);
>> int usb_gadget_disconnect(struct usb_gadget *gadget);
>> int usb_gadget_deactivate(struct usb_gadget *gadget);
>> int usb_gadget_activate(struct usb_gadget *gadget);
>> +int usb_gadget_check_config(struct usb_gadget *gadget, unsigned long ep_map);
>> #else
>> static inline int usb_gadget_frame_number(struct usb_gadget *gadget)
>> { return 0; }
>
> Don't you also need an entry for the case where CONFIG_USB_GADGET isn't
> enabled?
>
> Alan Stern
>
Hi Alan,
Thanks for pointing that out. I missed that, and will add it to the
next rev.
Thanks
Wesley Cheng
--
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project
next prev parent reply other threads:[~2021-01-26 21:28 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-22 4:01 [PATCH v6 0/4] Re-introduce TX FIFO resize for larger EP bursting Wesley Cheng
2021-01-22 4:01 ` [PATCH v6 1/4] usb: gadget: udc: core: Introduce check_config to verify USB configuration Wesley Cheng
2021-01-22 5:17 ` Jack Pham
2021-01-26 1:01 ` Wesley Cheng
2021-01-22 16:24 ` Alan Stern
2021-01-26 1:02 ` Wesley Cheng [this message]
2021-01-22 4:01 ` [PATCH v6 2/4] usb: gadget: configfs: Check USB configuration before adding Wesley Cheng
2021-01-22 4:01 ` [PATCH v6 3/4] usb: dwc3: Resize TX FIFOs to meet EP bursting requirements Wesley Cheng
2021-01-22 17:12 ` Bjorn Andersson
2021-01-26 1:14 ` Wesley Cheng
2021-01-26 1:55 ` Bjorn Andersson
2021-01-26 4:32 ` Wesley Cheng
2021-01-26 5:15 ` Bjorn Andersson
2021-01-28 23:08 ` Wesley Cheng
2021-01-23 0:15 ` Thinh Nguyen
2021-01-26 9:51 ` Wesley Cheng
2021-01-26 20:43 ` Thinh Nguyen
2021-01-26 23:26 ` Wesley Cheng
2021-01-27 1:47 ` Thinh Nguyen
2021-01-22 4:01 ` [PATCH v6 4/4] arm64: boot: dts: qcom: sm8150: Enable dynamic TX FIFO resize logic Wesley Cheng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=784ce67c-d4ef-63ae-8f81-c52fc5b2e794@codeaurora.org \
--to=wcheng@codeaurora.org \
--cc=agross@kernel.org \
--cc=balbi@kernel.org \
--cc=bjorn.andersson@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=jackp@codeaurora.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=peter.chen@nxp.com \
--cc=robh+dt@kernel.org \
--cc=stern@rowland.harvard.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).