From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F1067C3F2D1 for ; Thu, 5 Mar 2020 23:59:01 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id CFF352073D for ; Thu, 5 Mar 2020 23:59:01 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726359AbgCEX7B convert rfc822-to-8bit (ORCPT ); Thu, 5 Mar 2020 18:59:01 -0500 Received: from gloria.sntech.de ([185.11.138.130]:54964 "EHLO gloria.sntech.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726204AbgCEX7B (ORCPT ); Thu, 5 Mar 2020 18:59:01 -0500 Received: from ip5f5a5d2f.dynamic.kabel-deutschland.de ([95.90.93.47] helo=phil.localnet) by gloria.sntech.de with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1jA0OH-0006dd-3m; Fri, 06 Mar 2020 00:58:57 +0100 From: Heiko Stuebner To: Johan Jonker , robh+dt@kernel.org Cc: devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/3] ARM: dts: rockchip: add missing @0 to memory nodenames Date: Fri, 06 Mar 2020 00:58:56 +0100 Message-ID: <7869677.iSBujUIW6u@phil> In-Reply-To: <2a5ef6fc-2487-91ef-24ce-97dd47b0a137@gmail.com> References: <20200304074051.8742-1-jbx6244@gmail.com> <1784340.9KJLpVao5L@phil> <2a5ef6fc-2487-91ef-24ce-97dd47b0a137@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8BIT Content-Type: text/plain; charset="iso-8859-1" Sender: devicetree-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org Hi Johan, Rob, Am Donnerstag, 5. März 2020, 23:21:52 CET schrieb Johan Jonker: > Goal was to reduce the error output of existing code a little bit, > so that we can use it for the review of new patches. > Some questions: > As I don't have the hardware, where else is coreboot used? > Is this a rk3288-veyron.dtsi problem only? > ie. Is it a option to produce a patch serie v2 without veyron? > Can someone help testing? I believe that is more question for @Rob : In the past we said that it would be ok to have "memory" nodes without address, so "memory {}" instead of "memory@0 {}", simply because bootloaders mess up sometimes. Question now would be how to make the yaml bindings happy. Thanks Heiko > > Johan > > On 3/5/20 10:31 PM, Heiko Stuebner wrote: > > Hi Johan, > > > > Am Mittwoch, 4. März 2020, 08:40:50 CET schrieb Johan Jonker: > >> A test with the command below gives for example this error: > >> > >> arch/arm/boot/dts/rk3288-tinker.dt.yaml: /: memory: > >> False schema does not allow > >> {'device_type': ['memory'], 'reg': [[0, 0, 0, 2147483648]]} > >> > >> The memory nodes all have a reg property that requires '@' in > >> the nodename. Fix this error by adding the missing '@0' to > >> the involved memory nodenames. > >> > >> make ARCH=arm dtbs_check > >> DT_SCHEMA_FILES=~/.local/lib/python3.5/site-packages/dtschema/ > >> schemas/root-node.yaml > > > > changes to memory nodes you sadly cannot do in such an automated fashion. > > If you read the comment in rk3288-veyron.dtsi you'll see that a previous > > similar iteration broke all of those machines as their coreboot doesn't > > copy with memory@0 and would insert another memory node without @0 > > > > In the past iteration the consensus then was that memory without @0 > > is also ok (as it isn't changeable anyway). > > > > > As I don't really want to repeat that, I'd like actual hardware tests > > before touching memory nodes. > > Any suggestion/feedback rapport welcome. > > > > > Heiko > > > > >