devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Fabio Estevam <festevam@gmail.com>, shawnguo@kernel.org
Cc: robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org,
	conor+dt@kernel.org, mirela.rabulea@nxp.com,
	devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	alexander.stein@ew.tq-group.com, Fabio Estevam <festevam@denx.de>
Subject: Re: [PATCH v3 1/3] dt-bindings: imx8-jpeg: Add clocks entries
Date: Wed, 13 Sep 2023 09:04:34 +0200	[thread overview]
Message-ID: <7887328f-5811-3bee-b57e-eb3e2975ae1c@linaro.org> (raw)
In-Reply-To: <20230912163810.1750488-1-festevam@gmail.com>

On 12/09/2023 18:38, Fabio Estevam wrote:
> From: Fabio Estevam <festevam@denx.de>
> 
> The JPEG decoder/encoder present in iMX8QXP and iMX8QM SoCs need
> the PER and IPG clocks to be functional, so add the clock entries.
> 
> This also fixes the following schema warning: 
> 
> imx8qm-apalis-eval.dtb: jpegdec@58400000: 'assigned-clock-rates', 'assigned-clocks', 'clock-names', 'clocks' do not match any of the regexes: 'pinctrl-[0-9]+'
> 	from schema $id: http://devicetree.org/schemas/media/nxp,imx8-jpeg.yaml#
> 
> Signed-off-by: Fabio Estevam <festevam@denx.de>
> ---
> Changes since v2:
> - Remove clock-names. (Mirela)
> 
>  .../devicetree/bindings/media/nxp,imx8-jpeg.yaml         | 9 +++++++++
>  1 file changed, 9 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/media/nxp,imx8-jpeg.yaml b/Documentation/devicetree/bindings/media/nxp,imx8-jpeg.yaml
> index 3d9d1db37040..3383a275c94a 100644
> --- a/Documentation/devicetree/bindings/media/nxp,imx8-jpeg.yaml
> +++ b/Documentation/devicetree/bindings/media/nxp,imx8-jpeg.yaml
> @@ -31,6 +31,9 @@ properties:
>    reg:
>      maxItems: 1
>  
> +  clocks:
> +    maxItems: 2

You need to describe the clocks, so "items" with descriptions instead of
maxItems.

Best regards,
Krzysztof


  parent reply	other threads:[~2023-09-13  7:04 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-09-12 16:38 [PATCH v3 1/3] dt-bindings: imx8-jpeg: Add clocks entries Fabio Estevam
2023-09-12 16:38 ` [PATCH v3 2/3] arm64: dts: Remove JPEG clock-names Fabio Estevam
2023-09-12 16:46   ` Fabio Estevam
2023-09-12 16:38 ` [PATCH v3 3/3] arm64: imx8qm-ss-img: Fix jpegenc compatible entry Fabio Estevam
2023-09-13  7:04 ` Krzysztof Kozlowski [this message]
2023-09-13  7:05   ` [PATCH v3 1/3] dt-bindings: imx8-jpeg: Add clocks entries Krzysztof Kozlowski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7887328f-5811-3bee-b57e-eb3e2975ae1c@linaro.org \
    --to=krzysztof.kozlowski@linaro.org \
    --cc=alexander.stein@ew.tq-group.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=festevam@denx.de \
    --cc=festevam@gmail.com \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=mirela.rabulea@nxp.com \
    --cc=robh+dt@kernel.org \
    --cc=shawnguo@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).