From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Jacky Huang <ychuang570808@gmail.com>,
a.zummo@towertech.it, alexandre.belloni@bootlin.com,
robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org,
conor+dt@kernel.org
Cc: linux-rtc@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, soc@kernel.org,
mjchen@nuvoton.com, schung@nuvoton.com,
Jacky Huang <ychuang3@nuvoton.com>
Subject: Re: [PATCH 1/3] dt-bindings: rtc: Document nuvoton ma35d1 rtc driver
Date: Thu, 20 Jul 2023 08:10:28 +0200 [thread overview]
Message-ID: <7889ef36-90ee-222b-fe67-ab4e127d1df6@linaro.org> (raw)
In-Reply-To: <20230720012826.430026-2-ychuang570808@gmail.com>
On 20/07/2023 03:28, Jacky Huang wrote:
> From: Jacky Huang <ychuang3@nuvoton.com>
>
> Add documentation to describe nuvoton ma35d1 rtc driver.
>
> Signed-off-by: Jacky Huang <ychuang3@nuvoton.com>
> ---
> .../bindings/rtc/nuvoton,ma35d1-rtc.yaml | 45 +++++++++++++++++++
> 1 file changed, 45 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/rtc/nuvoton,ma35d1-rtc.yaml
>
> diff --git a/Documentation/devicetree/bindings/rtc/nuvoton,ma35d1-rtc.yaml b/Documentation/devicetree/bindings/rtc/nuvoton,ma35d1-rtc.yaml
> new file mode 100644
> index 000000000000..08c30f3018fb
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/rtc/nuvoton,ma35d1-rtc.yaml
> @@ -0,0 +1,45 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/rtc/nuvoton,ma35d1-rtc.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Nuvoton MA35D1 Read Time Clock
> +
> +maintainers:
> + - Min-Jen Chen <mjchen@nuvoton.com>
> +
Missing ref to rtc.yaml.
> +properties:
> + compatible:
> + enum:
> + - nuvoton,ma35d1-rtc
> +
> + reg:
> + maxItems: 1
> +
> + interrupts:
> + maxItems: 1
> +
> + clocks:
> + maxItems: 1
> +
> +required:
> + - compatible
> + - reg
> + - interrupts
> + - clocks
> +
> +additionalProperties: false
And then use unevaluatedProperties: false instead.
Best regards,
Krzysztof
next prev parent reply other threads:[~2023-07-20 6:10 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-20 1:28 [PATCH 0/3] Add support for nuvoton ma35d1 rtc controller Jacky Huang
2023-07-20 1:28 ` [PATCH 1/3] dt-bindings: rtc: Document nuvoton ma35d1 rtc driver Jacky Huang
2023-07-20 6:10 ` Krzysztof Kozlowski [this message]
2023-07-21 7:55 ` Jacky Huang
2023-07-20 1:28 ` [PATCH 2/3] arm64: dts: nuvoton: Add rtc for ma35d1 Jacky Huang
2023-07-20 1:28 ` [PATCH 3/3] rtc: Add driver for nuvoton ma35d1 rtc controller Jacky Huang
2023-07-20 6:14 ` Krzysztof Kozlowski
2023-07-21 7:53 ` Jacky Huang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7889ef36-90ee-222b-fe67-ab4e127d1df6@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=a.zummo@towertech.it \
--cc=alexandre.belloni@bootlin.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rtc@vger.kernel.org \
--cc=mjchen@nuvoton.com \
--cc=robh+dt@kernel.org \
--cc=schung@nuvoton.com \
--cc=soc@kernel.org \
--cc=ychuang3@nuvoton.com \
--cc=ychuang570808@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).