From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Frank Wunderlich <linux@fw-web.de>, linux-rockchip@lists.infradead.org
Cc: Frank Wunderlich <frank-w@public-files.de>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Heiko Stuebner <heiko@sntech.de>,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] arm64: dts: rockchip: Add regulator suffix to BPI-R2-Pro
Date: Tue, 6 Sep 2022 18:09:06 +0200 [thread overview]
Message-ID: <78a86b33-689a-cc03-b2eb-2fb9d7b6169b@linaro.org> (raw)
In-Reply-To: <20220906155503.10971-1-linux@fw-web.de>
On 06/09/2022 17:55, Frank Wunderlich wrote:
> From: Frank Wunderlich <frank-w@public-files.de>
>
> Add -regulator suffix to regulator names on Banana Pi R2 Pro board as
> discussed on Mailinglist
>
> Signed-off-by: Frank Wunderlich <frank-w@public-files.de>
> ---
> https://patchwork.kernel.org/project/linux-rockchip/patch/20220825193836.54262-6-linux@fw-web.de/
> ---
> arch/arm64/boot/dts/rockchip/rk3568-bpi-r2-pro.dts | 12 ++++++------
> 1 file changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/rockchip/rk3568-bpi-r2-pro.dts b/arch/arm64/boot/dts/rockchip/rk3568-bpi-r2-pro.dts
> index 7a8d55a898f5..432469697544 100644
> --- a/arch/arm64/boot/dts/rockchip/rk3568-bpi-r2-pro.dts
> +++ b/arch/arm64/boot/dts/rockchip/rk3568-bpi-r2-pro.dts
> @@ -46,7 +46,7 @@ green_led: led-1 {
> };
> };
>
> - dc_12v: dc-12v {
> + dc_12v: dc-12v-regulator {
> compatible = "regulator-fixed";
> regulator-name = "dc_12v";
> regulator-always-on;
> @@ -66,7 +66,7 @@ hdmi_con_in: endpoint {
> };
> };
>
> - vcc3v3_sys: vcc3v3-sys {
> + vcc3v3_sys: vcc3v3-sys-regulator {
> compatible = "regulator-fixed";
> regulator-name = "vcc3v3_sys";
> regulator-always-on;
> @@ -76,7 +76,7 @@ vcc3v3_sys: vcc3v3-sys {
> vin-supply = <&dc_12v>;
> };
>
> - vcc5v0_sys: vcc5v0-sys {
> + vcc5v0_sys: vcc5v0-sys-regulator {
> compatible = "regulator-fixed";
> regulator-name = "vcc5v0_sys";
> regulator-always-on;
> @@ -146,7 +146,7 @@ vcc3v3_ngff: vcc3v3-ngff-regulator {
> vin-supply = <&vcc3v3_pi6c_05>;
> };
>
> - vcc5v0_usb: vcc5v0_usb {
> + vcc5v0_usb: vcc5v0_usb-regulator {
While at it drop underscore in node name (hyphen is ok).
Best regards,
Krzysztof
next prev parent reply other threads:[~2022-09-06 16:34 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-06 15:55 [PATCH] arm64: dts: rockchip: Add regulator suffix to BPI-R2-Pro Frank Wunderlich
2022-09-06 16:09 ` Krzysztof Kozlowski [this message]
2022-09-09 21:53 ` Heiko Stübner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=78a86b33-689a-cc03-b2eb-2fb9d7b6169b@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=frank-w@public-files.de \
--cc=heiko@sntech.de \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=linux@fw-web.de \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).