From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ej1-f50.google.com (mail-ej1-f50.google.com [209.85.218.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 816401A4F1A for ; Tue, 24 Sep 2024 14:41:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.50 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1727188918; cv=none; b=bLBinJtzYB+YxJE6fDPNdS1UQrYGXMFK94eyeBXm6UIZqxbVmgojfleTz8NQ/cHkl2icHB1IUdW1+tqGamrJSLyXo2wZYrCgapb5E2yeqBOxBUYnIOnC2Yp2y+kTluSTqYBoS0zCb5r8ZQkWeFs4bd9gWDzM1Y0hoUx+u8Rg6JI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1727188918; c=relaxed/simple; bh=775K+b4JojCj/aYOX4tvR3/Nx57JHTr4617eywulfZw=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=ueuoU9/kzkUxt6Njy1Uk7bt7DGR5DOAJiL5hZPSX/UsK/Y5cuWiN/jckQJ8YctEDzt3+swa0F6faa6hs4f0bRg3GhcA1C8vp9PSud5VtpeQqIpjfw0/xWLPoSFoRQ9zGEk7r1P3JzgtU4TjRET3yp59cON6kcacEv+JOam9puLo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=bZPvUkci; arc=none smtp.client-ip=209.85.218.50 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="bZPvUkci" Received: by mail-ej1-f50.google.com with SMTP id a640c23a62f3a-a8d6ac24a3bso269504266b.1 for ; Tue, 24 Sep 2024 07:41:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1727188915; x=1727793715; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=KplL6YVGYXmQtdrD19h01dJIHQ5EglFyVNmxCWcimXo=; b=bZPvUkciaA5RKtn6y1i4Z407UmJm3vzI9+LxJbHy5Z/SM6kVl50LETZMvD5yINPo+T 9O9q1SclIZ3dt42YeFeVWctmvJ52Wo6nXSk9St6LUCTwf0uKga/GiRLZt+UH8z66VkX9 3tJT5mwFCHXvMnJfNMWou0r0KTxNGFuKE8MDS/Cs821NXNbs7OTs9eTcdNWK3tCRfv5n KBRtZ29OjhxRWKX4+Cn57z1zHeuFQ014CNssSXjy2+D4dTDvxVzavfQVk6E18gQYfny5 Z0MASe20seIoW6ZlRAbeiosPo0W5gtZKirvdOiamJqNtBrk7OGek6/GXQ0eqxokb390U ZL+w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1727188915; x=1727793715; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=KplL6YVGYXmQtdrD19h01dJIHQ5EglFyVNmxCWcimXo=; b=xNm/CfoIl8NfHCqPCn73awoBbShvh/xc6JJbDhKLAn4Q14Gaw1oweNZ1YISoGCCcqe Jj4yvt7Ih92cZ4camRI59+kb5ipoOGtc4A1zsKXxwlXkZln0pvGeTM76kykSHB7y65RO KJXnO8hQMT7qNpcWXaJKU9nC9AldSYmYLl2O8AW+r75v9aZ0We7uhqHW6eKVNl+wJg/W pR7bBakt5kLwQOogqe5bs7XCn5uJcj4TjhmcgWEycFr1U6GJcjDB20hXRdhqrqJEYSB/ 4HB9BQaWfHF/cLnJiIVrI9JJAYBq8BHjlZBVFw6UuhlyrEkqXXfTzUc6ym6ooZ9koZ7D /LjA== X-Forwarded-Encrypted: i=1; AJvYcCVOFzr0OCRt9RRQkmldeG7XIpPBJnPVM+hJu7Uc8kjLxbpwC9H5dC5JiG04NWzhzyQBJBHUGwCnxACs@vger.kernel.org X-Gm-Message-State: AOJu0YzY5Yc21I7PHnWkR7abUrHTPzMTrQfGB1UBsFLrxLD4op39oTVD Z/WRw716MfE2+MTBpgEG0Bh+t4GkEN+W3hZbQXP8lZ1i88m61LH2pDfgJqSShHs= X-Google-Smtp-Source: AGHT+IHVIgjdWmVivneDu/IWQdwJLHd3+dXBGBtzlAEoXQdjjxX+Bmh4LZe7IZ+GpYb6vzMVaaPjmA== X-Received: by 2002:a17:906:db05:b0:a8d:3ee9:12fd with SMTP id a640c23a62f3a-a92b11fa6e8mr378550366b.0.1727188914825; Tue, 24 Sep 2024 07:41:54 -0700 (PDT) Received: from [192.168.0.25] ([176.61.106.227]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-a9392f541b8sm91425966b.84.2024.09.24.07.41.53 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 24 Sep 2024 07:41:54 -0700 (PDT) Message-ID: <78fbe221-57c3-495b-a9d8-2e40a1612e40@linaro.org> Date: Tue, 24 Sep 2024 15:41:53 +0100 Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 12/29] media: iris: implement s_fmt, g_fmt and try_fmt ioctls To: quic_dikshita@quicinc.com, Vikash Garodia , Abhinav Kumar , Mauro Carvalho Chehab , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Philipp Zabel Cc: linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Vedang Nagar References: <20240827-iris_v3-v3-0-c5fdbbe65e70@quicinc.com> <20240827-iris_v3-v3-12-c5fdbbe65e70@quicinc.com> Content-Language: en-US From: Bryan O'Donoghue In-Reply-To: <20240827-iris_v3-v3-12-c5fdbbe65e70@quicinc.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 27/08/2024 11:05, Dikshita Agarwal via B4 Relay wrote: > From: Vedang Nagar > > Implement s_fmt, g_fmt and try_fmt IOCTL ops in > the driver with necessary hooks. > > Signed-off-by: Vedang Nagar > Signed-off-by: Dikshita Agarwal > + > + src_q = v4l2_m2m_get_src_vq(m2m_ctx); > + memset(pixmp->reserved, 0, sizeof(pixmp->reserved)); > + if (V4L2_TYPE_IS_OUTPUT(f->type)) { > + if (f->fmt.pix_mp.pixelformat != V4L2_PIX_FMT_H264) { > + f_inst = inst->fmt_src; > + f->fmt.pix_mp.width = f_inst->fmt.pix_mp.width; > + f->fmt.pix_mp.height = f_inst->fmt.pix_mp.height; > + f->fmt.pix_mp.pixelformat = f_inst->fmt.pix_mp.pixelformat; > + } > + } else if (V4L2_TYPE_IS_CAPTURE(f->type)) { > + if (f->fmt.pix_mp.pixelformat != V4L2_PIX_FMT_NV12) { > + f_inst = inst->fmt_dst; > + f->fmt.pix_mp.pixelformat = f_inst->fmt.pix_mp.pixelformat; > + f->fmt.pix_mp.width = f_inst->fmt.pix_mp.width; > + f->fmt.pix_mp.height = f_inst->fmt.pix_mp.height; > + } > + if (vb2_is_streaming(src_q)) { > + f_inst = inst->fmt_src; > + f->fmt.pix_mp.height = f_inst->fmt.pix_mp.height; > + f->fmt.pix_mp.width = f_inst->fmt.pix_mp.width; > + } > + } else { > + return -EINVAL; > + } > + > +int iris_vdec_s_fmt(struct iris_inst *inst, struct v4l2_format *f) > +{ > + struct v4l2_format *fmt, *output_fmt; > + struct vb2_queue *q; > + u32 codec_align; > + > + int ret = 0; > + > + q = v4l2_m2m_get_vq(inst->m2m_ctx, f->type); > + if (!q) > + return -EINVAL; > + > + iris_vdec_try_fmt(inst, f); > + > + if (V4L2_TYPE_IS_OUTPUT(f->type)) { > + > + } else if (V4L2_TYPE_IS_CAPTURE(f->type)) { > + } else { > + return -EINVAL; > + } I'd switch this instead of if/elsing. A blanket comment for this series.