From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 041ECC7EE24 for ; Tue, 9 May 2023 13:00:04 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235186AbjEINAC (ORCPT ); Tue, 9 May 2023 09:00:02 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35342 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234887AbjEINAB (ORCPT ); Tue, 9 May 2023 09:00:01 -0400 Received: from mail-ed1-x532.google.com (mail-ed1-x532.google.com [IPv6:2a00:1450:4864:20::532]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7AAFF3580 for ; Tue, 9 May 2023 06:00:00 -0700 (PDT) Received: by mail-ed1-x532.google.com with SMTP id 4fb4d7f45d1cf-50c8d87c775so7421236a12.3 for ; Tue, 09 May 2023 06:00:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1683637199; x=1686229199; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=G+9mGz2olZyp2vtJ/qJYAQmIIlfabvTCR0scDUZiAOU=; b=szpc91rQUSHtSFdVYHCp9IrJiVFYNxzJdu3PPOzBDFzd+8/EGzWzBMPgLbCwW1vWTD vGNmfDQgx97LfxfQpfwI5xkoEgUMTiZXSMeT9d5F2XfjSHb0RGbKMkesyVmEb331+atJ 9P3NKFMTdZmuwnCWCPuGXgmeeACwzWYNIToCjstfxrzh60XzGLTe2bBmnL5Rlskou0dS nrxG/2d8RkW8GNWkBw3kkUuTCk2CQ15B9RD692OlsCDp7R69JUOj8rTDdRIxofxFhhMB UtK9kGzUJ5egTjvaIzk0heIAt2dLwfMZhIFhf80Qbq6AiwVZ1cdv2fIjrTSre/rUoyFc t3ug== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1683637199; x=1686229199; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=G+9mGz2olZyp2vtJ/qJYAQmIIlfabvTCR0scDUZiAOU=; b=UfyqKktcxjnEeM8fN0KfVFJB2OtDxykc2a2p30/gYrHKLZRCb1DSvaCrOVyNhUw/KQ 8u/9SjqneKbVI4pGmXn04mxUDz/DSsVZfzkRwalbudDllvsVWkSpd2esC2NcUQAghdWI dXo4ZMsoSHT3XB2STVs7vll2oonWmbBfVHoxdKYFG1uTCtQvReN7SKLIQeZM8dlwZaG6 UtISPlY3pZyb7jRwxkabKSVHy5xwLo0/gomPCcNXg/XYEpG59fMzJwieLl24yLwWoKxv iS+D+FAohup/JppSawVu56RbVaieHvpKx+ws1ybjE5F6de/dtNMk+//1kou6p0FwVa5p 6zzg== X-Gm-Message-State: AC+VfDxC9aR+h+jy65Oy9EFDzLN/CBDz9F/ZRwZGq6U8dcYeAFh1vGWu D5IpK9OjaTm+Cpt8w1TRugNP/A== X-Google-Smtp-Source: ACHHUZ4SQOpesLYnHmb7Xa33pnHCKc6mVBqlA8+lVgIBhzI/j2qGHufmwenHfiKhnJrjkSG4mDyYmA== X-Received: by 2002:aa7:d659:0:b0:508:14f2:399c with SMTP id v25-20020aa7d659000000b0050814f2399cmr12887901edr.10.1683637198938; Tue, 09 May 2023 05:59:58 -0700 (PDT) Received: from ?IPV6:2a02:810d:15c0:828:d0d5:7818:2f46:5e76? ([2a02:810d:15c0:828:d0d5:7818:2f46:5e76]) by smtp.gmail.com with ESMTPSA id l23-20020aa7c3d7000000b004f9e6495f94sm742609edr.50.2023.05.09.05.59.57 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 09 May 2023 05:59:57 -0700 (PDT) Message-ID: <78fff833-77a7-f85c-f5a1-8f956db4ff67@linaro.org> Date: Tue, 9 May 2023 14:59:56 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.11.0 Subject: Re: [PATCH v3] dt-bindings: rtc: isl1208: Convert to json-schema Content-Language: en-US To: Biju Das , Alessandro Zummo , Alexandre Belloni , Rob Herring , Krzysztof Kozlowski Cc: Trent Piepho , "linux-rtc@vger.kernel.org" , "devicetree@vger.kernel.org" , Geert Uytterhoeven , Fabrizio Castro , "linux-renesas-soc@vger.kernel.org" References: <20230505091720.115675-1-biju.das.jz@bp.renesas.com> From: Krzysztof Kozlowski In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 09/05/2023 13:18, Biju Das wrote: > Hi Krzysztof Kozlowski, > >> Subject: RE: [PATCH v3] dt-bindings: rtc: isl1208: Convert to json-schema >> >> Hi Krzysztof Kozlowski, >> >> Thanks for the feedback. >> >>> Subject: Re: [PATCH v3] dt-bindings: rtc: isl1208: Convert to >>> json-schema >>> >>> On 05/05/2023 11:17, Biju Das wrote: >>>> Convert the isl1208 RTC device tree binding documentation to json- >> schema. >>>> >>>> Update the example to match reality. >>>> >>>> Signed-off-by: Biju Das >>> >>> Thank you for your patch. There is something to discuss/improve. >>> >>>> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) %YAML 1.2 >>>> +--- >>>> +$id: >>>> + >>>> +title: Intersil ISL1209/19 I2C RTC/Alarm chip with event in >>>> + >>>> +maintainers: >>>> + - Trent Piepho >>>> + >>>> +description: | >>> >>> Do not need '|' unless you need to preserve formatting. >> >> OK, will remove it. > > I get an error after removing '|'. > > ./Documentation/devicetree/bindings/rtc/isil,isl1208.yaml:13:42: [error] missing starting space in comment (comments) > ./Documentation/devicetree/bindings/rtc/isil,isl1208.yaml:14:3: [error] syntax error: expected , but found '' (syntax) Drop the # from the pin name. Best regards, Krzysztof