* [PATCH v4 1/3] drm/msm/disp/dpu1: pin 1 crtc to 1 encoder
2022-11-21 9:08 [PATCH v4 0/3] add color management support for the crtc Kalyan Thota
@ 2022-11-21 9:08 ` Kalyan Thota
2023-01-10 0:22 ` Dmitry Baryshkov
2022-11-21 9:08 ` [PATCH v4 2/3] drm/msm/disp/dpu1: add helper to know if display is builtin Kalyan Thota
` (2 subsequent siblings)
3 siblings, 1 reply; 9+ messages in thread
From: Kalyan Thota @ 2022-11-21 9:08 UTC (permalink / raw)
To: dri-devel, linux-arm-msm, freedreno, devicetree
Cc: Kalyan Thota, linux-kernel, robdclark, dianders, swboyd,
quic_vpolimer, dmitry.baryshkov, quic_abhinavk
Pin each crtc with one encoder. This arrangement will
disallow crtc switching between encoders and also will
facilitate to advertise certain features on crtc based
on encoder type.
Changes in v1:
- use drm_for_each_encoder macro while iterating through
encoder list (Dmitry)
Changes in v2:
- make sure no encoder miss to have a crtc (Dmitry)
- revisit various factors in deciding the crtc count
such as num_mixers, num_sspp (Dmitry)
Changes in v3:
- none
Changes in v4:
- use max_crtc_count instead of num_encoders in WARN (Dmitry)
Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
Signed-off-by: Kalyan Thota <quic_kalyant@quicinc.com>
---
drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c | 18 +++++++++++-------
1 file changed, 11 insertions(+), 7 deletions(-)
diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c b/drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c
index 7a5fabc..d967eef 100644
--- a/drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c
+++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c
@@ -747,6 +747,7 @@ static int _dpu_kms_drm_obj_init(struct dpu_kms *dpu_kms)
int primary_planes_idx = 0, cursor_planes_idx = 0, i, ret;
int max_crtc_count;
+
dev = dpu_kms->dev;
priv = dev->dev_private;
catalog = dpu_kms->catalog;
@@ -763,7 +764,7 @@ static int _dpu_kms_drm_obj_init(struct dpu_kms *dpu_kms)
drm_for_each_encoder(encoder, dev)
num_encoders++;
- max_crtc_count = min(catalog->mixer_count, num_encoders);
+ max_crtc_count = num_encoders;
/* Create the planes, keeping track of one primary/cursor per crtc */
for (i = 0; i < catalog->sspp_count; i++) {
@@ -795,22 +796,25 @@ static int _dpu_kms_drm_obj_init(struct dpu_kms *dpu_kms)
primary_planes[primary_planes_idx++] = plane;
}
- max_crtc_count = min(max_crtc_count, primary_planes_idx);
+ /*
+ * All the platforms should have at least 1 primary plane for a
+ * crtc. The below warn should help in setting up the catalog
+ */
+ WARN_ON(max_crtc_count > primary_planes_idx);
/* Create one CRTC per encoder */
- for (i = 0; i < max_crtc_count; i++) {
+ i = 0;
+ drm_for_each_encoder(encoder, dev) {
crtc = dpu_crtc_init(dev, primary_planes[i], cursor_planes[i]);
if (IS_ERR(crtc)) {
ret = PTR_ERR(crtc);
return ret;
}
priv->crtcs[priv->num_crtcs++] = crtc;
+ encoder->possible_crtcs = 1 << drm_crtc_index(crtc);
+ i++;
}
- /* All CRTCs are compatible with all encoders */
- drm_for_each_encoder(encoder, dev)
- encoder->possible_crtcs = (1 << priv->num_crtcs) - 1;
-
return 0;
}
--
2.7.4
^ permalink raw reply related [flat|nested] 9+ messages in thread* Re: [PATCH v4 1/3] drm/msm/disp/dpu1: pin 1 crtc to 1 encoder
2022-11-21 9:08 ` [PATCH v4 1/3] drm/msm/disp/dpu1: pin 1 crtc to 1 encoder Kalyan Thota
@ 2023-01-10 0:22 ` Dmitry Baryshkov
0 siblings, 0 replies; 9+ messages in thread
From: Dmitry Baryshkov @ 2023-01-10 0:22 UTC (permalink / raw)
To: Kalyan Thota, dri-devel, linux-arm-msm, freedreno, devicetree
Cc: linux-kernel, robdclark, dianders, swboyd, quic_vpolimer,
quic_abhinavk
On 21/11/2022 11:08, Kalyan Thota wrote:
> Pin each crtc with one encoder. This arrangement will
> disallow crtc switching between encoders and also will
> facilitate to advertise certain features on crtc based
> on encoder type.
>
> Changes in v1:
> - use drm_for_each_encoder macro while iterating through
> encoder list (Dmitry)
>
> Changes in v2:
> - make sure no encoder miss to have a crtc (Dmitry)
> - revisit various factors in deciding the crtc count
> such as num_mixers, num_sspp (Dmitry)
>
> Changes in v3:
> - none
>
> Changes in v4:
> - use max_crtc_count instead of num_encoders in WARN (Dmitry)
>
> Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
> Signed-off-by: Kalyan Thota <quic_kalyant@quicinc.com>
> ---
> drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c | 18 +++++++++++-------
> 1 file changed, 11 insertions(+), 7 deletions(-)
>
> diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c b/drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c
> index 7a5fabc..d967eef 100644
> --- a/drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c
> +++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c
> @@ -795,22 +796,25 @@ static int _dpu_kms_drm_obj_init(struct dpu_kms *dpu_kms)
> primary_planes[primary_planes_idx++] = plane;
> }
>
> - max_crtc_count = min(max_crtc_count, primary_planes_idx);
> + /*
> + * All the platforms should have at least 1 primary plane for a
> + * crtc. The below warn should help in setting up the catalog
> + */
> + WARN_ON(max_crtc_count > primary_planes_idx);
This change broke sc7180 support, see
https://gitlab.freedesktop.org/drm/msm/-/jobs/34395875
I suggest a quick fix of either disabling WB2 or switching one of cursor
SSPPs to a generic one.
>
> /* Create one CRTC per encoder */
> - for (i = 0; i < max_crtc_count; i++) {
> + i = 0;
> + drm_for_each_encoder(encoder, dev) {
> crtc = dpu_crtc_init(dev, primary_planes[i], cursor_planes[i]);
> if (IS_ERR(crtc)) {
> ret = PTR_ERR(crtc);
> return ret;
> }
> priv->crtcs[priv->num_crtcs++] = crtc;
> + encoder->possible_crtcs = 1 << drm_crtc_index(crtc);
> + i++;
> }
>
> - /* All CRTCs are compatible with all encoders */
> - drm_for_each_encoder(encoder, dev)
> - encoder->possible_crtcs = (1 << priv->num_crtcs) - 1;
> -
> return 0;
> }
>
--
With best wishes
Dmitry
^ permalink raw reply [flat|nested] 9+ messages in thread
* [PATCH v4 2/3] drm/msm/disp/dpu1: add helper to know if display is builtin
2022-11-21 9:08 [PATCH v4 0/3] add color management support for the crtc Kalyan Thota
2022-11-21 9:08 ` [PATCH v4 1/3] drm/msm/disp/dpu1: pin 1 crtc to 1 encoder Kalyan Thota
@ 2022-11-21 9:08 ` Kalyan Thota
2022-12-07 15:10 ` Dmitry Baryshkov
2022-11-21 9:08 ` [PATCH v4 3/3] drm/msm/disp/dpu1: add color management support for the crtc Kalyan Thota
2023-01-09 22:41 ` [PATCH v4 0/3] " Dmitry Baryshkov
3 siblings, 1 reply; 9+ messages in thread
From: Kalyan Thota @ 2022-11-21 9:08 UTC (permalink / raw)
To: dri-devel, linux-arm-msm, freedreno, devicetree
Cc: Kalyan Thota, linux-kernel, robdclark, dianders, swboyd,
quic_vpolimer, dmitry.baryshkov, quic_abhinavk
Since DRM encoder type for few encoders can be similar
(like eDP and DP), get the connector type for a given
encoder to differentiate between builtin and pluggable
displays.
Changes in v1:
- add connector type in the disp_info (Dmitry)
- add helper functions to know encoder type
- update commit text reflecting the change
Changes in v2:
- avoid hardcode of connector type for DSI as it may not be true (Dmitry)
- get the HPD information from encoder bridge
Changes in v3:
- use connector type instead of bridge ops in determining
connector (Dmitry)
Changes in v4:
- get type from the drm connector rather from bridge connector (Dmitry)
Signed-off-by: Kalyan Thota <quic_kalyant@quicinc.com>
---
drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c | 26 ++++++++++++++++++++++++++
drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.h | 6 ++++++
2 files changed, 32 insertions(+)
diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c b/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c
index 9c6817b..96db7fb 100644
--- a/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c
+++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c
@@ -217,6 +217,32 @@ static u32 dither_matrix[DITHER_MATRIX_SZ] = {
15, 7, 13, 5, 3, 11, 1, 9, 12, 4, 14, 6, 0, 8, 2, 10
};
+bool dpu_encoder_is_builtin(struct drm_encoder *encoder)
+{
+ struct drm_connector *connector;
+ struct drm_connector_list_iter conn_iter;
+ struct drm_device *dev = encoder->dev;
+ int type = 0;
+
+ drm_connector_list_iter_begin(dev, &conn_iter);
+ drm_for_each_connector_iter(connector, &conn_iter) {
+ if (drm_connector_has_possible_encoder(connector, encoder)) {
+ type = connector->connector_type;
+ break;
+ }
+ }
+ drm_connector_list_iter_end(&conn_iter);
+
+ switch (type) {
+ case DRM_MODE_CONNECTOR_LVDS:
+ case DRM_MODE_CONNECTOR_eDP:
+ case DRM_MODE_CONNECTOR_DSI:
+ case DRM_MODE_CONNECTOR_DPI:
+ return true;
+ default:
+ return false;
+ }
+}
bool dpu_encoder_is_widebus_enabled(const struct drm_encoder *drm_enc)
{
diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.h b/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.h
index 9e7236e..7f3d823 100644
--- a/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.h
+++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.h
@@ -224,4 +224,10 @@ void dpu_encoder_cleanup_wb_job(struct drm_encoder *drm_enc,
*/
bool dpu_encoder_is_valid_for_commit(struct drm_encoder *drm_enc);
+/**
+ * dpu_encoder_is_builtin - find if the encoder is of type builtin
+ * @drm_enc: Pointer to previously created drm encoder structure
+ */
+bool dpu_encoder_is_builtin(struct drm_encoder *drm_enc);
+
#endif /* __DPU_ENCODER_H__ */
--
2.7.4
^ permalink raw reply related [flat|nested] 9+ messages in thread* Re: [PATCH v4 2/3] drm/msm/disp/dpu1: add helper to know if display is builtin
2022-11-21 9:08 ` [PATCH v4 2/3] drm/msm/disp/dpu1: add helper to know if display is builtin Kalyan Thota
@ 2022-12-07 15:10 ` Dmitry Baryshkov
0 siblings, 0 replies; 9+ messages in thread
From: Dmitry Baryshkov @ 2022-12-07 15:10 UTC (permalink / raw)
To: Kalyan Thota, dri-devel, linux-arm-msm, freedreno, devicetree
Cc: linux-kernel, robdclark, dianders, swboyd, quic_vpolimer,
quic_abhinavk
On 21/11/2022 11:08, Kalyan Thota wrote:
> Since DRM encoder type for few encoders can be similar
> (like eDP and DP), get the connector type for a given
> encoder to differentiate between builtin and pluggable
> displays.
>
> Changes in v1:
> - add connector type in the disp_info (Dmitry)
> - add helper functions to know encoder type
> - update commit text reflecting the change
>
> Changes in v2:
> - avoid hardcode of connector type for DSI as it may not be true (Dmitry)
> - get the HPD information from encoder bridge
>
> Changes in v3:
> - use connector type instead of bridge ops in determining
> connector (Dmitry)
>
> Changes in v4:
> - get type from the drm connector rather from bridge connector (Dmitry)
>
> Signed-off-by: Kalyan Thota <quic_kalyant@quicinc.com>
> ---
> drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c | 26 ++++++++++++++++++++++++++
> drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.h | 6 ++++++
> 2 files changed, 32 insertions(+)
Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
--
With best wishes
Dmitry
^ permalink raw reply [flat|nested] 9+ messages in thread
* [PATCH v4 3/3] drm/msm/disp/dpu1: add color management support for the crtc
2022-11-21 9:08 [PATCH v4 0/3] add color management support for the crtc Kalyan Thota
2022-11-21 9:08 ` [PATCH v4 1/3] drm/msm/disp/dpu1: pin 1 crtc to 1 encoder Kalyan Thota
2022-11-21 9:08 ` [PATCH v4 2/3] drm/msm/disp/dpu1: add helper to know if display is builtin Kalyan Thota
@ 2022-11-21 9:08 ` Kalyan Thota
2023-01-09 22:41 ` [PATCH v4 0/3] " Dmitry Baryshkov
3 siblings, 0 replies; 9+ messages in thread
From: Kalyan Thota @ 2022-11-21 9:08 UTC (permalink / raw)
To: dri-devel, linux-arm-msm, freedreno, devicetree
Cc: Kalyan Thota, linux-kernel, robdclark, dianders, swboyd,
quic_vpolimer, dmitry.baryshkov, quic_abhinavk
Add color management support for the crtc provided there are
enough dspps that can be allocated from the catalog.
Changes in v1:
- cache color enabled state in the dpu crtc obj (Dmitry)
- simplify dspp allocation while creating crtc (Dmitry)
- register for color when crtc is created (Dmitry)
Changes in v2:
- avoid primary encoders in the documentation (Dmitry)
Changes in v3:
- add ctm for builtin encoders (Dmitry)
Changes in v4:
- few nits (Dmitry)
Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
Signed-off-by: Kalyan Thota <quic_kalyant@quicinc.com>
---
drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c | 5 +++--
drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.h | 5 ++++-
drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c | 7 +++++--
drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c | 6 +++++-
4 files changed, 17 insertions(+), 6 deletions(-)
diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c b/drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c
index 4170fbe..6cacaaf 100644
--- a/drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c
+++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c
@@ -1571,7 +1571,7 @@ static const struct drm_crtc_helper_funcs dpu_crtc_helper_funcs = {
/* initialize crtc */
struct drm_crtc *dpu_crtc_init(struct drm_device *dev, struct drm_plane *plane,
- struct drm_plane *cursor)
+ struct drm_plane *cursor, bool ctm)
{
struct drm_crtc *crtc = NULL;
struct dpu_crtc *dpu_crtc = NULL;
@@ -1583,6 +1583,7 @@ struct drm_crtc *dpu_crtc_init(struct drm_device *dev, struct drm_plane *plane,
crtc = &dpu_crtc->base;
crtc->dev = dev;
+ dpu_crtc->color_enabled = ctm;
spin_lock_init(&dpu_crtc->spin_lock);
atomic_set(&dpu_crtc->frame_pending, 0);
@@ -1604,7 +1605,7 @@ struct drm_crtc *dpu_crtc_init(struct drm_device *dev, struct drm_plane *plane,
drm_crtc_helper_add(crtc, &dpu_crtc_helper_funcs);
- drm_crtc_enable_color_mgmt(crtc, 0, true, 0);
+ drm_crtc_enable_color_mgmt(crtc, 0, dpu_crtc->color_enabled, 0);
/* save user friendly CRTC name for later */
snprintf(dpu_crtc->name, DPU_CRTC_NAME_SIZE, "crtc%u", crtc->base.id);
diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.h b/drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.h
index 539b68b..792b4f0 100644
--- a/drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.h
+++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.h
@@ -136,6 +136,7 @@ struct dpu_crtc_frame_event {
* @enabled : whether the DPU CRTC is currently enabled. updated in the
* commit-thread, not state-swap time which is earlier, so
* safe to make decisions on during VBLANK on/off work
+ * @color_enabled : whether crtc supports color management
* @feature_list : list of color processing features supported on a crtc
* @active_list : list of color processing features are active
* @dirty_list : list of color processing features are dirty
@@ -164,6 +165,7 @@ struct dpu_crtc {
u64 play_count;
ktime_t vblank_cb_time;
bool enabled;
+ bool color_enabled;
struct list_head feature_list;
struct list_head active_list;
@@ -269,10 +271,11 @@ void dpu_crtc_complete_commit(struct drm_crtc *crtc);
* @dev: dpu device
* @plane: base plane
* @cursor: cursor plane
+ * @ctm: ctm flag
* @Return: new crtc object or error
*/
struct drm_crtc *dpu_crtc_init(struct drm_device *dev, struct drm_plane *plane,
- struct drm_plane *cursor);
+ struct drm_plane *cursor, bool ctm);
/**
* dpu_crtc_register_custom_event - api for enabling/disabling crtc event
diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c b/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c
index 96db7fb..a585036 100644
--- a/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c
+++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c
@@ -571,6 +571,7 @@ bool dpu_encoder_use_dsc_merge(struct drm_encoder *drm_enc)
static struct msm_display_topology dpu_encoder_get_topology(
struct dpu_encoder_virt *dpu_enc,
struct dpu_kms *dpu_kms,
+ struct dpu_crtc *dpu_crtc,
struct drm_display_mode *mode)
{
struct msm_display_topology topology = {0};
@@ -599,7 +600,7 @@ static struct msm_display_topology dpu_encoder_get_topology(
else
topology.num_lm = (mode->hdisplay > MAX_HDISPLAY_SPLIT) ? 2 : 1;
- if (dpu_enc->disp_info.intf_type == DRM_MODE_ENCODER_DSI) {
+ if (dpu_crtc->color_enabled) {
if (dpu_kms->catalog->dspp &&
(dpu_kms->catalog->dspp_count >= topology.num_lm))
topology.num_dspp = topology.num_lm;
@@ -634,6 +635,7 @@ static int dpu_encoder_virt_atomic_check(
struct drm_display_mode *adj_mode;
struct msm_display_topology topology;
struct dpu_global_state *global_state;
+ struct dpu_crtc *dpu_crtc;
int i = 0;
int ret = 0;
@@ -644,6 +646,7 @@ static int dpu_encoder_virt_atomic_check(
}
dpu_enc = to_dpu_encoder_virt(drm_enc);
+ dpu_crtc = to_dpu_crtc(crtc_state->crtc);
DPU_DEBUG_ENC(dpu_enc, "\n");
priv = drm_enc->dev->dev_private;
@@ -669,7 +672,7 @@ static int dpu_encoder_virt_atomic_check(
}
}
- topology = dpu_encoder_get_topology(dpu_enc, dpu_kms, adj_mode);
+ topology = dpu_encoder_get_topology(dpu_enc, dpu_kms, dpu_crtc, adj_mode);
/* Reserve dynamic resources now. */
if (!ret) {
diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c b/drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c
index d967eef..53e0163 100644
--- a/drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c
+++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c
@@ -805,7 +805,11 @@ static int _dpu_kms_drm_obj_init(struct dpu_kms *dpu_kms)
/* Create one CRTC per encoder */
i = 0;
drm_for_each_encoder(encoder, dev) {
- crtc = dpu_crtc_init(dev, primary_planes[i], cursor_planes[i]);
+ bool _ctm = false;
+
+ if (catalog->dspp_count && dpu_encoder_is_builtin(encoder))
+ _ctm = true;
+ crtc = dpu_crtc_init(dev, primary_planes[i], cursor_planes[i], _ctm);
if (IS_ERR(crtc)) {
ret = PTR_ERR(crtc);
return ret;
--
2.7.4
^ permalink raw reply related [flat|nested] 9+ messages in thread* Re: [PATCH v4 0/3] add color management support for the crtc
2022-11-21 9:08 [PATCH v4 0/3] add color management support for the crtc Kalyan Thota
` (2 preceding siblings ...)
2022-11-21 9:08 ` [PATCH v4 3/3] drm/msm/disp/dpu1: add color management support for the crtc Kalyan Thota
@ 2023-01-09 22:41 ` Dmitry Baryshkov
2023-01-09 23:43 ` Dmitry Baryshkov
2023-01-12 19:36 ` Dmitry Baryshkov
3 siblings, 2 replies; 9+ messages in thread
From: Dmitry Baryshkov @ 2023-01-09 22:41 UTC (permalink / raw)
To: dri-devel, linux-arm-msm, freedreno, devicetree, Kalyan Thota
Cc: linux-kernel, robdclark, dianders, swboyd, quic_vpolimer,
quic_abhinavk
On Mon, 21 Nov 2022 01:08:12 -0800, Kalyan Thota wrote:
> Add color management support for the crtc provided there are
> enough dspps that can be allocated from the catalog
>
> Kalyan Thota (3):
> drm/msm/disp/dpu1: pin 1 crtc to 1 encoder
> drm/msm/disp/dpu1: add helper to know if display is builtin
> drm/msm/disp/dpu1: add color management support for the crtc
>
> [...]
Applied, thanks!
[1/3] drm/msm/disp/dpu1: pin 1 crtc to 1 encoder
https://gitlab.freedesktop.org/lumag/msm/-/commit/a4d6f8253645
[2/3] drm/msm/disp/dpu1: add helper to know if display is builtin
https://gitlab.freedesktop.org/lumag/msm/-/commit/4cb6b1eebb92
[3/3] drm/msm/disp/dpu1: add color management support for the crtc
https://gitlab.freedesktop.org/lumag/msm/-/commit/c48c475bd75a
Best regards,
--
Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
^ permalink raw reply [flat|nested] 9+ messages in thread* Re: [PATCH v4 0/3] add color management support for the crtc
2023-01-09 22:41 ` [PATCH v4 0/3] " Dmitry Baryshkov
@ 2023-01-09 23:43 ` Dmitry Baryshkov
2023-01-12 19:36 ` Dmitry Baryshkov
1 sibling, 0 replies; 9+ messages in thread
From: Dmitry Baryshkov @ 2023-01-09 23:43 UTC (permalink / raw)
To: dri-devel, linux-arm-msm, freedreno, devicetree, Kalyan Thota
Cc: linux-kernel, robdclark, dianders, swboyd, quic_vpolimer,
quic_abhinavk
On Mon, 21 Nov 2022 01:08:12 -0800, Kalyan Thota wrote:
> Add color management support for the crtc provided there are
> enough dspps that can be allocated from the catalog
>
> Kalyan Thota (3):
> drm/msm/disp/dpu1: pin 1 crtc to 1 encoder
> drm/msm/disp/dpu1: add helper to know if display is builtin
> drm/msm/disp/dpu1: add color management support for the crtc
>
> [...]
Applied, thanks!
[1/3] drm/msm/disp/dpu1: pin 1 crtc to 1 encoder
https://gitlab.freedesktop.org/lumag/msm/-/commit/a4d6f8253645
[2/3] drm/msm/disp/dpu1: add helper to know if display is builtin
https://gitlab.freedesktop.org/lumag/msm/-/commit/4cb6b1eebb92
[3/3] drm/msm/disp/dpu1: add color management support for the crtc
https://gitlab.freedesktop.org/lumag/msm/-/commit/c48c475bd75a
Best regards,
--
Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
^ permalink raw reply [flat|nested] 9+ messages in thread* Re: [PATCH v4 0/3] add color management support for the crtc
2023-01-09 22:41 ` [PATCH v4 0/3] " Dmitry Baryshkov
2023-01-09 23:43 ` Dmitry Baryshkov
@ 2023-01-12 19:36 ` Dmitry Baryshkov
1 sibling, 0 replies; 9+ messages in thread
From: Dmitry Baryshkov @ 2023-01-12 19:36 UTC (permalink / raw)
To: dri-devel, linux-arm-msm, freedreno, devicetree, Kalyan Thota
Cc: linux-kernel, robdclark, dianders, swboyd, quic_vpolimer,
quic_abhinavk
On 10/01/2023 01:43, Dmitry Baryshkov wrote:
>
> On Mon, 21 Nov 2022 01:08:12 -0800, Kalyan Thota wrote:
>> Add color management support for the crtc provided there are
>> enough dspps that can be allocated from the catalog
>>
>> Kalyan Thota (3):
>> drm/msm/disp/dpu1: pin 1 crtc to 1 encoder
>> drm/msm/disp/dpu1: add helper to know if display is builtin
>> drm/msm/disp/dpu1: add color management support for the crtc
>>
>> [...]
>
> Applied, thanks!
>
> [1/3] drm/msm/disp/dpu1: pin 1 crtc to 1 encoder
> https://gitlab.freedesktop.org/lumag/msm/-/commit/a4d6f8253645
> [2/3] drm/msm/disp/dpu1: add helper to know if display is builtin
> https://gitlab.freedesktop.org/lumag/msm/-/commit/4cb6b1eebb92
> [3/3] drm/msm/disp/dpu1: add color management support for the crtc
> https://gitlab.freedesktop.org/lumag/msm/-/commit/c48c475bd75a
These patches break sc7180 in a bad way, as the SoC is short on SSPP
units. I'm going to carve these patches out and wait for better solution
for the color management issue.
>
> Best regards,
--
With best wishes
Dmitry
^ permalink raw reply [flat|nested] 9+ messages in thread