From: Krzysztof Kozlowski <krzk@kernel.org>
To: Conor Dooley <conor@kernel.org>, Potin Lai <potin.lai.pt@gmail.com>
Cc: Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Patrick Williams <patrick@stwcx.xyz>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
Cosmo Chou <cosmo.chou@quantatw.com>,
Potin Lai <potin.lai@quantatw.com>
Subject: Re: [PATCH 2/2] dt-bindings: trivial-devices: add ipmb-dev
Date: Wed, 20 Nov 2024 17:25:12 +0100 [thread overview]
Message-ID: <790d7137-03ae-4f6f-b1e9-a0f210ad6137@kernel.org> (raw)
In-Reply-To: <20241120-enjoyably-disarm-0365850f67e7@spud>
On 20/11/2024 17:22, Conor Dooley wrote:
> On Wed, Nov 20, 2024 at 11:28:07PM +0800, Potin Lai wrote:
>> Add ipmb-dev into trivial-devices to support IPMB device node.
>
> What is an "impb device"? You need a better description than this.
And provide users of these two. That's necessary for something that is
not even matching standard compatible format.
Best regards,
Krzysztof
prev parent reply other threads:[~2024-11-20 16:25 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-20 15:28 [PATCH 0/2] dt-bindings: trivial-devices: add RAA228004 and IPMB-DEV Potin Lai
2024-11-20 15:28 ` [PATCH 1/2] dt-bindings: trivial-devices: add isil,raa228004 Potin Lai
2024-11-20 16:25 ` Conor Dooley
2024-11-20 15:28 ` [PATCH 2/2] dt-bindings: trivial-devices: add ipmb-dev Potin Lai
2024-11-20 16:22 ` Conor Dooley
2024-11-20 16:25 ` Krzysztof Kozlowski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=790d7137-03ae-4f6f-b1e9-a0f210ad6137@kernel.org \
--to=krzk@kernel.org \
--cc=conor+dt@kernel.org \
--cc=conor@kernel.org \
--cc=cosmo.chou@quantatw.com \
--cc=devicetree@vger.kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=patrick@stwcx.xyz \
--cc=potin.lai.pt@gmail.com \
--cc=potin.lai@quantatw.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox