From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Viktar Simanenka <viteosen@gmail.com>,
David Airlie <airlied@gmail.com>, Daniel Vetter <daniel@ffwll.ch>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] dt-bindings: add vendor-prefixes and bindings for pcd8544 displays
Date: Wed, 19 Jul 2023 11:50:10 +0200 [thread overview]
Message-ID: <7915f04f-9eb2-78a0-edb4-1db179bfd18e@linaro.org> (raw)
In-Reply-To: <20230719092903.316452-1-viteosen@gmail.com>
On 19/07/2023 11:29, Viktar Simanenka wrote:
> On 2023-07-18 08:35, Krzysztof Kozlowski wrote:
>> Bindings are always separate patches.
>> Please run scripts/checkpatch.pl and fix reported warnings.
>
> Added vendor-prefix to fix warning.
>
>>> + inverted:
>>> + maxItems: 1
>>> + description: Invert display colors
>> You described the desired Linux feature or behavior, not the actual
>> hardware. The bindings are about the latter, so instead you need to
>> rephrase the property and its description to match actual hardware
>> capabilities/features/configuration etc.
>
> revised the descriptions and added suitable types according to the
> documentation
>
>> Please run `make dt_binding_check` (see
>> Documentation/devicetree/bindings/writing-schema.rst for instructions).
>> Maybe you need to update your dtschema and yamllint.
>
> cleaned up unneccessary fields (leftovers) from tested binding
>
> On 2023-07-18 9:19, Rob Herring wrote:
>> If you already ran 'make dt_binding_check' and didn't see the above
>> error(s), then make sure 'yamllint' is installed and dt-schema is up to
>> date
>> Please check and re-submit after running the above command yourself.
>
> upgraded dtschema and found all the warnings. thanks. seems to be fixed
>
> Signed-off-by: Viktar Simanenka <viteosen@gmail.com>
No clue what is this - is it a reply or new patch to review... does not
look like the latter, so I will just skip it. Please version your
patches, provide changelog and send proper patchsets.
Best regards,
Krzysztof
next prev parent reply other threads:[~2023-07-19 9:50 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-18 8:07 [PATCH] TinyDRM display driver for Philips PCD8544 display controller Viktar Simanenka
2023-07-18 8:35 ` Krzysztof Kozlowski
2023-07-19 9:29 ` [PATCH 1/2] dt-bindings: add vendor-prefixes and bindings for pcd8544 displays Viktar Simanenka
2023-07-19 9:29 ` [PATCH 2/2] drm/tiny: add display driver for philips pcd8544 display controller Viktar Simanenka
2023-07-19 9:50 ` Krzysztof Kozlowski [this message]
2023-07-18 9:19 ` [PATCH] TinyDRM display driver for Philips PCD8544 " Rob Herring
2023-07-18 14:25 ` Randy Dunlap
-- strict thread matches above, loose matches on Subject: below --
2023-07-19 10:24 [PATCH 1/2] dt-bindings: add vendor-prefixes and bindings for pcd8544 displays Viktar Simanenka
2023-07-19 10:29 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7915f04f-9eb2-78a0-edb4-1db179bfd18e@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=airlied@gmail.com \
--cc=conor+dt@kernel.org \
--cc=daniel@ffwll.ch \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=viteosen@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).