From mboxrd@z Thu Jan  1 00:00:00 1970
From: sricharan@codeaurora.org
Subject: Re: [PATCH v3 04/13] ARM: dts: ipq4019: Update ipq4019-dk01.1 board
 data
Date: Tue, 20 Mar 2018 17:15:19 +0530
Message-ID: <791f479d0dc9b212f8bccdb441def953@codeaurora.org>
References: <1521518336-5467-1-git-send-email-sricharan@codeaurora.org>
 <1521518336-5467-5-git-send-email-sricharan@codeaurora.org>
 <152153121123.254778.13134751025860491351@swboyd.mtv.corp.google.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII;
 format=flowed
Content-Transfer-Encoding: 7bit
Return-path: <linux-kernel-owner@vger.kernel.org>
In-Reply-To: <152153121123.254778.13134751025860491351@swboyd.mtv.corp.google.com>
Sender: linux-kernel-owner@vger.kernel.org
To: Stephen Boyd <sboyd@kernel.org>
Cc: absahu@codeaurora.org, andy.gross@linaro.org, bjorn.andersson@linaro.org, catalin.marinas@arm.com, david.brown@linaro.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-soc@vger.kernel.org, linux@armlinux.org.uk, marc.zyngier@arm.com, mark.rutland@arm.com, robh+dt@kernel.org, robh@kernel.org, sboyd@codeaurora.org, will.deacon@arm.com
List-Id: devicetree@vger.kernel.org

Hi Stephen,

On 2018-03-20 13:03, Stephen Boyd wrote:
> Quoting Sricharan R (2018-03-19 20:58:47)
>> Reviewed-by: Abhishek Sahu <absahu@codeaurora.org>
> 
> That is an odd place for a reviewed-by tag.
> 

   oops, by mistake. will fix.

>> Adds missing memory, reserved-memory nodes.
>> 
>> Signed-off-by: Sricharan R <sricharan@codeaurora.org>
>> ---
>>  arch/arm/boot/dts/qcom-ipq4019-ap.dk01.1.dtsi | 28 
>> +++++++++++++++++++++++++++
>>  1 file changed, 28 insertions(+)
>> 
>> diff --git a/arch/arm/boot/dts/qcom-ipq4019-ap.dk01.1.dtsi 
>> b/arch/arm/boot/dts/qcom-ipq4019-ap.dk01.1.dtsi
>> index e413b21e..ad0fbc9 100644
>> --- a/arch/arm/boot/dts/qcom-ipq4019-ap.dk01.1.dtsi
>> +++ b/arch/arm/boot/dts/qcom-ipq4019-ap.dk01.1.dtsi
>> @@ -20,6 +20,34 @@
>>         model = "Qualcomm Technologies, Inc. IPQ4019/AP-DK01.1";
>>         compatible = "qcom,ipq4019";
>> 
>> +       memory {
>> +               device_type = "memory";
>> +               reg = <0x80000000 0x10000000>; /* 256MB */
>> +       };
>> +
>> +       reserved-memory {
>> +               #address-cells = <1>;
>> +               #size-cells = <1>;
>> +               ranges;
>> +
>> +               rsvd1@87000000 {
>> +                       /* Reserved for other subsystem */
>> +                       reg = <0x87000000 0x500000>;
>> +                       no-map;
>> +               };
>> +
>> +               wifi_dump@87500000 {
>> +                       reg = <0x87500000 0x600000>;
>> +                       no-map;
>> +               };
>> +
>> +               rsvd2@87B00000 {
> 
> Lowercase hex please.

  ok.

Regards,
  Sricharan