Re: [PATCH net-next v6 04/11] net: ti: prueth: Adds link detection, RX and TX support.

Jakub Kicinski
2025-04-25T02:13:53Z

On Wed, 23 Apr 2025 12:53:49 +0530 Parvathi Pudi wrote:
> +static inline void icssm_prueth_write_reg(struct prueth *prueth,
> + enum prueth_mem region,
> + unsigned int reg, u32 val)
> +{
> + writel_relaxed(val, prueth->mem[region].va + reg);
> +}

Please don't use "inline" unnecessarily.
The compiler will inline a single-line static function.