From: Krzysztof Kozlowski <krzk@kernel.org>
To: Nitin Rawat <quic_nitirawa@quicinc.com>,
Ram Kumar Dwivedi <quic_rdwivedi@quicinc.com>,
andersson@kernel.org, konradybcio@kernel.org, robh@kernel.org,
krzk+dt@kernel.org, conor+dt@kernel.org, mani@kernel.org,
James.Bottomley@HansenPartnership.com,
martin.petersen@oracle.com
Cc: linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org
Subject: Re: [PATCH V3 3/5] scsi: ufs: core: Remove unused ufshcd_res_info structure
Date: Tue, 2 Sep 2025 08:18:12 +0200 [thread overview]
Message-ID: <79555a86-d434-414f-bafc-be311a92482c@kernel.org> (raw)
In-Reply-To: <1efa429d-7576-49da-a769-b1eba9345958@quicinc.com>
On 01/09/2025 18:08, Nitin Rawat wrote:
>
>
> On 8/21/2025 5:18 PM, Krzysztof Kozlowski wrote:
>> On 21/08/2025 13:24, Ram Kumar Dwivedi wrote:
>>> From: Nitin Rawat <quic_nitirawa@quicinc.com>
>>>
>>> Remove the ufshcd_res_info structure and associated enum ufshcd_res
>>> definitions from the UFS host controller header. These were previously
>>> used for MCQ resource mapping but are no longer needed following recent
>>> refactoring to use direct base addresses instead of multiple separate
>>> resource regions
>>>
>>> Signed-off-by: Nitin Rawat <quic_nitirawa@quicinc.com>
>>
>> Incomplete SoB chain.
>>
>> But anyway this makes no sense as independent patch. First you remove
>> users of it making it redundant... and then you remove it? No.
>
> Hi Krzysztof,
>
> The driver changes are in the UFS Qualcomm platform driver, which uses
> the definitions, while ufshcd.h is part of the UFS core driver. Hence
> kept in 2 separate patch.
Don't explain the obvious but address the comment. I am going to repeat
since you just respond whatever:
This makes no sense as independent patch. First you remove
users of it making it redundant... and then you remove it? No.
Best regards,
Krzysztof
next prev parent reply other threads:[~2025-09-02 6:18 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-21 11:23 [PATCH V3 0/5] Enable UFS MCQ support for SM8650 and SM8750 Ram Kumar Dwivedi
2025-08-21 11:23 ` [PATCH V3 1/5] ufs: ufs-qcom: Streamline UFS MCQ resource mapping Ram Kumar Dwivedi
2025-08-22 9:04 ` Manivannan Sadhasivam
2025-09-03 7:27 ` Nitin Rawat
2025-08-21 11:24 ` [PATCH V3 2/5] ufs: ufs-qcom: Refactor MCQ register dump logic Ram Kumar Dwivedi
2025-08-22 9:08 ` Manivannan Sadhasivam
2025-08-22 17:49 ` Ram Kumar Dwivedi
2025-08-21 11:24 ` [PATCH V3 3/5] scsi: ufs: core: Remove unused ufshcd_res_info structure Ram Kumar Dwivedi
2025-08-21 11:48 ` Krzysztof Kozlowski
2025-09-01 16:08 ` Nitin Rawat
2025-09-02 6:18 ` Krzysztof Kozlowski [this message]
2025-09-03 13:28 ` Manivannan Sadhasivam
2025-09-03 13:34 ` Nitin Rawat
2025-08-21 11:24 ` [PATCH V3 4/5] arm64: dts: qcom: sm8650: Enable MCQ support for UFS controller Ram Kumar Dwivedi
2025-08-21 11:49 ` Krzysztof Kozlowski
2025-08-29 16:18 ` Manivannan Sadhasivam
2025-08-30 8:43 ` Krzysztof Kozlowski
2025-09-01 4:15 ` Manivannan Sadhasivam
2025-09-01 8:05 ` Krzysztof Kozlowski
2025-09-01 14:50 ` Nitin Rawat
2025-08-21 11:24 ` [PATCH V3 5/5] arm64: dts: qcom: sm8750: " Ram Kumar Dwivedi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=79555a86-d434-414f-bafc-be311a92482c@kernel.org \
--to=krzk@kernel.org \
--cc=James.Bottomley@HansenPartnership.com \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=konradybcio@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=mani@kernel.org \
--cc=martin.petersen@oracle.com \
--cc=quic_nitirawa@quicinc.com \
--cc=quic_rdwivedi@quicinc.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).