From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Yassine Oudjana <yassine.oudjana@gmail.com>
Cc: Sebastian Reichel <sre@kernel.org>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Andy Gross <agross@kernel.org>,
Bjorn Andersson <bjorn.andersson@linaro.org>,
Alejandro Tafalla <atafalla@dnyon.com>,
Konrad Dybcio <konrad.dybcio@somainline.org>,
linux-pm@vger.kernel.org, linux-arm-msm@vger.kernel.org,
devicetree@vger.kernel.org, phone-devel@vger.kernel.org,
linux-kernel@vger.kernel.org,
Yassine Oudjana <y.oudjana@protonmail.com>
Subject: Re: [PATCH 1/8] dt-bindings: power: supply: Add DT schema for Qualcomm SMBCHG
Date: Mon, 21 Nov 2022 09:26:59 +0100 [thread overview]
Message-ID: <795deac4-71fe-d40b-a3b6-855eb3875ad1@linaro.org> (raw)
In-Reply-To: <20221120154625.57095-1-y.oudjana@protonmail.com>
On 20/11/2022 16:46, Yassine Oudjana wrote:
>>> + interrupts:
>>> + items:
>>> + - description: Charger error
>>> + - description: Charger inhibited
>>> + - description: Charger precharge safety timer timeout
>>> + - description: Charger charge safety timer timeout
>>> + - description: Charger pre to fast charging switch threshold reached
>>> + - description: Charger recharge threshold reached
>>> + - description: Charger taper threshold reached
>>> + - description: Charger charge termination threshold reached
>>> + - description: Battery hot
>>> + - description: Battery warm
>>> + - description: Battery cold
>>> + - description: Battery cool
>>> + - description: Battery overvoltage
>>> + - description: Battery low
>>> + - description: Battery missing
>>> + - description: Battery thermistor missing # unconfirmed
>>> + - description: USB input undervolt
>>> + - description: USB input overvolt
>>> + - description: USB input source detected
>>> + - description: OTG regulator failure
>>> + - description: OTG regulator overcurrent
>>> + - description: Automatic input current limiting done
>>> + - description: USB ID pin changed
>>> + - description: DC input undervolt
>>> + - description: DC input overvolt
>>> + - description: Power OK
>>> + - description: Temperature shutdown
>>> + - description: Watchdog timeout
>>> + - description: Flash failure
>>> + - description: OTST2 # unknown
>>> + - description: OTST3 # unknown
>>
>> It seems you listed register interrupts, not physical pins. This should
>> be interrupt lines.
>
> I'm not sure what I'm supposed to do here. I couldn't find an interrupt-lines
> property used anywhere so that's not what you meant, right?
Are these physical interrupt lines this device has, register offsets or
virtual interrupts (e.g. passed via irq_chip)? Definitely not the first
and rather offsets for qpnpint_irq_domain_translate. Devicetree is not
for describing register layout of devices. IOW, register layout does not
change on different boards, because the device is exactly the same, so
there is no point to put it into DTS.
Best regards,
Krzysztof
next prev parent reply other threads:[~2022-11-21 8:27 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-08 7:34 [PATCH 0/8] power: supply: Add driver for Qualcomm SMBCHG Yassine Oudjana
2022-08-08 7:34 ` [PATCH 1/8] dt-bindings: power: supply: Add DT schema " Yassine Oudjana
2022-08-08 8:42 ` Krzysztof Kozlowski
2022-11-20 15:46 ` Yassine Oudjana
2022-11-21 8:26 ` Krzysztof Kozlowski [this message]
2022-11-21 10:36 ` Yassine Oudjana
2022-11-21 17:07 ` Krzysztof Kozlowski
2022-11-22 13:30 ` Dmitry Baryshkov
2022-11-28 11:39 ` Krzysztof Kozlowski
2022-11-28 11:52 ` Dmitry Baryshkov
2022-11-30 16:24 ` Krzysztof Kozlowski
2024-09-30 10:13 ` Yassine Oudjana
2022-08-08 7:34 ` [PATCH 2/8] arm64: dts: qcom: pmi8994: Add SMBCHG Yassine Oudjana
2022-08-08 7:34 ` [PATCH 3/8] arm64: dts: qcom: pmi8996: " Yassine Oudjana
2022-08-08 7:34 ` [PATCH 5/8] arm64: dts: qcom: msm8996-xiaomi-*: Enable SMBCHG Yassine Oudjana
2022-08-08 7:34 ` [PATCH 6/8] soc: qcom: Add PMIC secure register write helpers Yassine Oudjana
2022-08-08 7:34 ` [PATCH 7/8] util_macros.h: Add macro to find closest smaller value in array Yassine Oudjana
2022-08-08 7:34 ` [PATCH 8/8] power: supply: Add driver for Qualcomm SMBCHG Yassine Oudjana
2022-08-08 8:55 ` Krzysztof Kozlowski
2022-08-08 10:05 ` Yassine Oudjana
2022-08-08 13:42 ` Krzysztof Kozlowski
2022-08-08 8:41 ` [PATCH 0/8] " Krzysztof Kozlowski
2022-08-08 9:39 ` Yassine Oudjana
2022-08-08 13:24 ` Caleb Connolly
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=795deac4-71fe-d40b-a3b6-855eb3875ad1@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=agross@kernel.org \
--cc=atafalla@dnyon.com \
--cc=bjorn.andersson@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=konrad.dybcio@somainline.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=phone-devel@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=sre@kernel.org \
--cc=y.oudjana@protonmail.com \
--cc=yassine.oudjana@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).