From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6B357C4332F for ; Mon, 21 Nov 2022 08:27:06 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229946AbiKUI1E (ORCPT ); Mon, 21 Nov 2022 03:27:04 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54204 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229907AbiKUI1E (ORCPT ); Mon, 21 Nov 2022 03:27:04 -0500 Received: from mail-lj1-x234.google.com (mail-lj1-x234.google.com [IPv6:2a00:1450:4864:20::234]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 691F463D5 for ; Mon, 21 Nov 2022 00:27:02 -0800 (PST) Received: by mail-lj1-x234.google.com with SMTP id d20so13618373ljc.12 for ; Mon, 21 Nov 2022 00:27:02 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=wYa6qiy8lMPys5blH9J/G1eMKnRjWk2O1ZKygOJRkTQ=; b=Cj2/VIzR/21o/tDbTWZPg8AGCS4nhfSg7B+uN9/AR/5LGg0FRaKRyalpThYZxC53mJ pnbm+WJ9fCqM1NC8ka3B5R0z2fGv7B3oc/AMH+IuYEistzWxn6NkPDevW0qDkJLQuXyZ bYo8jbLfTX6skcVDVIqtgCNxIT6bzhM3f/7GortQZEwVdTwtRwQF/6vEMDST+ioPEA0v kxFNTuOyCF++tItPtJImlhbwQy9qjFTkL4RnpKEPpzwir3xS3iBMNqf4BFRCi3tSOt+T CjEGYpiI5z3UAwO7fSltILV2sIZ0weSNBtrk2EW++azDJJtPkoBgb0OV6y5E0LEU+c3k qCaA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=wYa6qiy8lMPys5blH9J/G1eMKnRjWk2O1ZKygOJRkTQ=; b=xiwQXZCKfde9xDWhDZxDXOEi2AxyO6IZxRsjxO88k3VSEIoaqn38egTb1UFIypOM2X vrIRbveAs5Xu19aC9kzZx5jEh/ctIcud82BzNHKf/o2VrPx2bf2nF4x3XBtVdG4QGJ5H 8QlpLI6gLDmdR1ksaBwM7sy4xHauNISiB3w4tRk6gc7CLCiYh46ZUvNP6Ydwc3ppbe13 R3jMXE4NjbuL8kn8qsl1kWs/XNl/2QpOqtoxeDiX/kQv67JUOqeDySD+/3IkNXf5YaL4 lQh2jaS0d+qwZcvQUUsNM0gKvtTZwOu5xjgTiGmO5hEG6ekRSpCZFxbL3+NwtXHbhDAT og0Q== X-Gm-Message-State: ANoB5pnk7+hSxm/+D0Bdona9WiM3dwMpUCJibkNCPyD9LqL5VQOol9L/ RAamUX8/9Qlrsm5UeUbmCZRTJfLEDG7P1EOp X-Google-Smtp-Source: AA0mqf5RPWYa6p3CjzIW6ePaZSL0+GAKbQbFHq0c225RFkodYWsPwYzdEjwB8RTo/+JQghTXRFRFow== X-Received: by 2002:a2e:b5ae:0:b0:277:3df:90d0 with SMTP id f14-20020a2eb5ae000000b0027703df90d0mr384156ljn.234.1669019220719; Mon, 21 Nov 2022 00:27:00 -0800 (PST) Received: from [192.168.0.20] (088156142067.dynamic-2-waw-k-3-2-0.vectranet.pl. [88.156.142.67]) by smtp.gmail.com with ESMTPSA id 9-20020a2eb949000000b0026dcf0cbb97sm1379191ljs.137.2022.11.21.00.26.59 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 21 Nov 2022 00:27:00 -0800 (PST) Message-ID: <795deac4-71fe-d40b-a3b6-855eb3875ad1@linaro.org> Date: Mon, 21 Nov 2022 09:26:59 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.2 Subject: Re: [PATCH 1/8] dt-bindings: power: supply: Add DT schema for Qualcomm SMBCHG Content-Language: en-US To: Yassine Oudjana Cc: Sebastian Reichel , Rob Herring , Krzysztof Kozlowski , Andy Gross , Bjorn Andersson , Alejandro Tafalla , Konrad Dybcio , linux-pm@vger.kernel.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, phone-devel@vger.kernel.org, linux-kernel@vger.kernel.org, Yassine Oudjana References: <20221120154625.57095-1-y.oudjana@protonmail.com> From: Krzysztof Kozlowski In-Reply-To: <20221120154625.57095-1-y.oudjana@protonmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 20/11/2022 16:46, Yassine Oudjana wrote: >>> + interrupts: >>> + items: >>> + - description: Charger error >>> + - description: Charger inhibited >>> + - description: Charger precharge safety timer timeout >>> + - description: Charger charge safety timer timeout >>> + - description: Charger pre to fast charging switch threshold reached >>> + - description: Charger recharge threshold reached >>> + - description: Charger taper threshold reached >>> + - description: Charger charge termination threshold reached >>> + - description: Battery hot >>> + - description: Battery warm >>> + - description: Battery cold >>> + - description: Battery cool >>> + - description: Battery overvoltage >>> + - description: Battery low >>> + - description: Battery missing >>> + - description: Battery thermistor missing # unconfirmed >>> + - description: USB input undervolt >>> + - description: USB input overvolt >>> + - description: USB input source detected >>> + - description: OTG regulator failure >>> + - description: OTG regulator overcurrent >>> + - description: Automatic input current limiting done >>> + - description: USB ID pin changed >>> + - description: DC input undervolt >>> + - description: DC input overvolt >>> + - description: Power OK >>> + - description: Temperature shutdown >>> + - description: Watchdog timeout >>> + - description: Flash failure >>> + - description: OTST2 # unknown >>> + - description: OTST3 # unknown >> >> It seems you listed register interrupts, not physical pins. This should >> be interrupt lines. > > I'm not sure what I'm supposed to do here. I couldn't find an interrupt-lines > property used anywhere so that's not what you meant, right? Are these physical interrupt lines this device has, register offsets or virtual interrupts (e.g. passed via irq_chip)? Definitely not the first and rather offsets for qpnpint_irq_domain_translate. Devicetree is not for describing register layout of devices. IOW, register layout does not change on different boards, because the device is exactly the same, so there is no point to put it into DTS. Best regards, Krzysztof