From: <Conor.Dooley@microchip.com>
To: <krzysztof.kozlowski@linaro.org>, <robh+dt@kernel.org>,
<krzysztof.kozlowski+dt@linaro.org>, <paul.walmsley@sifive.com>,
<palmer@dabbelt.com>, <aou@eecs.berkeley.edu>,
<Daire.McNamara@microchip.com>
Cc: <devicetree@vger.kernel.org>, <linux-riscv@lists.infradead.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v1 3/3] riscv: dts: microchip: add a devicetree for the Aldec TySoM
Date: Tue, 6 Sep 2022 13:19:02 +0000 [thread overview]
Message-ID: <796f7dd4-8a72-e621-1c3a-e242f8b54631@microchip.com> (raw)
In-Reply-To: <71dad0f0-db66-e79e-5e01-d5fc66b0cb3e@linaro.org>
On 06/09/2022 14:11, Krzysztof Kozlowski wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
>
> On 06/09/2022 14:15, Conor Dooley wrote:
>> The TySOM-M-MPFS250 is a compact SoC prototyping board featuring
>> a Microchip PolarFire SoC MPFS250T-FCG1152. Features include:
>> - 16 GB FPGA DDR4
>> - 16 GB MSS DDR4 with ECC
>> - eMMC
>> - SPI flash memory
>> - 2x Ethernet 10/100/1000
>> - USB 2.0
>> - PCIe x4 Gen2
>> - HDMI OUT
>> - 2x FMC connector (HPC and LPC)
>> +
>> +&spi1 {
>> + status = "okay";
>> + flash@0 {
>> + #address-cells = <1>;
>> + #size-cells = <1>;
>
> Are these needed? Does it pass dtbs_check?
It did, yea. But you're right in that they're not needed, I deleted some
dummy flash partitions that were in the dts I received and I didn't see
the cells too.
I'm likely going to sit on this patch for quite a while, but the various
things you pointed out all are valid, so they'll be sorted by the
eventual v2...
As always, thanks!
>
>> + compatible = "micron,n25q128a11", "jedec,spi-nor";
>> + status = "okay";
>
> No need for status.
prev parent reply other threads:[~2022-09-06 13:19 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-06 12:15 [PATCH v1 0/3] Add a devicetree for the Aldec PolarFire SoC TySoM Conor Dooley
2022-09-06 12:15 ` [PATCH v1 1/3] dt-bindings: vendor-prefixes: Add entry for Aldec Conor Dooley
2022-09-06 13:09 ` Krzysztof Kozlowski
2022-09-06 12:15 ` [PATCH v1 2/3] dt-bindings: riscv: microchip: document the Aldec TySoM Conor Dooley
2022-09-06 13:09 ` Krzysztof Kozlowski
2022-09-06 12:15 ` [PATCH v1 3/3] riscv: dts: microchip: add a devicetree for " Conor Dooley
2022-09-06 13:11 ` Krzysztof Kozlowski
2022-09-06 13:19 ` Conor.Dooley [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=796f7dd4-8a72-e621-1c3a-e242f8b54631@microchip.com \
--to=conor.dooley@microchip.com \
--cc=Daire.McNamara@microchip.com \
--cc=aou@eecs.berkeley.edu \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=palmer@dabbelt.com \
--cc=paul.walmsley@sifive.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox