From: "Stanley Chang[昌育德]" <stanley_chang@realtek.com>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Vinod Koul <vkoul@kernel.org>,
Kishon Vijay Abraham I <kishon@kernel.org>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
Alan Stern <stern@rowland.harvard.edu>,
Flavio Suligoi <f.suligoi@asem.it>,
Bagas Sanjaya <bagasdotme@gmail.com>,
Matthias Kaehlcke <mka@chromium.org>, Ray Chi <raychi@google.com>,
"linux-phy@lists.infradead.org" <linux-phy@lists.infradead.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>
Subject: RE: [PATCH v4 5/5] dt-bindings: phy: realtek: Add the doc about the Realtek SoC USB 3.0 PHY
Date: Tue, 20 Jun 2023 09:00:56 +0000 [thread overview]
Message-ID: <79731b2216f24df9b2db0bc8795b26bb@realtek.com> (raw)
In-Reply-To: <90f802db-79cc-010a-9a83-c7bdbf0d0c00@linaro.org>
Hi Krzysztof,
> > +properties:
> > + compatible:
> > + items:
> > + - enum:
> > + - realtek,rtd1295-usb3phy
> > + - realtek,rtd1319-usb3phy
> > + - realtek,rtd1319d-usb3phy
> > + - realtek,rtd1619-usb3phy
> > + - realtek,rtd1619b-usb3phy
> > + - const: realtek,usb3phy
>
> Drop last compatible, it is not used now. Does not make sense.
Okay. I will remove it.
> > +
> > + reg:
> > + description: PHY data registers
>
> Drop description, it's obvious.
Okay.
> > + maxItems: 1
> > +
> > + "#phy-cells":
> > + const: 0
> > +
> > + nvmem-cells:
> > + maxItems: 1
> > + description: A phandle to the tx lfps swing trim data provided by
> > + a nvmem device, if unspecified, default values shall be used.
> > +
> > + nvmem-cell-names:
> > + items:
> > + - const: usb_u3_tx_lfps_swing_trim
> > +
> > + realtek,amplitude-control-coarse-tuning:
> > + description:
> > + This adjusts the signal amplitude for normal operation and beacon
> LFPS.
> > + This value is a parameter for coarse tuning.
> > + For different boards, if the default value is inappropriate, this
> > + property can be assigned to adjust.
>
> default:
I will add it.
> > + $ref: /schemas/types.yaml#/definitions/uint32
> > + minimum: 0
> > + maximum: 255
> > +
> > + realtek,amplitude-control-fine-tuning:
> > + description:
> > + This adjusts the signal amplitude for normal operation and beacon
> LFPS.
> > + This value is used for fine-tuning parameters.
> > + $ref: /schemas/types.yaml#/definitions/uint32
>
> default:
I will add it.
> > + minimum: 0
> > + maximum: 65535
> > +
>
Thanks,
Stanley
prev parent reply other threads:[~2023-06-20 9:02 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-14 9:28 [PATCH v4 1/5] usb: phy: add usb phy notify port status API Stanley Chang
2023-06-14 9:28 ` [PATCH v4 2/5] phy: realtek: usb: Add driver for the Realtek SoC USB 2.0 PHY Stanley Chang
2023-06-14 15:10 ` kernel test robot
2023-06-17 8:34 ` Krzysztof Kozlowski
2023-06-20 8:58 ` Stanley Chang[昌育德]
2023-06-14 9:28 ` [PATCH v4 3/5] phy: realtek: usb: Add driver for the Realtek SoC USB 3.0 PHY Stanley Chang
2023-06-14 16:13 ` kernel test robot
2023-06-17 8:35 ` Krzysztof Kozlowski
2023-06-20 9:00 ` Stanley Chang[昌育德]
2023-06-14 9:28 ` [PATCH v4 4/5] dt-bindings: phy: realtek: Add the doc about the Realtek SoC USB 2.0 PHY Stanley Chang
2023-06-17 8:22 ` Krzysztof Kozlowski
2023-06-20 8:58 ` Stanley Chang[昌育德]
2023-06-14 9:28 ` [PATCH v4 5/5] dt-bindings: phy: realtek: Add the doc about the Realtek SoC USB 3.0 PHY Stanley Chang
2023-06-17 8:36 ` Krzysztof Kozlowski
2023-06-20 9:00 ` Stanley Chang[昌育德] [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=79731b2216f24df9b2db0bc8795b26bb@realtek.com \
--to=stanley_chang@realtek.com \
--cc=bagasdotme@gmail.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=f.suligoi@asem.it \
--cc=gregkh@linuxfoundation.org \
--cc=kishon@kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-phy@lists.infradead.org \
--cc=linux-usb@vger.kernel.org \
--cc=mka@chromium.org \
--cc=raychi@google.com \
--cc=robh+dt@kernel.org \
--cc=stern@rowland.harvard.edu \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).