From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Billy Tsai <billy_tsai@aspeedtech.com>,
jdelvare@suse.com, linux@roeck-us.net, robh+dt@kernel.org,
krzysztof.kozlowski+dt@linaro.org, joel@jms.id.au,
andrew@aj.id.au, thierry.reding@gmail.com,
u.kleine-koenig@pengutronix.de, corbet@lwn.net,
p.zabel@pengutronix.de, linux-hwmon@vger.kernel.org,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-aspeed@lists.ozlabs.org, linux-kernel@vger.kernel.org,
linux-pwm@vger.kernel.org, linux-doc@vger.kernel.org,
patrick@stwcx.xyz
Subject: Re: [v6 0/4] Support pwm/tach driver for aspeed ast26xx
Date: Thu, 8 Jun 2023 08:37:57 +0200 [thread overview]
Message-ID: <797c61d2-b8f1-e80e-24b9-4c7a7d266080@linaro.org> (raw)
In-Reply-To: <20230608021839.12769-1-billy_tsai@aspeedtech.com>
On 08/06/2023 04:18, Billy Tsai wrote:
> Unlike the old design that the register setting of the TACH should based
> on the configure of the PWM. In ast26xx, the dependency between pwm and
> tach controller is eliminated and becomes a separate hardware block. One
> is used to provide pwm output and another is used to monitor the frequency
> of the input. Therefore, this patch serials implements them by writing the
> two driver "pwm-aspeed-ast2600.c" and "tach-aspeed-ast2600.c". The former
> is following the pwm subsystem which can apply the existed driver to
> controller the fan(pwm-fan.c), beeper(pwm-beeper.c) and so on. The latter
> is following the sysfs interface of hwmon to creat the node for fan
> monitor.
You like to ignore my comments... How did you implement them? Go one by
one - answer to v4 emails.
Best regards,
Krzysztof
prev parent reply other threads:[~2023-06-08 6:38 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-08 2:18 [v6 0/4] Support pwm/tach driver for aspeed ast26xx Billy Tsai
2023-06-08 2:18 ` [v6 1/4] dt-bindings: pwm: Add ASPEED PWM Control documentation Billy Tsai
2023-06-08 6:39 ` Krzysztof Kozlowski
2023-06-08 6:46 ` Krzysztof Kozlowski
[not found] ` <SG2PR06MB3365DD80EA2FD026D400C4A78B50A@SG2PR06MB3365.apcprd06.prod.outlook.com>
2023-06-08 7:54 ` Krzysztof Kozlowski
[not found] ` <SG2PR06MB336528007D2685F8D95DF4078B50A@SG2PR06MB3365.apcprd06.prod.outlook.com>
2023-06-08 8:36 ` Krzysztof Kozlowski
[not found] ` <SG2PR06MB3365FCF5BEA6555EC503EFEC8B50A@SG2PR06MB3365.apcprd06.prod.outlook.com>
2023-06-08 9:26 ` Krzysztof Kozlowski
2023-06-08 8:39 ` Krzysztof Kozlowski
[not found] ` <SG2PR06MB3365558F9A3127744CEF1C068B50A@SG2PR06MB3365.apcprd06.prod.outlook.com>
2023-06-08 9:27 ` Krzysztof Kozlowski
2023-06-08 2:18 ` [v6 2/4] dt-bindings: hwmon: Add ASPEED TACH " Billy Tsai
2023-06-08 4:58 ` Guenter Roeck
[not found] ` <SG2PR06MB3365E360F3FCDE639F3D2D1E8B50A@SG2PR06MB3365.apcprd06.prod.outlook.com>
2023-06-08 13:18 ` Guenter Roeck
2023-06-08 6:40 ` Krzysztof Kozlowski
2023-06-08 2:18 ` [v6 3/4] pwm: Add Aspeed ast2600 PWM support Billy Tsai
2023-07-18 7:08 ` Thierry Reding
2023-06-08 2:18 ` [v6 4/4] hwmon: Add Aspeed ast2600 TACH support Billy Tsai
2023-06-08 5:01 ` Guenter Roeck
2023-06-08 6:37 ` Krzysztof Kozlowski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=797c61d2-b8f1-e80e-24b9-4c7a7d266080@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=andrew@aj.id.au \
--cc=billy_tsai@aspeedtech.com \
--cc=corbet@lwn.net \
--cc=devicetree@vger.kernel.org \
--cc=jdelvare@suse.com \
--cc=joel@jms.id.au \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-aspeed@lists.ozlabs.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pwm@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=p.zabel@pengutronix.de \
--cc=patrick@stwcx.xyz \
--cc=robh+dt@kernel.org \
--cc=thierry.reding@gmail.com \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).