From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ej2-f12.google.com (mail-ej2-f12.google.com [74.125.228.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 41A81229B38 for ; Mon, 21 Sep 2026 21:59:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.228.140 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790027973; cv=none; b=AjxKnLL3i9iLLY+Dlvrjg0j+N2gFAHan2asGpNDLhk0Ue6bmAK70M37y8JQjjafABelgoxdBUf0bdtwJ1rc6huIHf3Movji/QREJb1DtWVSR5cidNyF55M9fGYpNpLL+fZEvqibjbhljMA6Fit8fgXBdQ8gEu+A2g1OrZyyRISs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790027973; c=relaxed/simple; bh=TRdeNXfR3TBad0tHP8EChOJSQIYnhe9sNy3UDCObhoY=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=ZyIyba3mUl95knHPOQ9azkJnNyOOZnduv57w9FpdG2z6fVpkbau+ihpkqUCcGKWjJ9G9sJUOvaQ1go7RUPiUMv32jlJJi1tUAlcE9tX1HRuCYpX2G72aI3kv//sltrj8zzW/jzKsU79hJ+eUbndtVJH5hsoqnqRDJqYq9+ge5hE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=ayPDLsRo; arc=none smtp.client-ip=74.125.228.140 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="ayPDLsRo" Received: by mail-ej2-f12.google.com with SMTP id a640c23a62f3a-c254f55efe5so544090066b.2 for ; Mon, 21 Sep 2026 14:59:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1790027968; x=1790632768; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=TrkUPYLMl9LKtkW3M3SxTjU77noomALRO+sF6HlftGw=; b=ayPDLsRopvwm7v8XOJzvBPIXF+4TUimTRxlIGy0COADfk2h3ofKrm1qY3feLdOegZI 0v8W7JJ2pM/7eiAcsS30ofOLbW4DgLHMcWJzzKBrweER19LPPtx55Afy2hccItcxNKgB L0TlXqqz0X+NIIS9c/d097MvZjnjMU7LEg6enKPx0NYvERJu84AyGuPGZm5Vk6I2whRE t+bWJ+aKFb9elLwngJAKzaTiYTqaHA17WVyEaCWa03aJiBtX7H9Di9Umg8f20dO+JvJv lI4YhvsEh0qqcPNczgHwd6+IC64jd9KBVSN3SeEaxD4hg9dHDOy0H6P2ebLAWN5dBgk9 sdyw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1790027968; x=1790632768; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=TrkUPYLMl9LKtkW3M3SxTjU77noomALRO+sF6HlftGw=; b=ZPAvx7QBFojFkzZpYj/a8TvCcaWIDatLrUoU/mWtAON7FPhcyyMQTHg+w+xYKj9Z5w G7rzFBRA1YJQ5gWBz3WX28tsjsBM90nqAMn+YR+rjmgbmaOjof15fdOgLgN+CfWv4XpQ Sf6tt/Pfj3xHYD9qRo2TxxwyjP4FoDunf9Y92uqlSjweuU7LcYK+gDfNnxttVEiL+Z1y mGyhHdiDO3PKP8kWqErmp19S2CffPWIAOX7wFylvBHTKNHNc2YLCzRVFCk2I+AF7ub1e zhr1w6iVtK+F6Rb0zknDLA5Q5sRtmdgcNZ86yk8xsNVgAVPpychWIdvasTjafI8dwc36 hjOA== X-Forwarded-Encrypted: i=1; AKwUvBw9RE/dK8I/gZRionkqfUFMqTDoBcgTSsrcxMC+SgVTPQPxAxUR07fCvaG4GsjCBzNxH7WSaS2vCkzi@vger.kernel.org X-Gm-Message-State: AFuF++kbCF8KKVNq8KaLLG+iY9ZIbY8MSPCFarXcWa+NoRrijhh+sqmk LfSWJMbK6I+W9D/541bdgNAGMjQB0/ZkRz1TDOMTAugN+GYynPX6Ka2i X-Gm-Gg: AYBFou0xwLNmw9sm/70zT5O9grIiTFn3tvJ/gRCLlk2zl/r20fqZljKLZ+qtx1FlcJU 2AbujeyyCtAvgMLCKBRXQK/B4SLShnt5xA9BgedOONNLdEv0MVZZhTIwked1TJ3ukg92YRUlij3 gN5GP2/JJ2bWDenQ8CZ4i82BmTqYJiy/vu+3My87HnzFGN8aN7XiOSjOqqebDoamyQ74mD0AOA6 0JglMLUP4MsBSqtGQJfJnRJgAkAHpfMh7JMtsG48zuVPzfWmlCsCR6zlNRuUK8uFaKJgSXLsKs7 C80+C05950tkAZJONPdNY4zN2JDdkksGRwe5i60dVyz4akXvbkRLaq+zwONvPrk7ARfW4RTOweS 5n3gDu0HGONCRJ+is5ihonExL7woTUq4Y4LAtneclMi4vtEjUw9Qw7yZk0bdN+j+HymTxTGbOwU 0OmOUXkqMsnu4Jze2AnkYaUYhtazuHBXqlZ7RTYQy1NfBNuCa+evWGJekleEhVUAsLAuGgi6sBQ t9Msckq6D7v21k/IPIvVCDseg== X-Received: by 2002:a17:906:99c9:b0:c29:61b9:7b3b with SMTP id a640c23a62f3a-c2a15829440mr1024592366b.49.1790027968392; Mon, 21 Sep 2026 14:59:28 -0700 (PDT) Received: from [192.168.33.7] ([89.151.31.85]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-c2a962c814fsm9185866b.34.2026.09.21.14.59.26 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 21 Sep 2026 14:59:27 -0700 (PDT) Message-ID: <7980fee5-f70a-426d-8cdc-d51e15323852@gmail.com> Date: Mon, 21 Sep 2026 23:59:25 +0200 Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCHv2 1/2] usb: bcma: add regulator support To: Rosen Penev , devicetree@vger.kernel.org Cc: Florian Fainelli , Hauke Mehrtens , Broadcom internal kernel review list , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Greg Kroah-Hartman , "moderated list:BROADCOM BCM5301X ARM ARCHITECTURE" , open list , "open list:USB SUBSYSTEM" References: <20260921214133.16519-1-rosenp@gmail.com> <20260921214133.16519-2-rosenp@gmail.com> Content-Language: en-US From: =?UTF-8?B?UmFmYcWCIE1pxYJlY2tp?= In-Reply-To: <20260921214133.16519-2-rosenp@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit W dniu 21.09.2026 o 23:41, Rosen Penev pisze: > @@ -411,6 +422,14 @@ static int bcma_hcd_probe(struct bcma_device *core) > return dev_err_probe(&core->dev, PTR_ERR(usb_dev->gpio_desc), > "error obtaining VCC GPIO"); > > + usb_dev->regulator = devm_regulator_get(dev, "vbus"); > + if (IS_ERR(usb_dev->regulator)) > + return dev_err_probe(dev, PTR_ERR(usb_dev->regulator), "error obtaining VBUS regulator"); Did you test this for DT without VBUS? You seem to *require* regulator. Shouldn't you make it optional? > + err = regulator_enable(usb_dev->regulator); > + if (err) > + return dev_err_probe(dev, err, "error enabling VCC regulator"); > + Can't you use one of devm helpers that get and enable regulator for you?