From: Heiko Stuebner <heiko@sntech.de>
To: Chukun Pan <amadeus@jmu.edu.cn>, FUKAUMI Naoki <naoki@radxa.com>
Cc: conor+dt@kernel.org, devicetree@vger.kernel.org,
krzk+dt@kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-rockchip@lists.infradead.org
Subject: Re: [PATCH v2 2/3] arm64: dts: rockchip: remove vcc_3v3_pmu regulator for Radxa E52C
Date: Sun, 24 Aug 2025 08:41:28 +0200 [thread overview]
Message-ID: <7988840.GXAFRqVoOG@phil> (raw)
In-Reply-To: <0318E801E3D6726D+65c4f189-4e22-4a9b-83d7-cbb0816df373@radxa.com>
Am Mittwoch, 20. August 2025, 04:10:24 Mitteleuropäische Sommerzeit schrieb FUKAUMI Naoki:
> Hi Chukun,
>
> On 8/19/25 22:40, Chukun Pan wrote:
> > Hi,
> >
> >> How about the following instead?
> >>
> >> @@ -538,7 +538,7 @@ regulator-state-mem {
> >> };
> >> };
> >>
> >> - vcc_3v3_s3: dcdc-reg8 {
> >> + vcc_3v3_pmu: vcc_3v3_s3: dcdc-reg8 {
> >> regulator-name = "vcc_3v3_s3";
> >> regulator-always-on;
> >> regulator-boot-on;
> >
> > On rk356x, the Flash chip is usually powered by VCCIO_FLASH, which
> > is also connected through a 0 ohm resistor, so I didn't write like
> > this. e.g. https://github.com/torvalds/linux/commit/a706a593cb19
>
> I think it should match the schematic, i.e. it should be "vcc-supply =
> <&vccio_flash>;".
I very much agree :-) .
Having at least the phandle match the schematics nameing is very helpful
when someone tries to look something up between those two.
Heiko
next prev parent reply other threads:[~2025-08-24 6:41 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-16 8:00 [PATCH v2 0/3] arm64: dts: rockchip: update Radxa E52C support Chukun Pan
2025-08-16 8:00 ` [PATCH v2 1/3] arm64: dts: rockchip: disable display subsystem for Radxa E52C Chukun Pan
2025-08-16 8:00 ` [PATCH v2 2/3] arm64: dts: rockchip: remove vcc_3v3_pmu regulator " Chukun Pan
2025-08-18 6:57 ` FUKAUMI Naoki
2025-08-19 13:40 ` Chukun Pan
2025-08-20 2:10 ` FUKAUMI Naoki
2025-08-24 6:41 ` Heiko Stuebner [this message]
2025-08-16 8:00 ` [PATCH v2 3/3] arm64: dts: rockchip: update pinctrl names " Chukun Pan
2025-08-18 7:26 ` FUKAUMI Naoki
2025-08-19 15:00 ` Chukun Pan
2025-08-20 2:16 ` FUKAUMI Naoki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7988840.GXAFRqVoOG@phil \
--to=heiko@sntech.de \
--cc=amadeus@jmu.edu.cn \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=naoki@radxa.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).