Re: [PATCH] usb: gadget: renesas_usb3: add support for Renesas USB3.0 peripheral controller

Felipe Balbi
2015-12-16T15:49:34Z

[-- Attachment #1: Type: text/plain, Size: 441 bytes --]

Hi,

Arnd Bergmann <arnd@arndb.de> writes:
>> +struct renesas_usb3;
>> +struct renesas_usb3_request {
>> + struct usb_request req;
>> + struct list_head queue;
>> +};
>
> There is already a list_head in struct usb_request. Could you use that?
> (I don't know, just asking because this looks odd)

no, no. Don't do that. The list_head in usb_request is for use by the
gadget drivers and the gadget drivers only.

--
balbi

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 818 bytes --]