devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] arm64: dts: qcom: qrb4210-rb2: Correct PMI632 VBUS voltage
@ 2024-07-01 10:09 Dang Huynh
  2024-07-01 10:13 ` Luca Weiss
  0 siblings, 1 reply; 3+ messages in thread
From: Dang Huynh @ 2024-07-01 10:09 UTC (permalink / raw)
  To: Bjorn Andersson, Konrad Dybcio, Rob Herring, Krzysztof Kozlowski,
	Conor Dooley
  Cc: Dmitry Baryshkov, Luca Weiss, linux-arm-msm, devicetree,
	linux-kernel, Dang Huynh

According to downstream sources, PMI632 maximum VBUS voltage is
1 volt.

Taken from msm-4.19 (631561973a034e46ccacd0e53ef65d13a40d87a4)
Line 685-687 in drivers/power/supply/qcom/qpnp-smb5.c

Signed-off-by: Dang Huynh <danct12@riseup.net>
---
In previous patch series, there's a suggestion to correct
PMI632's VBUS voltage.

Unfortunately it didn't make it and probably forgotten.
---
 arch/arm64/boot/dts/qcom/qrb4210-rb2.dts | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm64/boot/dts/qcom/qrb4210-rb2.dts b/arch/arm64/boot/dts/qcom/qrb4210-rb2.dts
index 1c7de7f2db79..1888d99d398b 100644
--- a/arch/arm64/boot/dts/qcom/qrb4210-rb2.dts
+++ b/arch/arm64/boot/dts/qcom/qrb4210-rb2.dts
@@ -305,7 +305,7 @@ pmi632_ss_in: endpoint {
 
 &pmi632_vbus {
 	regulator-min-microamp = <500000>;
-	regulator-max-microamp = <3000000>;
+	regulator-max-microamp = <1000000>;
 	status = "okay";
 };
 

---
base-commit: 642a16ca7994a50d7de85715996a8ce171a5bdfb
change-id: 20240701-qrd4210rb2-vbus-volt-822764c7cfca

Best regards,
-- 
Dang Huynh <danct12@riseup.net>


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] arm64: dts: qcom: qrb4210-rb2: Correct PMI632 VBUS voltage
  2024-07-01 10:09 [PATCH] arm64: dts: qcom: qrb4210-rb2: Correct PMI632 VBUS voltage Dang Huynh
@ 2024-07-01 10:13 ` Luca Weiss
  2024-07-01 10:26   ` Dang Huynh
  0 siblings, 1 reply; 3+ messages in thread
From: Luca Weiss @ 2024-07-01 10:13 UTC (permalink / raw)
  To: Dang Huynh, Bjorn Andersson, Konrad Dybcio, Rob Herring,
	Krzysztof Kozlowski, Conor Dooley
  Cc: Dmitry Baryshkov, linux-arm-msm, devicetree, linux-kernel

On Mon Jul 1, 2024 at 12:09 PM CEST, Dang Huynh wrote:
> According to downstream sources, PMI632 maximum VBUS voltage is
> 1 volt.

Everywhere (also subject): s/volt/ampere/

Voltage for USB is 5V

Regards
Luca

>
> Taken from msm-4.19 (631561973a034e46ccacd0e53ef65d13a40d87a4)
> Line 685-687 in drivers/power/supply/qcom/qpnp-smb5.c
>
> Signed-off-by: Dang Huynh <danct12@riseup.net>
> ---
> In previous patch series, there's a suggestion to correct
> PMI632's VBUS voltage.
>
> Unfortunately it didn't make it and probably forgotten.
> ---
>  arch/arm64/boot/dts/qcom/qrb4210-rb2.dts | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm64/boot/dts/qcom/qrb4210-rb2.dts b/arch/arm64/boot/dts/qcom/qrb4210-rb2.dts
> index 1c7de7f2db79..1888d99d398b 100644
> --- a/arch/arm64/boot/dts/qcom/qrb4210-rb2.dts
> +++ b/arch/arm64/boot/dts/qcom/qrb4210-rb2.dts
> @@ -305,7 +305,7 @@ pmi632_ss_in: endpoint {
>  
>  &pmi632_vbus {
>  	regulator-min-microamp = <500000>;
> -	regulator-max-microamp = <3000000>;
> +	regulator-max-microamp = <1000000>;
>  	status = "okay";
>  };
>  
>
> ---
> base-commit: 642a16ca7994a50d7de85715996a8ce171a5bdfb
> change-id: 20240701-qrd4210rb2-vbus-volt-822764c7cfca
>
> Best regards,


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] arm64: dts: qcom: qrb4210-rb2: Correct PMI632 VBUS voltage
  2024-07-01 10:13 ` Luca Weiss
@ 2024-07-01 10:26   ` Dang Huynh
  0 siblings, 0 replies; 3+ messages in thread
From: Dang Huynh @ 2024-07-01 10:26 UTC (permalink / raw)
  To: Bjorn Andersson, Konrad Dybcio, Rob Herring, Krzysztof Kozlowski,
	Conor Dooley, Luca Weiss
  Cc: Dmitry Baryshkov, linux-arm-msm, devicetree, linux-kernel

A big mistake. Sorry about that.

On Monday, July 1, 2024 5:13:28 PM GMT+7 Luca Weiss wrote:
> On Mon Jul 1, 2024 at 12:09 PM CEST, Dang Huynh wrote:
> > According to downstream sources, PMI632 maximum VBUS voltage is
> > 1 volt.
> 
> Everywhere (also subject): s/volt/ampere/
> 
> Voltage for USB is 5V
> 
> Regards
> Luca
>



^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2024-07-01 10:26 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-07-01 10:09 [PATCH] arm64: dts: qcom: qrb4210-rb2: Correct PMI632 VBUS voltage Dang Huynh
2024-07-01 10:13 ` Luca Weiss
2024-07-01 10:26   ` Dang Huynh

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).