From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 030DAC433EF for ; Sun, 3 Apr 2022 07:56:31 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1344938AbiDCH6W (ORCPT ); Sun, 3 Apr 2022 03:58:22 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49728 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234469AbiDCH6V (ORCPT ); Sun, 3 Apr 2022 03:58:21 -0400 Received: from mail-ed1-x52c.google.com (mail-ed1-x52c.google.com [IPv6:2a00:1450:4864:20::52c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 25F7C377FD for ; Sun, 3 Apr 2022 00:56:28 -0700 (PDT) Received: by mail-ed1-x52c.google.com with SMTP id b15so7589030edn.4 for ; Sun, 03 Apr 2022 00:56:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=i3fCaM44ai9Ho5+ESZukVkEPFkgIufFRH+KUn22jE48=; b=hGVybtUrDow3w4+aXDW5Inw9yqWEf6RZfy+hUPBhIJrK1JG/Q36mg+PSv7xCQZQdeg wx8VZmkvxwDay5fZA+lzSMxF4vQ/XaWCG/gkPbhwgBipIp/DzdXIN6zgOyp0k7kyrxi/ a5x2Mrm2SsszctCbUzoCja9+r1SlHgJTi5ILQ2ZzjZjs0rio79m9dTEbeWbXBX5ZjtO6 XbQNDac1U/rT3Oz+K9+gNJVq7yGmf8YCAUZ41TlQ/wueDBVbi+W+uGvCQXwdzHHlU+zP EQbhb3Vz4kpGO1yapURSIJjViUOYLV1EbDgFftGDlkEVjuVekxs+K+WmBBrFolgugui3 pWVQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=i3fCaM44ai9Ho5+ESZukVkEPFkgIufFRH+KUn22jE48=; b=bxXvz0nS/JC54FGOQVY+ws/opP8eUswDZVImRYKtmIR/O23G803cbdGEbD+hCbF2KX HpI9UoKC7ql/PIYdqg9sek84oL9qKbOBsJW6tspxzMHZ0s402huBnuYLbphtajjEUX51 uNwIKwyUilgjmSqrace4rFxZ2RaAQh1WJGqcU7DgP8Lx7R3ZQoQ939T2AyquxCIcpmLV dpfM29EDu91TQG2WlpLTp20lTAMN+FLa1qIPXtLh7p6aD2wSCE790qEIqwujDKbt6QoE S42Ke8p9PMOq9AUlvJNYCYv++BGAVzjswEB2iinPqWPD0DfP2vXxDQXb0FxXVGIY1rTz npzQ== X-Gm-Message-State: AOAM533YxGheJ6g2t6yARR/+aSaNwzeiJUMjH9VXd54si1mI/7cT/yPo iR3nipfdeerNgRQ4VMkTYj80JA== X-Google-Smtp-Source: ABdhPJzdy2udwHmdRbAFbbuf2ZcLAXsrnUeRk+iiT/GIIQUynNBEVmYR7RI8WMzEv22v4hzj0TxChg== X-Received: by 2002:a50:fd94:0:b0:419:9ed:e870 with SMTP id o20-20020a50fd94000000b0041909ede870mr28389360edt.207.1648972586742; Sun, 03 Apr 2022 00:56:26 -0700 (PDT) Received: from [192.168.0.171] (xdsl-188-155-201-27.adslplus.ch. [188.155.201.27]) by smtp.gmail.com with ESMTPSA id ec10-20020a0564020d4a00b0041a68df1a71sm3432229edb.77.2022.04.03.00.56.25 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 03 Apr 2022 00:56:26 -0700 (PDT) Message-ID: <798f0244-95dd-cf2d-7bc5-02c72c7fa327@linaro.org> Date: Sun, 3 Apr 2022 09:56:25 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.7.0 Subject: Re: [PATCH 6/6] dt-bindings: power: supply: qcom,smb2: add bindings for smb2 driver Content-Language: en-US To: Kuldeep Singh , Caleb Connolly Cc: Sebastian Reichel , Rob Herring , Krzysztof Kozlowski , Andy Gross , Bjorn Andersson , linux-pm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, Amit Pundir , Sumit Semwal References: <20220401202643.877609-1-caleb.connolly@linaro.org> <20220401202643.877609-7-caleb.connolly@linaro.org> <20220403071426.GA49153@9a2d8922b8f1> From: Krzysztof Kozlowski In-Reply-To: <20220403071426.GA49153@9a2d8922b8f1> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 03/04/2022 09:14, Kuldeep Singh wrote: > On Fri, Apr 01, 2022 at 09:26:43PM +0100, Caleb Connolly wrote: >> Add devicetree bindings for the Qualcomm PMI8998/PM660 SMB2 charger >> drivers. >> (...) > >> + pmic { >> + #address-cells = <1>; >> + #size-cells = <0>; >> + #interrupt-cells = <4>; >> + >> + smb2@1000 { >> + compatible = "qcom,pmi8998-smb2"; >> + reg = <0x1000>; >> + >> + interrupts = <0x2 0x13 0x4 IRQ_TYPE_EDGE_BOTH>; >> + interrupt-names = "usb-plugin"; >> + > > In-between new lines may not be required. > And DTs use tabs instead of 2 spaces, we can follow that here also. The DT examples in bindings use spaces. Either two (like YAML) or four (for easier reading). > >> + io-channels = <&pmi8998_rradc 3>, >> + <&pmi8998_rradc 4>; >> + io-channel-names = "usbin_i", >> + "usbin_v"; > > Channel-names can be written in one line. They match the format of io-channels, so this is quite readable. Best regards, Krzysztof