From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dan Murphy Subject: Re: [PATCH] leds: as3645a: Fix checkpatch warnings Date: Wed, 13 Dec 2017 14:49:38 -0600 Message-ID: <799ae164-701a-87ce-fadf-8278f01c10d6@ti.com> References: <20171212215011.30066-1-dmurphy@ti.com> <98df06ef-9ee4-02b1-6d6b-f10b911a8d71@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <98df06ef-9ee4-02b1-6d6b-f10b911a8d71@gmail.com> Content-Language: en-US Sender: linux-kernel-owner@vger.kernel.org To: Jacek Anaszewski , robh+dt@kernel.org, mark.rutland@arm.com, rpurdie@rpsys.net, pavel@ucw.cz, sakari.ailus@iki.fi, laurent.pinchart@ideasonboard.com Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-leds@vger.kernel.org List-Id: devicetree@vger.kernel.org Pavel and Laurent On 12/13/2017 02:43 PM, Jacek Anaszewski wrote: > Dan, > > On 12/13/2017 09:41 PM, Dan Murphy wrote: >> Jacek >> >> On 12/13/2017 02:29 PM, Jacek Anaszewski wrote: >>> Hi Dan, >>> >>> checkpatch.pl doesn't want to be mentioned in the patch subject :-) >>> >> >> Ack >> >>> "WARNING: A patch subject line should describe the change not the tool >>> that found it" >>> >>> Preferably I'd see two separate patches. >>> >> >> So you want me to split them up? I have no issue with that. > > Yeah, it will be easier to come up with concise but meaningful > subjects. > When I split these up can I add your Acked-by to each patch or would you prefer to resend your Acked-by for each patch? Dan >>> Also, line length limit for the commit description is 75 characters. >>> Please use whole available space. >>> >> >> > -- ------------------ Dan Murphy