From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 883C32222BA; Tue, 16 Sep 2025 11:36:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=213.167.242.64 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1758022601; cv=none; b=lZepG5+/RZpZKPUi8SmpZ6qnbfsRGMLNKBno76IdA2Z3t2lkHhtD5Y4qb9f1Hj2uVYsvdlfHs8b58hajR6290nAQXIwI92j+75c4ojrts6JlQbL4O4A6LQt/U1WUN0SrPVfXBhUz+mMeDUivvvh0OnIOgECOpJX5EgYjx8CUU4I= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1758022601; c=relaxed/simple; bh=QBf4lDkQAgPGcB0ozjQcxZ4fSOEoRzbOC2hLFFUgKIM=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=frOaPuauagBnHNxXAIWyW9iY2Sw67Drb/JVtTHL7n+VNOIGkFiqzk96VwbapaLNvH7v8vI/dxqY08q4OXcdqZysSp6lB3E7loDEB7O/iryOJPpeFDuRyzdxkHvxqamTs9LYe6/MRQ3PY2L6z5DdFPKCHRCoi1eC6xfRVj6mUzrE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=ideasonboard.com; spf=pass smtp.mailfrom=ideasonboard.com; dkim=pass (1024-bit key) header.d=ideasonboard.com header.i=@ideasonboard.com header.b=MPJrI5P1; arc=none smtp.client-ip=213.167.242.64 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=ideasonboard.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ideasonboard.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="MPJrI5P1" Received: from [192.168.88.20] (91-158-153-178.elisa-laajakaista.fi [91.158.153.178]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 6AB536DF; Tue, 16 Sep 2025 13:35:18 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1758022519; bh=QBf4lDkQAgPGcB0ozjQcxZ4fSOEoRzbOC2hLFFUgKIM=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=MPJrI5P1h3d80i1pfqStVZ2nmdLsDrVRIZjnkM688cbf5NjhNt/WsstV1xvZXBPnH WZB8Ov+KZ0cndsrOFbRZUIml18MdvOSYsho6j51WOqwBDsGwFgKfeqm9udNvm8MxEI EYnoZZxKQF60+WSXSSsfXk9DdlS/PmxRKDHKMTX4= Message-ID: <79a81d96-eaed-4a63-8cd5-c25a3b0adefc@ideasonboard.com> Date: Tue, 16 Sep 2025 14:36:33 +0300 Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH V5 0/5] drm/bridge: it66121: Add initial it66122 support To: Nishanth Menon , Conor Dooley , Krzysztof Kozlowski , Rob Herring , David Airlie , Maxime Ripard , Laurent Pinchart , Neil Armstrong Cc: linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, dri-devel@lists.freedesktop.org, Robert Nelson , Jason Kridner , afd@ti.com, devarsht@ti.com, dmitry.baryshkov@oss.qualcomm.com References: <20250827202354.2017972-1-nm@ti.com> Content-Language: en-US From: Tomi Valkeinen Autocrypt: addr=tomi.valkeinen@ideasonboard.com; keydata= xsFNBE6ms0cBEACyizowecZqXfMZtnBniOieTuFdErHAUyxVgtmr0f5ZfIi9Z4l+uUN4Zdw2 wCEZjx3o0Z34diXBaMRJ3rAk9yB90UJAnLtb8A97Oq64DskLF81GCYB2P1i0qrG7UjpASgCA Ru0lVvxsWyIwSfoYoLrazbT1wkWRs8YBkkXQFfL7Mn3ZMoGPcpfwYH9O7bV1NslbmyJzRCMO eYV258gjCcwYlrkyIratlHCek4GrwV8Z9NQcjD5iLzrONjfafrWPwj6yn2RlL0mQEwt1lOvn LnI7QRtB3zxA3yB+FLsT1hx0va6xCHpX3QO2gBsyHCyVafFMrg3c/7IIWkDLngJxFgz6DLiA G4ld1QK/jsYqfP2GIMH1mFdjY+iagG4DqOsjip479HCWAptpNxSOCL6z3qxCU8MCz8iNOtZk DYXQWVscM5qgYSn+fmMM2qN+eoWlnCGVURZZLDjg387S2E1jT/dNTOsM/IqQj+ZROUZuRcF7 0RTtuU5q1HnbRNwy+23xeoSGuwmLQ2UsUk7Q5CnrjYfiPo3wHze8avK95JBoSd+WIRmV3uoO rXCoYOIRlDhg9XJTrbnQ3Ot5zOa0Y9c4IpyAlut6mDtxtKXr4+8OzjSVFww7tIwadTK3wDQv Bus4jxHjS6dz1g2ypT65qnHen6mUUH63lhzewqO9peAHJ0SLrQARAQABzTBUb21pIFZhbGtl aW5lbiA8dG9taS52YWxrZWluZW5AaWRlYXNvbmJvYXJkLmNvbT7CwY4EEwEIADgWIQTEOAw+ ll79gQef86f6PaqMvJYe9QUCX/HruAIbAwULCQgHAgYVCgkICwIEFgIDAQIeAQIXgAAKCRD6 PaqMvJYe9WmFD/99NGoD5lBJhlFDHMZvO+Op8vCwnIRZdTsyrtGl72rVh9xRfcSgYPZUvBuT VDxE53mY9HaZyu1eGMccYRBaTLJSfCXl/g317CrMNdY0k40b9YeIX10feiRYEWoDIPQ3tMmA 0nHDygzcnuPiPT68JYZ6tUOvAt7r6OX/litM+m2/E9mtp8xCoWOo/kYO4mOAIoMNvLB8vufi uBB4e/AvAjtny4ScuNV5c5q8MkfNIiOyag9QCiQ/JfoAqzXRjVb4VZG72AKaElwipiKCWEcU R4+Bu5Qbaxj7Cd36M/bI54OrbWWETJkVVSV1i0tghCd6HHyquTdFl7wYcz6cL1hn/6byVnD+ sR3BLvSBHYp8WSwv0TCuf6tLiNgHAO1hWiQ1pOoXyMEsxZlgPXT+wb4dbNVunckwqFjGxRbl Rz7apFT/ZRwbazEzEzNyrBOfB55xdipG/2+SmFn0oMFqFOBEszXLQVslh64lI0CMJm2OYYe3 PxHqYaztyeXsx13Bfnq9+bUynAQ4uW1P5DJ3OIRZWKmbQd/Me3Fq6TU57LsvwRgE0Le9PFQs dcP2071rMTpqTUteEgODJS4VDf4lXJfY91u32BJkiqM7/62Cqatcz5UWWHq5xeF03MIUTqdE qHWk3RJEoWHWQRzQfcx6Fn2fDAUKhAddvoopfcjAHfpAWJ+ENc7BTQROprNHARAAx0aat8GU hsusCLc4MIxOQwidecCTRc9Dz/7U2goUwhw2O5j9TPqLtp57VITmHILnvZf6q3QAho2QMQyE DDvHubrdtEoqaaSKxKkFie1uhWNNvXPhwkKLYieyL9m2JdU+b88HaDnpzdyTTR4uH7wk0bBa KbTSgIFDDe5lXInypewPO30TmYNkFSexnnM3n1PBCqiJXsJahE4ZQ+WnV5FbPUj8T2zXS2xk 0LZ0+DwKmZ0ZDovvdEWRWrz3UzJ8DLHb7blPpGhmqj3ANXQXC7mb9qJ6J/VSl61GbxIO2Dwb xPNkHk8fwnxlUBCOyBti/uD2uSTgKHNdabhVm2dgFNVuS1y3bBHbI/qjC3J7rWE0WiaHWEqy UVPk8rsph4rqITsj2RiY70vEW0SKePrChvET7D8P1UPqmveBNNtSS7In+DdZ5kUqLV7rJnM9 /4cwy+uZUt8cuCZlcA5u8IsBCNJudxEqBG10GHg1B6h1RZIz9Q9XfiBdaqa5+CjyFs8ua01c 9HmyfkuhXG2OLjfQuK+Ygd56mV3lq0aFdwbaX16DG22c6flkkBSjyWXYepFtHz9KsBS0DaZb 4IkLmZwEXpZcIOQjQ71fqlpiXkXSIaQ6YMEs8WjBbpP81h7QxWIfWtp+VnwNGc6nq5IQDESH mvQcsFS7d3eGVI6eyjCFdcAO8eMAEQEAAcLBXwQYAQIACQUCTqazRwIbDAAKCRD6PaqMvJYe 9fA7EACS6exUedsBKmt4pT7nqXBcRsqm6YzT6DeCM8PWMTeaVGHiR4TnNFiT3otD5UpYQI7S suYxoTdHrrrBzdlKe5rUWpzoZkVK6p0s9OIvGzLT0lrb0HC9iNDWT3JgpYDnk4Z2mFi6tTbq xKMtpVFRA6FjviGDRsfkfoURZI51nf2RSAk/A8BEDDZ7lgJHskYoklSpwyrXhkp9FHGMaYII m9EKuUTX9JPDG2FTthCBrdsgWYPdJQvM+zscq09vFMQ9Fykbx5N8z/oFEUy3ACyPqW2oyfvU CH5WDpWBG0s5BALp1gBJPytIAd/pY/5ZdNoi0Cx3+Z7jaBFEyYJdWy1hGddpkgnMjyOfLI7B CFrdecTZbR5upjNSDvQ7RG85SnpYJTIin+SAUazAeA2nS6gTZzumgtdw8XmVXZwdBfF+ICof 92UkbYcYNbzWO/GHgsNT1WnM4sa9lwCSWH8Fw1o/3bX1VVPEsnESOfxkNdu+gAF5S6+I6n3a ueeIlwJl5CpT5l8RpoZXEOVtXYn8zzOJ7oGZYINRV9Pf8qKGLf3Dft7zKBP832I3PQjeok7F yjt+9S+KgSFSHP3Pa4E7lsSdWhSlHYNdG/czhoUkSCN09C0rEK93wxACx3vtxPLjXu6RptBw 3dRq7n+mQChEB1am0BueV1JZaBboIL0AGlSJkm23kw== In-Reply-To: <20250827202354.2017972-1-nm@ti.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Hi, On 27/08/2025 23:23, Nishanth Menon wrote: > Hi, > > Add initial support for IT66122, which seems to be compatible to it66121 > but probably has additional functionality. > > BeagleY-AI uses this it66122 as the old part is no longer in production > as far as I understand. > > Now, BeaglePlay uses it66121 at the moment, but at some point, it might > end up flipping over to the new part. Additionally, it also looks like > Revision D of BeagleBone Black switched over to it66122 as well. > > Series is based on next-20250827 > > Bootlog: BeaglePlay: https://gist.github.com/nmenon/65afb917ee1818979d338cf25732a920 > > Changes in V5: > * Switched over to ARRAY_SIZE > * Picked up Andrew's Reviewed-by > > Changes in V4: > * Added patch to sort the compatibles alpha-numerically > * vid/pid lookup is done without using the match_data. > * picked reviews > > Changes in V3: > Based on Tomi's and Devarsh's reviews, and searching online (and failing > to find) for a public data sheet, I have refactored the series to: > a) Detect the ID by matching vid/pid > b) Introduce it66122 basic support which seems to work based on > empirical testing evidence on BeagleY-AI. This allows incremental > patches in the future by someone who might have access to the data > sheet to add additional features for the chip. > c) Irritated by checkpatch --strict warnings, added a patch to fix > existing warnings as part of this series, but it could probably go > in independent of everything else. > d) Stopped claiming it66122 is drop in replacement of it66121 :) > > Changes in V2: > * Picked up Krystoff's binding ack > * Switched over to a vid/pid list > > V4: https://lore.kernel.org/all/20250819130807.3322536-1-nm@ti.com/ > V3: https://lore.kernel.org/all/20250815034105.1276548-1-nm@ti.com/ > V2: https://lore.kernel.org/all/20250813204106.580141-1-nm@ti.com/ > V1: https://lore.kernel.org/all/20250813190835.344563-1-nm@ti.com/ > > Nishanth Menon (5): > dt-bindings: display: bridge: it66121: Add compatible string for > IT66122 > drm/bridge: it66121: Drop ftrace like dev_dbg() prints > drm/bridge: it66121: Sort the compatibles > drm/bridge: it66121: Use vid/pid to detect the type of chip > drm/bridge: it66121: Add minimal it66122 support > > .../bindings/display/bridge/ite,it66121.yaml | 1 + > drivers/gpu/drm/bridge/ite-it66121.c | 68 +++++++++---------- > 2 files changed, 34 insertions(+), 35 deletions(-) > For the series: Reviewed-by: Tomi Valkeinen Tomi