devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Stefan Riedmüller" <S.Riedmueller@phytec.de>
To: "kernel@pengutronix.de" <kernel@pengutronix.de>,
	"linux-imx@nxp.com" <linux-imx@nxp.com>,
	"andrej.picej@norik.com" <andrej.picej@norik.com>,
	"s.hauer@pengutronix.de" <s.hauer@pengutronix.de>,
	"shawnguo@kernel.org" <shawnguo@kernel.org>,
	"festevam@gmail.com" <festevam@gmail.com>,
	"conor+dt@kernel.org" <conor+dt@kernel.org>,
	"krzysztof.kozlowski+dt@linaro.org" 
	<krzysztof.kozlowski+dt@linaro.org>,
	"robh+dt@kernel.org" <robh+dt@kernel.org>
Cc: "linux-arm-kernel@lists.infradead.org"
	<linux-arm-kernel@lists.infradead.org>,
	"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"Stefan Müller-Klieser" <S.Mueller-Klieser@phytec.de>,
	"upstream@phytec.de" <upstream@phytec.de>
Subject: Re: [PATCH v2 1/3] ARM: dts: imx6: phytec: fix RTC interrupt level
Date: Wed, 19 Jul 2023 11:49:41 +0000	[thread overview]
Message-ID: <79bb474aaf49fca37ede6cefce241aec6eeade0d.camel@phytec.de> (raw)
In-Reply-To: <20230719114328.2239818-1-andrej.picej@norik.com>

Hi Andrej,

On Wed, 2023-07-19 at 13:43 +0200, Andrej Picej wrote:
> RTC interrupt level should be set to "LOW". This was revealed by the
> introduction of commit:
> 
>   f181987ef477 ("rtc: m41t80: use IRQ flags obtained from fwnode")
> 
> which changed the way IRQ type is obtained.
> 
> Signed-off-by: Andrej Picej <andrej.picej@norik.com>

Reviewed-by: Stefan Riedmüller <s.riedmueller@phytec.de>

> ---
> Changes in v2:
>  - no changes
> ---
>  arch/arm/boot/dts/nxp/imx/imx6qdl-phytec-mira.dtsi | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/arm/boot/dts/nxp/imx/imx6qdl-phytec-mira.dtsi
> b/arch/arm/boot/dts/nxp/imx/imx6qdl-phytec-mira.dtsi
> index 1a599c294ab8..1ca4d219609f 100644
> --- a/arch/arm/boot/dts/nxp/imx/imx6qdl-phytec-mira.dtsi
> +++ b/arch/arm/boot/dts/nxp/imx/imx6qdl-phytec-mira.dtsi
> @@ -182,7 +182,7 @@ i2c_rtc: rtc@68 {
>                 pinctrl-0 = <&pinctrl_rtc_int>;
>                 reg = <0x68>;
>                 interrupt-parent = <&gpio7>;
> -               interrupts = <8 IRQ_TYPE_LEVEL_HIGH>;
> +               interrupts = <8 IRQ_TYPE_LEVEL_LOW>;
>                 status = "disabled";
>         };
>  };

  parent reply	other threads:[~2023-07-19 11:49 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-07-19 11:43 [PATCH v2 1/3] ARM: dts: imx6: phytec: fix RTC interrupt level Andrej Picej
2023-07-19 11:43 ` [PATCH v2 2/3] ARM: dts: imx6: pfla02: Rely on PMIC reboot/reset handler Andrej Picej
2023-07-19 11:50   ` Stefan Riedmüller
2023-07-30  6:41   ` Shawn Guo
2023-07-19 11:43 ` [PATCH v2 3/3] ARM: dts: imx6: phycore: " Andrej Picej
2023-07-19 11:50   ` Stefan Riedmüller
2023-07-30  6:42   ` Shawn Guo
2023-07-19 11:49 ` Stefan Riedmüller [this message]
2023-07-30  6:34 ` [PATCH v2 1/3] ARM: dts: imx6: phytec: fix RTC interrupt level Shawn Guo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=79bb474aaf49fca37ede6cefce241aec6eeade0d.camel@phytec.de \
    --to=s.riedmueller@phytec.de \
    --cc=S.Mueller-Klieser@phytec.de \
    --cc=andrej.picej@norik.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=festevam@gmail.com \
    --cc=kernel@pengutronix.de \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-imx@nxp.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=robh+dt@kernel.org \
    --cc=s.hauer@pengutronix.de \
    --cc=shawnguo@kernel.org \
    --cc=upstream@phytec.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).