From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 43824C4332F for ; Wed, 16 Nov 2022 13:03:02 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232718AbiKPNDA (ORCPT ); Wed, 16 Nov 2022 08:03:00 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50418 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231565AbiKPNC7 (ORCPT ); Wed, 16 Nov 2022 08:02:59 -0500 Received: from mail-lf1-x12c.google.com (mail-lf1-x12c.google.com [IPv6:2a00:1450:4864:20::12c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8CCBB10568 for ; Wed, 16 Nov 2022 05:02:57 -0800 (PST) Received: by mail-lf1-x12c.google.com with SMTP id bp15so29302631lfb.13 for ; Wed, 16 Nov 2022 05:02:57 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=6nFImyqcjOCw0VPGt4sM3tOy2kTrCbLPrbHyGVMhwtU=; b=IElGtUKfWsETwq7XYWaSaFYsjCaNOE6bA7mNckgqHVfZvqPotujU9CCPPMMCyEO6L3 3yaoOGxAAMXPg15J44rMU9G3wCInMNhvs68nBoaEvSmuAuvlyedSuqOfYYqM64dYLyZJ NWeeYz/MeTYj7EpYnBfqosVV/kajQ3xmBnLJNTphmlDgDw+5oMxzIaMPRxoB0R6b2MUC xI6OirpvcBQCrSDYBeDgnXQVIdJaI3b48wykYi+16A4Ii4+Rt2TBiW4Ah7LLM/mVbM34 79dTUx4oyOS0oA+KQLtWiorNnHQ4vbXwgu+OR2pMfMIbcudxl+KRkuLcpSVlevIHwXIU l7Og== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=6nFImyqcjOCw0VPGt4sM3tOy2kTrCbLPrbHyGVMhwtU=; b=foyG3WDPzGiwGgtjFRVhOCIx8bV5hL6hhf93gL2pg2OAgibmj6f0T5Oal9wuR1HhYV mXDCVcmOCVMrTRWDi0+YlJzTAL3v8kCFZ7L1DxbB0soRcrgOrAzwvaLxxy7hhmL47U2y dW9XYpGadhgcii4RhWPxTKgTBIAfrEB0R5U8c+p6ab2l+KBCcc/dHZSNpQDCCFXldWvT jWVNpWA/n3DFU/oA1Tsew9iGMtAawNRS4wimHq3y87IIDktk0wyWwMebfWqFt0xKgVMD vB7/NlhCMNwvOO5ozjGlTj23FjZHhVmcnrVUQhDC8+B+uBsmIouB/fdYNlFTO1v17Eqq eNVQ== X-Gm-Message-State: ANoB5pmMH3QYqRwbEGEdypPdq++TtohjWCHoFeZqzbQOR44aOW9NQtFH /06V+rj65MMq0i9gZ8KTwkaJbw== X-Google-Smtp-Source: AA0mqf6L57yaZbDI7JLgcUwp7oyX1I57dd8iaDteJ1PsHvhCaFEWWDBvj2/9TxT13FHctPmfH8JcSw== X-Received: by 2002:a05:6512:1398:b0:4b1:df29:b9ee with SMTP id p24-20020a056512139800b004b1df29b9eemr7695595lfa.160.1668603775702; Wed, 16 Nov 2022 05:02:55 -0800 (PST) Received: from [192.168.0.20] (088156142067.dynamic-2-waw-k-3-2-0.vectranet.pl. [88.156.142.67]) by smtp.gmail.com with ESMTPSA id f16-20020a05651c02d000b0027708c94c9bsm2976409ljo.79.2022.11.16.05.02.54 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 16 Nov 2022 05:02:55 -0800 (PST) Message-ID: <79d783a0-b9cc-9093-6f76-0d50b9b81247@linaro.org> Date: Wed, 16 Nov 2022 14:02:53 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.2 Subject: Re: [PATCH 1/2] dt-bindings: PCI: qcom: Add SM8550 to binding Content-Language: en-US To: Abel Vesa , Andy Gross , Bjorn Andersson , Konrad Dybcio , Bjorn Helgaas , Manivannan Sadhasivam , Lorenzo Pieralisi , Rob Herring , kw@linux.com, Krzysztof Kozlowski Cc: Linux Kernel Mailing List , devicetree@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-pci@vger.kernel.org References: <20221116123505.2760397-1-abel.vesa@linaro.org> From: Krzysztof Kozlowski In-Reply-To: <20221116123505.2760397-1-abel.vesa@linaro.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 16/11/2022 13:35, Abel Vesa wrote: > Add the SM8550 platform to the binding. Subject: Drop redundant, second "binding" > > Signed-off-by: Abel Vesa > --- > .../devicetree/bindings/pci/qcom,pcie.yaml | 96 +++++++++++++++++++ > 1 file changed, 96 insertions(+) > > diff --git a/Documentation/devicetree/bindings/pci/qcom,pcie.yaml b/Documentation/devicetree/bindings/pci/qcom,pcie.yaml > index 54f07852d279..efa01a8411c4 100644 > --- a/Documentation/devicetree/bindings/pci/qcom,pcie.yaml > +++ b/Documentation/devicetree/bindings/pci/qcom,pcie.yaml > @@ -34,6 +34,8 @@ properties: > - qcom,pcie-sm8250 > - qcom,pcie-sm8450-pcie0 > - qcom,pcie-sm8450-pcie1 > + - qcom,pcie-sm8550-pcie0 > + - qcom,pcie-sm8550-pcie1 I am not sure what's the benefit of encoding arbitrary IDs to compatible just to differentiate by clocks. The devices are basically the same, so compatible should be the same. > - qcom,pcie-ipq6018 > > reg: > @@ -92,6 +94,10 @@ properties: > power-domains: > maxItems: 1 > > + enable-gpios: > + description: GPIO controlled connection to ENABLE# signal > + maxItems: 1 Does not look like used property... > + > perst-gpios: > description: GPIO controlled connection to PERST# signal > maxItems: 1 > @@ -187,6 +193,8 @@ allOf: > - qcom,pcie-sm8250 > - qcom,pcie-sm8450-pcie0 > - qcom,pcie-sm8450-pcie1 > + - qcom,pcie-sm8550-pcie0 > + - qcom,pcie-sm8550-pcie1 > then: > properties: > reg: > @@ -601,6 +609,92 @@ allOf: > items: > - const: pci # PCIe core reset > > + - if: > + properties: > + compatible: > + contains: > + enum: > + - qcom,pcie-sm8550-pcie0 > + then: > + properties: > + clocks: > + minItems: 11 > + maxItems: 11 > + clock-names: > + items: > + - const: pipe # PIPE clock > + - const: pipe_mux # PIPE MUX > + - const: phy_pipe # PIPE output clock > + - const: ref # REFERENCE clock > + - const: aux # Auxiliary clock > + - const: cfg # Configuration clock > + - const: bus_master # Master AXI clock > + - const: bus_slave # Slave AXI clock > + - const: slave_q2a # Slave Q2A clock > + - const: ddrss_sf_tbu # PCIe SF TBU clock > + - const: aggre0 # Aggre NoC PCIe0 AXI clock > + interconnects: > + maxItems: 1 > + interconnect-names: > + const: icc_path Keep existing pattern of allOf:if:then or change entire file to a different style. Best regards, Krzysztof