From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Claudiu Beznea <claudiu.beznea@microchip.com>,
srinivas.kandagatla@linaro.org, robh+dt@kernel.org,
krzk+dt@kernel.org
Cc: linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, devicetree@vger.kernel.org
Subject: Re: [PATCH v2 2/2] nvmem: microchip-otpc: add support
Date: Tue, 17 May 2022 16:08:55 +0200 [thread overview]
Message-ID: <79dcb6b9-e983-15ee-709b-878c889bfe4d@linaro.org> (raw)
In-Reply-To: <20220517125822.579580-3-claudiu.beznea@microchip.com>
On 17/05/2022 14:58, Claudiu Beznea wrote:
Thank you for your patch. There is something to discuss/improve.
> +static const struct of_device_id mchp_otpc_ids[] = {
> + { .compatible = "microchip,sama7g5-otpc", },
> + { },
> +};
> +MODULE_DEVICE_TABLE(of, mchp_otpc_ids);
> +
> +static struct platform_driver mchp_otpc_driver = {
> + .probe = mchp_otpc_probe,
> + .driver = {
> + .name = MCHP_OTPC_NAME,
> + .of_match_table = of_match_ptr(mchp_otpc_ids),
This still has incorrect pair of of_match_ptr/maybe_unused. Either both,
or none.
Best regards,
Krzysztof
prev parent reply other threads:[~2022-05-17 14:09 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-17 12:58 [PATCH v2 0/2] nvmem: add Microchip OTP controller Claudiu Beznea
2022-05-17 12:58 ` [PATCH v2 1/2] dt-bindings: microchip-otpc: document Microchip OTPC Claudiu Beznea
2022-05-17 14:08 ` Krzysztof Kozlowski
2022-05-17 12:58 ` [PATCH v2 2/2] nvmem: microchip-otpc: add support Claudiu Beznea
2022-05-17 14:08 ` Krzysztof Kozlowski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=79dcb6b9-e983-15ee-709b-878c889bfe4d@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=claudiu.beznea@microchip.com \
--cc=devicetree@vger.kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=srinivas.kandagatla@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).