From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Michal Simek <michal.simek@amd.com>,
linux-kernel@vger.kernel.org, monstr@monstr.eu,
michal.simek@xilinx.com, git@xilinx.com
Cc: Conor Dooley <conor+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
Michael Grzeschik <m.grzeschik@pengutronix.de>,
Parth Gajjar <parth.gajjar@amd.com>,
Radhey Shyam Pandey <radhey.shyam.pandey@amd.com>,
Rob Herring <robh+dt@kernel.org>,
Sai Krishna Potthuri <lakshmi.sai.krishna.potthuri@xilinx.com>,
Varalaxmi Bingi <varalaxmi.bingi@amd.com>,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] arm64: zynqmp: Add missing destination mailbox compatible
Date: Thu, 30 Nov 2023 10:29:06 +0100 [thread overview]
Message-ID: <79f65b96-9015-41c4-b4ee-a82526c9eefc@linaro.org> (raw)
In-Reply-To: <96460adbb99ea829a2a95c72a40118f81946a559.1701335951.git.michal.simek@amd.com>
On 30/11/2023 10:19, Michal Simek wrote:
> The commit 81186dc16101 ("dt-bindings: zynqmp: add destination mailbox
> compatible") make compatible string for child nodes mandatory that's why
> add it.
>
> Signed-off-by: Michal Simek <michal.simek@amd.com>
> ---
>
> arch/arm64/boot/dts/xilinx/zynqmp.dtsi | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/arch/arm64/boot/dts/xilinx/zynqmp.dtsi b/arch/arm64/boot/dts/xilinx/zynqmp.dtsi
> index f5e1eb8cb3b7..eaba466804bc 100644
> --- a/arch/arm64/boot/dts/xilinx/zynqmp.dtsi
> +++ b/arch/arm64/boot/dts/xilinx/zynqmp.dtsi
> @@ -141,6 +141,7 @@ zynqmp_ipi: zynqmp-ipi {
>
> ipi_mailbox_pmu1: mailbox@ff9905c0 {
> bootph-all;
> + compatible = "xlnx,zynqmp-ipi-dest-mailbox";
Probably you want it as first property. Although then reg is also placed
odd, but it's all because bootph-all was put at the beginning.
Best regards,
Krzysztof
next prev parent reply other threads:[~2023-11-30 9:29 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-30 9:19 [PATCH] arm64: zynqmp: Add missing destination mailbox compatible Michal Simek
2023-11-30 9:29 ` Krzysztof Kozlowski [this message]
2023-11-30 10:02 ` Michal Simek
2023-11-30 12:05 ` Krzysztof Kozlowski
2023-12-13 15:47 ` Michal Simek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=79f65b96-9015-41c4-b4ee-a82526c9eefc@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=git@xilinx.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=lakshmi.sai.krishna.potthuri@xilinx.com \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=m.grzeschik@pengutronix.de \
--cc=michal.simek@amd.com \
--cc=michal.simek@xilinx.com \
--cc=monstr@monstr.eu \
--cc=parth.gajjar@amd.com \
--cc=radhey.shyam.pandey@amd.com \
--cc=robh+dt@kernel.org \
--cc=varalaxmi.bingi@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).