* [PATCH] arm64: zynqmp: Add missing destination mailbox compatible
@ 2023-11-30 9:19 Michal Simek
2023-11-30 9:29 ` Krzysztof Kozlowski
2023-12-13 15:47 ` Michal Simek
0 siblings, 2 replies; 5+ messages in thread
From: Michal Simek @ 2023-11-30 9:19 UTC (permalink / raw)
To: linux-kernel, monstr, michal.simek, git
Cc: Conor Dooley, Krzysztof Kozlowski, Laurent Pinchart,
Michael Grzeschik, Parth Gajjar, Radhey Shyam Pandey, Rob Herring,
Sai Krishna Potthuri, Varalaxmi Bingi, devicetree,
linux-arm-kernel
The commit 81186dc16101 ("dt-bindings: zynqmp: add destination mailbox
compatible") make compatible string for child nodes mandatory that's why
add it.
Signed-off-by: Michal Simek <michal.simek@amd.com>
---
arch/arm64/boot/dts/xilinx/zynqmp.dtsi | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/arm64/boot/dts/xilinx/zynqmp.dtsi b/arch/arm64/boot/dts/xilinx/zynqmp.dtsi
index f5e1eb8cb3b7..eaba466804bc 100644
--- a/arch/arm64/boot/dts/xilinx/zynqmp.dtsi
+++ b/arch/arm64/boot/dts/xilinx/zynqmp.dtsi
@@ -141,6 +141,7 @@ zynqmp_ipi: zynqmp-ipi {
ipi_mailbox_pmu1: mailbox@ff9905c0 {
bootph-all;
+ compatible = "xlnx,zynqmp-ipi-dest-mailbox";
reg = <0x0 0xff9905c0 0x0 0x20>,
<0x0 0xff9905e0 0x0 0x20>,
<0x0 0xff990e80 0x0 0x20>,
--
2.36.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] arm64: zynqmp: Add missing destination mailbox compatible
2023-11-30 9:19 [PATCH] arm64: zynqmp: Add missing destination mailbox compatible Michal Simek
@ 2023-11-30 9:29 ` Krzysztof Kozlowski
2023-11-30 10:02 ` Michal Simek
2023-12-13 15:47 ` Michal Simek
1 sibling, 1 reply; 5+ messages in thread
From: Krzysztof Kozlowski @ 2023-11-30 9:29 UTC (permalink / raw)
To: Michal Simek, linux-kernel, monstr, michal.simek, git
Cc: Conor Dooley, Krzysztof Kozlowski, Laurent Pinchart,
Michael Grzeschik, Parth Gajjar, Radhey Shyam Pandey, Rob Herring,
Sai Krishna Potthuri, Varalaxmi Bingi, devicetree,
linux-arm-kernel
On 30/11/2023 10:19, Michal Simek wrote:
> The commit 81186dc16101 ("dt-bindings: zynqmp: add destination mailbox
> compatible") make compatible string for child nodes mandatory that's why
> add it.
>
> Signed-off-by: Michal Simek <michal.simek@amd.com>
> ---
>
> arch/arm64/boot/dts/xilinx/zynqmp.dtsi | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/arch/arm64/boot/dts/xilinx/zynqmp.dtsi b/arch/arm64/boot/dts/xilinx/zynqmp.dtsi
> index f5e1eb8cb3b7..eaba466804bc 100644
> --- a/arch/arm64/boot/dts/xilinx/zynqmp.dtsi
> +++ b/arch/arm64/boot/dts/xilinx/zynqmp.dtsi
> @@ -141,6 +141,7 @@ zynqmp_ipi: zynqmp-ipi {
>
> ipi_mailbox_pmu1: mailbox@ff9905c0 {
> bootph-all;
> + compatible = "xlnx,zynqmp-ipi-dest-mailbox";
Probably you want it as first property. Although then reg is also placed
odd, but it's all because bootph-all was put at the beginning.
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] arm64: zynqmp: Add missing destination mailbox compatible
2023-11-30 9:29 ` Krzysztof Kozlowski
@ 2023-11-30 10:02 ` Michal Simek
2023-11-30 12:05 ` Krzysztof Kozlowski
0 siblings, 1 reply; 5+ messages in thread
From: Michal Simek @ 2023-11-30 10:02 UTC (permalink / raw)
To: Krzysztof Kozlowski, linux-kernel, monstr, michal.simek, git
Cc: Conor Dooley, Krzysztof Kozlowski, Laurent Pinchart,
Michael Grzeschik, Parth Gajjar, Radhey Shyam Pandey, Rob Herring,
Sai Krishna Potthuri, Varalaxmi Bingi, devicetree,
linux-arm-kernel
On 11/30/23 10:29, Krzysztof Kozlowski wrote:
> On 30/11/2023 10:19, Michal Simek wrote:
>> The commit 81186dc16101 ("dt-bindings: zynqmp: add destination mailbox
>> compatible") make compatible string for child nodes mandatory that's why
>> add it.
>>
>> Signed-off-by: Michal Simek <michal.simek@amd.com>
>> ---
>>
>> arch/arm64/boot/dts/xilinx/zynqmp.dtsi | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/arch/arm64/boot/dts/xilinx/zynqmp.dtsi b/arch/arm64/boot/dts/xilinx/zynqmp.dtsi
>> index f5e1eb8cb3b7..eaba466804bc 100644
>> --- a/arch/arm64/boot/dts/xilinx/zynqmp.dtsi
>> +++ b/arch/arm64/boot/dts/xilinx/zynqmp.dtsi
>> @@ -141,6 +141,7 @@ zynqmp_ipi: zynqmp-ipi {
>>
>> ipi_mailbox_pmu1: mailbox@ff9905c0 {
>> bootph-all;
>> + compatible = "xlnx,zynqmp-ipi-dest-mailbox";
>
> Probably you want it as first property. Although then reg is also placed
> odd, but it's all because bootph-all was put at the beginning.
When DTS conding style is approved I will need to resort all that nodes based on
it. I did this change to be aligned with current style which this file has.
What do you think?
Thanks,
Michal
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] arm64: zynqmp: Add missing destination mailbox compatible
2023-11-30 10:02 ` Michal Simek
@ 2023-11-30 12:05 ` Krzysztof Kozlowski
0 siblings, 0 replies; 5+ messages in thread
From: Krzysztof Kozlowski @ 2023-11-30 12:05 UTC (permalink / raw)
To: Michal Simek, linux-kernel, monstr, michal.simek, git
Cc: Conor Dooley, Krzysztof Kozlowski, Laurent Pinchart,
Michael Grzeschik, Parth Gajjar, Radhey Shyam Pandey, Rob Herring,
Sai Krishna Potthuri, Varalaxmi Bingi, devicetree,
linux-arm-kernel
On 30/11/2023 11:02, Michal Simek wrote:
>
>
> On 11/30/23 10:29, Krzysztof Kozlowski wrote:
>> On 30/11/2023 10:19, Michal Simek wrote:
>>> The commit 81186dc16101 ("dt-bindings: zynqmp: add destination mailbox
>>> compatible") make compatible string for child nodes mandatory that's why
>>> add it.
>>>
>>> Signed-off-by: Michal Simek <michal.simek@amd.com>
>>> ---
>>>
>>> arch/arm64/boot/dts/xilinx/zynqmp.dtsi | 1 +
>>> 1 file changed, 1 insertion(+)
>>>
>>> diff --git a/arch/arm64/boot/dts/xilinx/zynqmp.dtsi b/arch/arm64/boot/dts/xilinx/zynqmp.dtsi
>>> index f5e1eb8cb3b7..eaba466804bc 100644
>>> --- a/arch/arm64/boot/dts/xilinx/zynqmp.dtsi
>>> +++ b/arch/arm64/boot/dts/xilinx/zynqmp.dtsi
>>> @@ -141,6 +141,7 @@ zynqmp_ipi: zynqmp-ipi {
>>>
>>> ipi_mailbox_pmu1: mailbox@ff9905c0 {
>>> bootph-all;
>>> + compatible = "xlnx,zynqmp-ipi-dest-mailbox";
>>
>> Probably you want it as first property. Although then reg is also placed
>> odd, but it's all because bootph-all was put at the beginning.
>
> When DTS conding style is approved I will need to resort all that nodes based on
> it. I did this change to be aligned with current style which this file has.
> What do you think?
Hm, indeed. So it is entirely up to you :)
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] arm64: zynqmp: Add missing destination mailbox compatible
2023-11-30 9:19 [PATCH] arm64: zynqmp: Add missing destination mailbox compatible Michal Simek
2023-11-30 9:29 ` Krzysztof Kozlowski
@ 2023-12-13 15:47 ` Michal Simek
1 sibling, 0 replies; 5+ messages in thread
From: Michal Simek @ 2023-12-13 15:47 UTC (permalink / raw)
To: linux-kernel, monstr, michal.simek, git
Cc: Conor Dooley, Krzysztof Kozlowski, Laurent Pinchart,
Michael Grzeschik, Parth Gajjar, Radhey Shyam Pandey, Rob Herring,
Sai Krishna Potthuri, Varalaxmi Bingi, devicetree,
linux-arm-kernel
On 11/30/23 10:19, Michal Simek wrote:
> The commit 81186dc16101 ("dt-bindings: zynqmp: add destination mailbox
> compatible") make compatible string for child nodes mandatory that's why
> add it.
>
> Signed-off-by: Michal Simek <michal.simek@amd.com>
> ---
>
> arch/arm64/boot/dts/xilinx/zynqmp.dtsi | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/arch/arm64/boot/dts/xilinx/zynqmp.dtsi b/arch/arm64/boot/dts/xilinx/zynqmp.dtsi
> index f5e1eb8cb3b7..eaba466804bc 100644
> --- a/arch/arm64/boot/dts/xilinx/zynqmp.dtsi
> +++ b/arch/arm64/boot/dts/xilinx/zynqmp.dtsi
> @@ -141,6 +141,7 @@ zynqmp_ipi: zynqmp-ipi {
>
> ipi_mailbox_pmu1: mailbox@ff9905c0 {
> bootph-all;
> + compatible = "xlnx,zynqmp-ipi-dest-mailbox";
> reg = <0x0 0xff9905c0 0x0 0x20>,
> <0x0 0xff9905e0 0x0 0x20>,
> <0x0 0xff990e80 0x0 0x20>,
Applied.
M
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2023-12-13 15:47 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-11-30 9:19 [PATCH] arm64: zynqmp: Add missing destination mailbox compatible Michal Simek
2023-11-30 9:29 ` Krzysztof Kozlowski
2023-11-30 10:02 ` Michal Simek
2023-11-30 12:05 ` Krzysztof Kozlowski
2023-12-13 15:47 ` Michal Simek
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).