From: Svyatoslav Ryhel <clamor95@gmail.com>
To: Arnd Bergmann <arnd@arndb.de>,
Jonathan Cameron <jic23@kernel.org>,
Lars-Peter Clausen <lars@metafoo.de>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Samu Onkalo <samu.p.onkalo@nokia.com>
Cc: linux-iio@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1 2/2] misc: adps990x: convert to OF
Date: Mon, 31 Jul 2023 17:58:37 +0300 [thread overview]
Message-ID: <7C51AA15-DEBE-486B-9788-F84B260F8880@gmail.com> (raw)
In-Reply-To: <a16db5ac-2b9a-45ab-b693-2f459d689c7d@app.fastmail.com>
31 липня 2023 р. 16:18:16 GMT+03:00, Arnd Bergmann <arnd@arndb.de> написав(-ла):
>On Mon, Jul 31, 2023, at 13:02, Svyatoslav Ryhel wrote:
>> Add ability to use device tree bindings keeping existing setup.
>
>I see that there are no more in-tree users of the old
>apds990x_platform_data, so I think it would be best to completely
>remove that codepath and merge that structure into struct
>apds990x_chip, to simplify the probing and avoid the extra
>allocation.
Thank you very much for your review, but is it mandatory to drop pdata in this particular patch set? To be honest this driver needs serious upgrades and refactoring, and I have no dedication to invest my time into refactoring it, moreover, I am not a maintainer of this driver, nor a full time kernel maintainer of any kind. I am doing what I am doing only because one of my devices uses this als but it is not something crucial.
Best regards,
Svyatoslav R.
> Arnd
next prev parent reply other threads:[~2023-07-31 14:58 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-31 11:02 [PATCH v1 0/2] Update APDS990x ALS to support device trees Svyatoslav Ryhel
2023-07-31 11:02 ` [PATCH v1 1/2] dt-bindings: iio: light: add apds990x binding Svyatoslav Ryhel
2023-07-31 13:23 ` Arnd Bergmann
2023-07-31 11:02 ` [PATCH v1 2/2] misc: adps990x: convert to OF Svyatoslav Ryhel
2023-07-31 13:18 ` Arnd Bergmann
2023-07-31 14:58 ` Svyatoslav Ryhel [this message]
2023-07-31 15:38 ` Arnd Bergmann
2023-08-01 18:10 ` Jonathan Cameron
2023-08-01 18:13 ` Svyatoslav Ryhel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7C51AA15-DEBE-486B-9788-F84B260F8880@gmail.com \
--to=clamor95@gmail.com \
--cc=arnd@arndb.de \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=jic23@kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=samu.p.onkalo@nokia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox