From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 64A853C8713; Fri, 10 Jul 2026 07:19:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783667957; cv=none; b=L5/da0+ouhW83AanQqsFDRTbXQ1rwj967umt6rTbaYFkpAZMeyLsGg9OBOfVLfENckP18cTWt1lK1s749vBq/8+rJcpCBN318/sZA9HGWol6ClUZu1es3aznBRROhVDbDzIENjJDCIKD4Vq4kwPMdmnd1Y1fMJ4YZc7wHsU78gA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783667957; c=relaxed/simple; bh=2ebazmcRQz6NTsvpvpn73W5dWmXNinBJYeLt1uzYNvg=; h=Message-ID:Date:MIME-Version:Subject:From:To:Cc:References: In-Reply-To:Content-Type; b=Bo5FJuR/nMwxSJ6tSbH7P8bCubEW1xhqu87n2gU2eFgtGOO3bXLz9SgXDiclF6NQcfNh8LPON4SKv9f/n5jkc3kN0RIOxb1ASubi/Sfxb+NnlSSzCVnH9WIyaPBmNT+awaC4wpvCCc8MMIeVRLllcD+ktaEm10emZpe0GDsw97A= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=myXt26N+; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="myXt26N+" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 568EE1F000E9; Fri, 10 Jul 2026 07:19:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1783667955; bh=GPaDaing63u8qADiTsjeVrYu7NPcyjiWM8KEXDrvz9E=; h=Date:Subject:From:To:Cc:References:In-Reply-To; b=myXt26N+Lz+EnKHBU7BBwU7Tw70R4AV5g7mHyYC2Tqxglt4zDx5i1ZMiwQp2Cv1+p q65emxLUCqHPa8drEvKTT3+8KT/jU+bQmJfliWQdm3q2jxd3Zn+rnDJFcR8oYftvD8 /gYmOvg64y/of7bT/X6A5K+tl1ZOF0TfoDVT/z09AOsFjAJ+TWxrDU90YurgJExIvR mdkrtFnbjmkIxlM5wm1gU/1QFGZ7G2C8MmmBCX6nHHMGkPYW3KGGUXzMvtPj1aS5zO z6WcpsLg/ubragzAMDXaC7mwBC6JEwWpWW/peCTAlQGve/lZBmC976JI6sBNEqN9DY DsN2SC2AltTqw== Message-ID: <7a099224-ea95-40ec-b279-f8834f261e23@kernel.org> Date: Fri, 10 Jul 2026 09:19:10 +0200 Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 1/2] dt-bindings: qcom,snps-dwc3: Add property indicating presence of eUSB2 phy From: Krzysztof Kozlowski To: Thinh Nguyen Cc: Dmitry Baryshkov , Krishna Kurapati , Greg Kroah-Hartman , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Wesley Cheng , "linux-arm-msm@vger.kernel.org" , "linux-usb@vger.kernel.org" , "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" References: <20260709-eusb2-interrupt-handling-v5-v4-0-d4f993925608@oss.qualcomm.com> <20260709-eusb2-interrupt-handling-v5-v4-1-d4f993925608@oss.qualcomm.com> <20260710-warping-resolute-wasp-e4b8ce@quoll> Content-Language: en-US Autocrypt: addr=krzk@kernel.org; keydata= xsFNBFVDQq4BEAC6KeLOfFsAvFMBsrCrJ2bCalhPv5+KQF2PS2+iwZI8BpRZoV+Bd5kWvN79 cFgcqTTuNHjAvxtUG8pQgGTHAObYs6xeYJtjUH0ZX6ndJ33FJYf5V3yXqqjcZ30FgHzJCFUu JMp7PSyMPzpUXfU12yfcRYVEMQrmplNZssmYhiTeVicuOOypWugZKVLGNm0IweVCaZ/DJDIH gNbpvVwjcKYrx85m9cBVEBUGaQP6AT7qlVCkrf50v8bofSIyVa2xmubbAwwFA1oxoOusjPIE J3iadrwpFvsZjF5uHAKS+7wHLoW9hVzOnLbX6ajk5Hf8Pb1m+VH/E8bPBNNYKkfTtypTDUCj NYcd27tjnXfG+SDs/EXNUAIRefCyvaRG7oRYF3Ec+2RgQDRnmmjCjoQNbFrJvJkFHlPeHaeS BosGY+XWKydnmsfY7SSnjAzLUGAFhLd/XDVpb1Een2XucPpKvt9ORF+48gy12FA5GduRLhQU vK4tU7ojoem/G23PcowM1CwPurC8sAVsQb9KmwTGh7rVz3ks3w/zfGBy3+WmLg++C2Wct6nM Pd8/6CBVjEWqD06/RjI2AnjIq5fSEH/BIfXXfC68nMp9BZoy3So4ZsbOlBmtAPvMYX6U8VwD TNeBxJu5Ex0Izf1NV9CzC3nNaFUYOY8KfN01X5SExAoVTr09ewARAQABzSVLcnp5c3p0b2Yg S296bG93c2tpIDxrcnprQGtlcm5lbC5vcmc+wsGPBBMBCgA5AhsDBgsJCAcDAgYVCAIJCgsE FgIDAQIeAQIXgBYhBJvQfg4MUfjVlne3VBuTQ307QWKbBQJp2mE8AAoJEBuTQ307QWKbeaIP /ihHTkTW4KsN/DQ945JJbyu5tI0J80Wue7QyyLPglyKfhgb5cLLNPpOC8cCIJsc7+W3i2P38 s2c1cOH6CYGE7E9ur3Vfme8NW2S2I/Z8VC7bZnzyS23wT17LrsdS/qCpx4o8U+pt/xdXDKph EGRYrIEmMpUWvyYzyYKGIe25FtaayIIKpq8eZYyFcp2f/sG5IkOW5uZzHPMPdcm87jU7fyuQ rAU2vx9r+ulUfQ/q9Z2roC/ode3l7t2pN7BCBCsUDp6JCrUyZrtT1e7EbA0ZRP3aOBNk2P2E DQOgJGjGdO5Yx2Y9LFtltu6JbsBJHi1syGRX3AtQYOMc4Y1WGoeZJmMlvKj2ZqqXNkcWi2DS IQEWB0uW6CqFsBBIMGDa+6OzdaVO/uAVXWDWml02Men3CILdI1MbVjoh8ECqYUY7OQ+JJvNN vnliuq5WM3Ghd3jg/LZZrxXjdIginRHFQCjIJYLKpLZWm1/iDFedcfzqRNYmTtqscdCNHW41 oT3Z7BmO9xwdjuwBS6nmS6JJwkbf5Ot2QR4pB/DRU7ZwjT1qHe+9r9gF32wXVQatHNGK/VVu sfwOnkdxCWkp/qb2gdQRmZh+SedStWshigH6sNfuHBloF/q+hjMRc8b2m326OZdrbSHwY1Sz vti8Hn7n8NjdHO9LKB7BIdjkA9DA5WsqOuVCzsFNBFVDXDQBEADNkrQYSREUL4D3Gws46JEo Z9HEQOKtkrwjrzlw/tCmqVzERRPvz2Xg8n7+HRCrgqnodIYoUh5WsU84N03KlLueMNsWLJBv BaubYN4JuJIdRr4dS4oyF1/fQAQPHh8Thpiz0SAZFx6iWKB7Qrz3OrGCjTPcW6eiOMheesVS 5hxietSmlin+SilmIAPZHx7n242u6kdHOh+/SyLImKn/dh9RzatVpUKbv34eP1wAGldWsRxb f3WP9pFNObSzI/Bo3kA89Xx2rO2roC+Gq4LeHvo7ptzcLcrqaHUAcZ3CgFG88CnA6z6lBZn0 WyewEcPOPdcUB2Q7D/NiUY+HDiV99rAYPJztjeTrBSTnHeSBPb+qn5ZZGQwIdUW9YegxWKvX XHTwB5eMzo/RB6vffwqcnHDoe0q7VgzRRZJwpi6aMIXLfeWZ5Wrwaw2zldFuO4Dt91pFzBSO IpeMtfgb/Pfe/a1WJ/GgaIRIBE+NUqckM+3zJHGmVPqJP/h2Iwv6nw8U+7Yyl6gUBLHFTg2h YnLFJI4Xjg+AX1hHFVKmvl3VBHIsBv0oDcsQWXqY+NaFahT0lRPjYtrTa1v3tem/JoFzZ4B0 p27K+qQCF2R96hVvuEyjzBmdq2esyE6zIqftdo4MOJho8uctOiWbwNNq2U9pPWmu4vXVFBYI GmpyNPYzRm0QPwARAQABwsF2BBgBCgAgAhsMFiEEm9B+DgxR+NWWd7dUG5NDfTtBYpsFAmna YUkACgkQG5NDfTtBYptX+BAApg32CkxwNucNEi8WfWA8oKkW0y8YDuY6ORMo9FWNGiT/OTy0 vyJrLocrpn86zwfjVp+eCrssPYh8eqJfnWqmYv6ACQtHPYzPZQ3mSo8H97Z01oUxITzCxpXm ZkLgPIqtDPcC2E3dPM/fVxcyowM8XsaMA9wcsaUYrta8toOq2b9tKcjleKMfMrm0gQ9u7wUc QbLkwj6TCLOwucb07GXzLTNF9PZmaDUpKAZjMjmrW+le+SFvQbhamx0rxLWPR0NWntXpbCn+ +ACch03p/JyTBVktxFsFyCt7pTPE1kEaeuXBTe/a2D9iQvRxRW19LvuO2e59/u1wYUiH/orz wbIC2S4dBsPAPihL3ztOU1yE86GPyQtSE0kU+/7snnLt4QGi6PChf3t5gnNjAzjUUovO8rgI c+5yN5heq5loYHgK6OQ9OlHzsPHO9e9MOQcKlFycs1pyijFGzDwdNUm/SchK8iWT2QApTx4A K9bCVaboTA2T77QYkRcRJYSsO1alGX0ome/hMLD1daXlkrNUp1HWa3K4iytLRXjCSIorWiGs n+q3krnpXu3TFkA8qtOFZMdnIiFuiq1yLT8hptsV5xh1TA2nsVvSYiaCr3q4s4BKjS/KrLDb qoxzw8ISjdUp4pA85vb6YLCmb39NgidD+7PmAr65lBNveIFynTgsja1rRQ4= In-Reply-To: <20260710-warping-resolute-wasp-e4b8ce@quoll> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 10/07/2026 09:16, Krzysztof Kozlowski wrote: > On Fri, Jul 10, 2026 at 01:52:45AM +0000, Thinh Nguyen wrote: >> On Thu, Jul 09, 2026, Dmitry Baryshkov wrote: >>> On Thu, Jul 09, 2026 at 02:22:36PM +0530, Krishna Kurapati wrote: >>>> Add property "qcom,has-eusb2-phy" to indicate whether the SoC has eUSB2 phy >>>> or not. This is used to modify dp/dm interrupts during host mode suspend. >>>> >>>> Signed-off-by: Krishna Kurapati >>>> --- >>>> Documentation/devicetree/bindings/usb/qcom,snps-dwc3.yaml | 7 +++++++ >>>> 1 file changed, 7 insertions(+) >>>> >>>> diff --git a/Documentation/devicetree/bindings/usb/qcom,snps-dwc3.yaml b/Documentation/devicetree/bindings/usb/qcom,snps-dwc3.yaml >>>> index 8201656b41ed..0c6a839be82f 100644 >>>> --- a/Documentation/devicetree/bindings/usb/qcom,snps-dwc3.yaml >>>> +++ b/Documentation/devicetree/bindings/usb/qcom,snps-dwc3.yaml >>>> @@ -152,6 +152,13 @@ properties: >>>> HS/FS/LS modes are supported. >>>> type: boolean >>>> >>>> + qcom,has-eusb2-phy: >>>> + description: >>>> + If present, it indicates that the controller is working with eUSB2 >>>> + phy. This property is used to modify dp/dm interrupt configurations >>>> + while entering suspend. >>>> + type: boolean >>> >>> I still have exactly the same concern. This information is already >>> present in the DT. >>> >> >> Could you clarify what you mean by "this information is already present >> in the DT"? Are you suggesting we use the dwc3 node's compatible string >> to infer the phy type? >> >> The dwc3 glue compatible describes the controller, not the phy. They are >> separate IP blocks. A board variant could reuse the same dwc3 compatible >> with a different phy attached, making that inference silently wrong. >> >> The phy type is described somewhere else in the DT (in the phy node >> itself), referenced via the phy's phandle on the dwc3 core child node. >> We could walk that phandle and check whether the phy node's compatible >> contains "eusb2". However, that relies on a naming convention that isn't >> enforced anywhere. All current eusb2 phy compatibles happen to follow it >> (qcom,sm8550-snps-eusb2-phy, qcom,sm8750-m31-eusb2-phy, >> samsung,exynos2200-eusb2-phy, etc.), but a future phy driver could break > > You have a fixed/finite list of phys which needs something special, so > that information as Dmitry said is in DT already. > > Anyway, the commit msg and property field have insufficient description > of actual hardware problem being represented by this property, so it > looks way too much as SW policy. And Dmitry already said this at v3. And Sashiko gave the same review: "[Medium] The `qcom,has-eusb2-phy` property introduces a redundant boolean flag that duplicates existing hardware topology information, and its description incorrectly encodes software behavior." Best regards, Krzysztof