From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Jimmy Chen <u7702045@gmail.com>, Arnd Bergmann <arnd@arndb.de>,
Olof Johansson <olof@lixom.net>,
soc@kernel.org, Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Shawn Guo <shawnguo@kernel.org>,
Sascha Hauer <s.hauer@pengutronix.de>,
Pengutronix Kernel Team <kernel@pengutronix.de>,
Fabio Estevam <festevam@gmail.com>,
NXP Linux Team <linux-imx@nxp.com>
Cc: Jimmy Chen <jimmy.chen@moxa.com>,
linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 3/3] ARM: dts: imx7d: fixed dts for UC-8210/8220 hardware
Date: Tue, 12 Jul 2022 09:42:54 +0200 [thread overview]
Message-ID: <7a1199e6-cdfc-d89e-84d9-db43ef135786@linaro.org> (raw)
In-Reply-To: <20220712045505.4500-3-jimmy.chen@moxa.com>
On 12/07/2022 06:55, Jimmy Chen wrote:
> fix compatible string reference to fsl.yaml
> change regulator node name
> replace underscore to dash
> replace node name
> remove 'status' attribute from node
> add board compatible and model to ixm7d-moxa-uc-8210.dts
> rearrange 82XX alphabet order in Makefile
This commit description does not make any sense. You messed up commit
description with changelog. Please go through SubmittingPatches doc few
times.
>
> Signed-off-by: Jimmy Chen <jimmy.chen@moxa.com>
> ---
> arch/arm/boot/dts/Makefile | 4 +--
> arch/arm/boot/dts/imx7d-moxa-uc-8210.dts | 46 +++++++++++-------------
> arch/arm/boot/dts/imx7d-moxa-uc-8220.dts | 9 +++--
> 3 files changed, 29 insertions(+), 30 deletions(-)
>
> diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile
> index 37db3b60ba43..c9c57626876c 100644
> --- a/arch/arm/boot/dts/Makefile
> +++ b/arch/arm/boot/dts/Makefile
> @@ -747,6 +747,8 @@ dtb-$(CONFIG_SOC_IMX7D) += \
> imx7d-flex-concentrator-mfg.dtb \
> imx7d-mba7.dtb \
> imx7d-meerkat96.dtb \
> + imx7d-moxa-uc-8210.dtb \
> + imx7d-moxa-uc-8220.dtb \
> imx7d-nitrogen7.dtb \
> imx7d-pico-dwarf.dtb \
> imx7d-pico-hobbit.dtb \
> @@ -755,8 +757,6 @@ dtb-$(CONFIG_SOC_IMX7D) += \
> imx7d-remarkable2.dtb \
> imx7d-sbc-imx7.dtb \
> imx7d-sdb.dtb \
> - imx7d-moxa-uc-8210.dtb \
> - imx7d-moxa-uc-8220.dtb \
There are no such entries. Rest is even weirder...
Best regards,
Krzysztof
next prev parent reply other threads:[~2022-07-12 7:43 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-12 4:55 [PATCH v2 1/3] Remove an entry for MOXA platform board Jimmy Chen
2022-07-12 4:55 ` [PATCH v2 2/3] dt-bindings: arm: fsl: Add Moxa UC8210/8220 series Jimmy Chen
2022-07-12 7:41 ` Krzysztof Kozlowski
2022-07-12 4:55 ` [PATCH v2 3/3] ARM: dts: imx7d: fixed dts for UC-8210/8220 hardware Jimmy Chen
2022-07-12 7:42 ` Krzysztof Kozlowski [this message]
2022-07-12 7:40 ` [PATCH v2 1/3] Remove an entry for MOXA platform board Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7a1199e6-cdfc-d89e-84d9-db43ef135786@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=arnd@arndb.de \
--cc=devicetree@vger.kernel.org \
--cc=festevam@gmail.com \
--cc=jimmy.chen@moxa.com \
--cc=kernel@pengutronix.de \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=olof@lixom.net \
--cc=robh+dt@kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
--cc=soc@kernel.org \
--cc=u7702045@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).