From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8C34EC0015E for ; Mon, 10 Jul 2023 13:46:59 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230211AbjGJNq6 (ORCPT ); Mon, 10 Jul 2023 09:46:58 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52172 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230322AbjGJNq5 (ORCPT ); Mon, 10 Jul 2023 09:46:57 -0400 Received: from phobos.denx.de (phobos.denx.de [IPv6:2a01:238:438b:c500:173d:9f52:ddab:ee01]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C91921B0; Mon, 10 Jul 2023 06:46:34 -0700 (PDT) Received: from [127.0.0.1] (p578adb1c.dip0.t-ipconnect.de [87.138.219.28]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: marex@denx.de) by phobos.denx.de (Postfix) with ESMTPSA id E319286655; Mon, 10 Jul 2023 15:46:31 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=denx.de; s=phobos-20191101; t=1688996792; bh=Qlc3zZzq8dQ9cUEjb5aJKqAbARIkL5ACsA8xLeQzVpA=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=PVcy3gtRFT2E6fmy/7piUZru4p11r6ghrop85WAUKubG6RajhuXbU2u3FZHPieT+Q aakutPofWoYXlZMRMdPskpJEphTbQXHdT+JWf621tDSpWEcI/Uxr0q1timS2A4dxFi Fxlpr4qfhHLYkNUNm4M0OHd4vaNs3wpBHbjCTSYwlyRYqV6NIlNoFafIYZqaP+HlQH l5XYYy/+JpW1owP/jeIxl6DJNBSFFM8neCl6g7Cmes3BRiBBlhS9z37Wn1w2pKnbfK 6r9gCuC7/ciEqQYk2QfwoJ5W3O+cH0PFBbx+f11aybx2gnTZVg7y+A6+yQhKfFlQVI vw1uBVzxjoyGQ== Message-ID: <7a1d7a67-0a0c-8527-d430-30a1cb40de48@denx.de> Date: Mon, 10 Jul 2023 15:46:31 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: [PATCH 1/2] dt-bindings: remoteproc: imx_rproc: Document fsl,startup-delay-ms Content-Language: en-US To: Krzysztof Kozlowski , linux-remoteproc@vger.kernel.org Cc: Bjorn Andersson , Conor Dooley , Fabio Estevam , Krzysztof Kozlowski , Mathieu Poirier , NXP Linux Team , Peng Fan , Pengutronix Kernel Team , Rob Herring , Sascha Hauer , Shawn Guo , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org References: <20230707232444.374431-1-marex@denx.de> <8f40484e-1721-a2bc-2344-f9e59e51a935@linaro.org> From: Marek Vasut In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Virus-Scanned: clamav-milter 0.103.8 at phobos.denx.de X-Virus-Status: Clean Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 7/10/23 14:52, Krzysztof Kozlowski wrote: > On 10/07/2023 11:18, Marek Vasut wrote: >> On 7/10/23 10:12, Krzysztof Kozlowski wrote: >>> On 08/07/2023 01:24, Marek Vasut wrote: >>>> Document fsl,startup-delay-ms property which indicates how long >>>> the system software should wait until attempting to communicate >>>> with the CM firmware. This gives the CM firmware a bit of time >>>> to boot and get ready for communication. >>>> >>>> Signed-off-by: Marek Vasut >>>> --- >>>> Cc: Bjorn Andersson >>>> Cc: Conor Dooley >>>> Cc: Fabio Estevam >>>> Cc: Krzysztof Kozlowski >>>> Cc: Mathieu Poirier >>>> Cc: NXP Linux Team >>>> Cc: Peng Fan >>>> Cc: Pengutronix Kernel Team >>>> Cc: Rob Herring >>>> Cc: Sascha Hauer >>>> Cc: Shawn Guo >>>> Cc: devicetree@vger.kernel.org >>>> Cc: linux-arm-kernel@lists.infradead.org >>>> Cc: linux-remoteproc@vger.kernel.org >>>> --- >>>> .../devicetree/bindings/remoteproc/fsl,imx-rproc.yaml | 5 +++++ >>>> 1 file changed, 5 insertions(+) >>>> >>>> diff --git a/Documentation/devicetree/bindings/remoteproc/fsl,imx-rproc.yaml b/Documentation/devicetree/bindings/remoteproc/fsl,imx-rproc.yaml >>>> index 0c3910f152d1d..c940199ce89df 100644 >>>> --- a/Documentation/devicetree/bindings/remoteproc/fsl,imx-rproc.yaml >>>> +++ b/Documentation/devicetree/bindings/remoteproc/fsl,imx-rproc.yaml >>>> @@ -76,6 +76,11 @@ properties: >>>> This property is to specify the resource id of the remote processor in SoC >>>> which supports SCFW >>>> >>>> + fsl,startup-delay-ms: >>>> + default: 0 >>>> + description: >>>> + CM firmware start up delay. >>> >>> I don't see particular improvements from v2 and no responses addressing >>> my comment: >>> https://lore.kernel.org/all/20221102112451.128110-2-peng.fan@oss.nxp.com/ >> >> I wasn't aware of this being submitted before, esp. since I wrote the >> binding document from scratch. Which comment is not addressed, the type >> ref is not present and the sentence starts with caps, so what is missing ? > > > That the property looks like a hacky solution to some SW problem. Why > this delay should be different on different boards? It probably depends more on the CM4 firmware that is being launched. The ones I tested were fine with 50..500ms delay, but the delay was always needed. Sure, it is a defect of the NXP provided SDK firmware, but that may not be fixable in all cases.