From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id DB87DC54EE9 for ; Mon, 19 Sep 2022 10:01:14 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229873AbiISKBM (ORCPT ); Mon, 19 Sep 2022 06:01:12 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60108 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229929AbiISKBH (ORCPT ); Mon, 19 Sep 2022 06:01:07 -0400 Received: from mail-lf1-x131.google.com (mail-lf1-x131.google.com [IPv6:2a00:1450:4864:20::131]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8FCF722BE4 for ; Mon, 19 Sep 2022 03:01:01 -0700 (PDT) Received: by mail-lf1-x131.google.com with SMTP id s6so34851344lfo.7 for ; Mon, 19 Sep 2022 03:01:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date; bh=WdUkk7yGHQTnyhcNnJU1k388XLuhNOGvfweCAo6fMwc=; b=vO5LqzsAPrNDUjoRs+Misssc19PKq07vxhSzWwiWX2rQBxBfHnl5cK5doEQlcGwsNo tpuIe+soZwbo9WrOfPLjHBRQLqxBai1/tefMKYyMMoUIm3aPUQ/LDmqq5bK9VNANZd+s 5Bv/LNRTDaSVhS6cTrW/YVyyMABkP4IqzfJraJzxUzQgYREEPdhMOLV7VsjaG4xm6flK O1LbBk4DGuFEMFzlqru7LzCIfvfCJw5Sf7IxxUOuA2A1ukhkQNtODC7GK4FJ3Ei0qNG2 fewGakFqr1vkSi2B7jIGEenqrICWcDmYozv+G3xm9HyfgjX4dRUu901g0ZFT2BUfQukr TPag== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date; bh=WdUkk7yGHQTnyhcNnJU1k388XLuhNOGvfweCAo6fMwc=; b=yBcKdKWG3kuR/zVAb6gpy2B9lvGD3zfbMCjXDfTqFBGXrCA5F18hfvTiQsHPnSYFfz fwjbjdgugt5wEjmBu5XDl7qsnzdW5ISOkWMUkAwMu4X5HRgQxltCiYp418KPK1WNLKes 85CX4d+slWHkevYpO1mKfd7PGqfHbhBZ4ZiVsh4CJhg340lnqjH54+IiG3F/RYUEW3v7 6e5ujaMxq89Dxjs2U3rGjPEKUskaBpUbFgH9e5efs2Zj8cGdW6Qc1JvdnjY46ua97AEH GOf6tbJQRuWAfUn1OlmRvC1G+NMdvCIlRYXmGsjuiEvYEdcklT/xGJVayWi2MSOKbsIT lqEQ== X-Gm-Message-State: ACrzQf1PJbT0nKFPl7WcWKD+V3VunDrIK3vq85L+kwEbS2O3iq9aFZaE iAsdx49vS0ytmfHD+SBx5kS3/g== X-Google-Smtp-Source: AMsMyM6eTy9aLeRLLZfdd4mdrF4tOggHU+zSg3FhAvy4BMGppFAdGafMSo4oN8UwzI1bejZNfSFlOQ== X-Received: by 2002:a05:6512:3da9:b0:49f:1742:c692 with SMTP id k41-20020a0565123da900b0049f1742c692mr6498107lfv.313.1663581659821; Mon, 19 Sep 2022 03:00:59 -0700 (PDT) Received: from [192.168.0.21] (78-11-189-27.static.ip.netia.com.pl. [78.11.189.27]) by smtp.gmail.com with ESMTPSA id be19-20020a056512251300b0049f53d53235sm1952699lfb.50.2022.09.19.03.00.58 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 19 Sep 2022 03:00:59 -0700 (PDT) Message-ID: <7a24c242-0fc8-ded1-37c9-ec279996a4c8@linaro.org> Date: Mon, 19 Sep 2022 12:00:58 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.13.0 Subject: Re: [PATCH] media: dt-bindings: i2c: ovti,ov5640: Drop ref to video-interface-devices.yaml Content-Language: en-US To: "Lad, Prabhakar" Cc: Laurent Pinchart , Mauro Carvalho Chehab , Rob Herring , Krzysztof Kozlowski , Maxime Ripard , Steve Longerbeam , Sakari Ailus , Hans Verkuil , linux-media@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Lad Prabhakar References: <20220916133521.73183-1-prabhakar.mahadev-lad.rj@bp.renesas.com> From: Krzysztof Kozlowski In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 19/09/2022 11:35, Lad, Prabhakar wrote: >>>> The rotation property listed in this binding uses the definition from >>>> video-interface-devices.yaml. I don't think just dropping this is the >>>> right solution. Changing additionaProperties to unevaluatedProperties >>>> seems a better option. >>>> >>> Agreed, I missed rotation was used from video-interface-devices.yaml. >>> Agreed the changing additionaProperties to unevaluatedProperties seems >>> a better option. >> >> The meaning of unevaluatedProperties:false would be here - accept other >> properties (not mentioned here explicitly) from referenced schema. If >> this is your actual intention for this binding, it makes sense. But if >> the intention in this binding was to disallow these other properties, >> then it would be wrong to change to unevaluatedProperties. >> > Thank you for the clarification. The intention is to disallow the property. Which property? Can you be specific? Best regards, Krzysztof