From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7324B26E142 for ; Mon, 27 Apr 2026 14:25:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777299912; cv=none; b=LAwQR6/THe5xvFj/jO6bAbVcDJK2SHqIJL64bkS523DcVTH0sIvhvHSJ1jmijb3w9qfIVJmW3/joEUKAs9s3ZkYPHDkVJThrSgZIsCihVSZiGyxW/sJGDnprDn5oAHXv+1c+4gfL5i0PHUvIRlf2yARJqhW9KoE7J3E9Qg+5J8w= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777299912; c=relaxed/simple; bh=k6bh0Vw/IhCgq//XAl9md9ddxhBLBXBMxxj8buXykF4=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=L2aNVY3Ad8I7dLMHWylgNHNPqM+O/RTQ93sdPxPT1l042FusoBkGwZO7KA4PFavRcnpROUdPa3cje2FGEhMZGRIGvwb2CxbSsFS3V06SarEZJSSb8OMfb+mUP91oCTjf09yaa54GuBoq5CCVSiYCFJrkgqL+89EN5/93sUKB9mg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=dk+PceQA; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=XOHRJ1Fc; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="dk+PceQA"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="XOHRJ1Fc" Received: from pps.filterd (m0279869.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 63RC62Jd2007380 for ; Mon, 27 Apr 2026 14:25:09 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= IReQnGnIlvbqQm1h5A39po5dJakAPAgrvEnFlMBSbuk=; b=dk+PceQA+hQ1M5Aw MTce5JjUYzrJXb9VLM+jFQiVqMdyZ4y5+zPRT0tO33SAaF0i2cA+v2FtLzvAkjk8 Yc+u2ivTO/v3Y89nAS2o2E2crpvydz3+yhMF0Kwem+sZqoTaKlEJwabLDe1dhyEO wkSaN6HmyZB3yXIOqYpP8MPk4DIOyH3Ku+Nk1q5ozImQg3b/36PTkIR0NpXqDg5B T1MO+OW5eDxWNSngx+h67AnwJitGm3IJymZnDkEMZ7Ohl1DTv8CO7huaEelmCnvo pcwqTKSqCGvzNIPsB91vktbM9HTnQBDio6ZNzjlwEoBchJZ6I5hWng6trkbH8+7J 5InTJg== Received: from mail-ua1-f72.google.com (mail-ua1-f72.google.com [209.85.222.72]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4dt7gkgfrm-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 27 Apr 2026 14:25:09 +0000 (GMT) Received: by mail-ua1-f72.google.com with SMTP id a1e0cc1a2514c-9569deb349aso472233241.3 for ; Mon, 27 Apr 2026 07:25:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1777299909; x=1777904709; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=IReQnGnIlvbqQm1h5A39po5dJakAPAgrvEnFlMBSbuk=; b=XOHRJ1Fc7I9wwXwH+4+yknKKvLgFonnhdXPOj9r4i/v9/MkIRfp7oe6XW7qg+pN8K9 x/gT2LlKq16jj1mzbDsFMkdn95ku+IUIOxmPprUHCDeh+92NAeLB6MzSPz0FiymF6NIu ZGNXA1Cp7zoVc8R5QM6XZdnbvA/IctPuCM/GH3l8EvxXLyhJSN/FF0F7zLXxNPvF4f7X ngYySfCZTu6K+0EQzmtqQ+ZTKlWQpbnUqm/P7UYCJ1wUn8ncRat9sX/efCVTWEtLvRbb TzUsobIfucwH2G3s9SrHv13s1KAHpayDPJy4OYnC+rdtREvdq5N/B7mBYsBQZ5yfImcF LFzw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1777299909; x=1777904709; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=IReQnGnIlvbqQm1h5A39po5dJakAPAgrvEnFlMBSbuk=; b=UC20YiEECd2No92g8kmXN5OBOnNtpnoueIHVVnQxFwkbbPPMSChh/oCfnpy6seOGQk Cf+yJ43fDsY8EOHxSGQw+WldQV5hbZ2DNRP47vMquvB+BZikLDqRm1nEEJnHILBwKOPc 26y//TAr1KAXxansTSlvoADf6cie5LUgzEZjrmRgppDMEukMrOKv8j2vO9QKB/0rWy0J JF7iHXDd3m3/udtW4UJ8F3wK8OeHmGlf7m1cbiEX6yOxTWE/+inAK89fCkB88JabMkC1 s/p5okYPBqfU1+Zpy8BCMF/2gVMUQmJEAzkoKi/TJCReZLgpYoyVunnoTDHWDTREl+FJ Jsfw== X-Forwarded-Encrypted: i=1; AFNElJ/g8702ArPUKILCsBEP0ZCjS/tEME6WXncEbecpnaMQAmzr69r2ScbxaZkENYaymMzKs032e3rK8INm@vger.kernel.org X-Gm-Message-State: AOJu0YzrFS4dMi9MQ6YgEzaftU15yYsPdTdvlw6m2CkN1tmopmZyPBSi f7seFbD7F+Rnh4kKfeATAmd1jDyIeHDBGcO228eAMVFOrf4o7c3r5LcRJ7V3RUdqWuVYLGE45ke g986aFpx85/kmwRnfuiaC2TbA6lckJcFgYzUYsnzMuLY+2pknElVnlFd/+ZPHKSyP X-Gm-Gg: AeBDievLxVJC5xg5SQjEuIRDnxOs+n+R7Za66WX7lfIofhyUmZJwuBwn88pgU+8YWRd 2JuGcubYDqi2BVlkVM1IMnIceuf1ZdDd1nCZ8ncK1FW8At8YHWbSM7wcg8tiS6KgogqIQH3cwPJ jr3CkpDZuBbBlHhXe/Kil2bNbjE60VrAaxjldw+kP0YfPKiPDj6cEMGrgoaw1vYrIuVNdw7avOC W5Vf6bE2pI6RfINLKsWfeBnJrUHH1627An8E1QT6PTzuyaAcn74Q+PfZDHVp8isCAfjtS9Uiv46 rfhwvwk4s+1tijpVVTmchC2d4BjjxZE125v6bwRxKcmo0wyhE5xGarDBgt4GOg1+wHqTCCT3+PP XucpldcvmTA2GbWsMTNVK6FZh4iwL1NaWhSxQDtC7VorMiUwPwH8Tl13I83uLtUH+10AjZ5zkya YPLaWUJub7MalG7A== X-Received: by 2002:a05:6102:3708:b0:611:7722:a6a7 with SMTP id ada2fe7eead31-616f8072a0dmr8841430137.8.1777299908595; Mon, 27 Apr 2026 07:25:08 -0700 (PDT) X-Received: by 2002:a05:6102:3708:b0:611:7722:a6a7 with SMTP id ada2fe7eead31-616f8072a0dmr8841422137.8.1777299908007; Mon, 27 Apr 2026 07:25:08 -0700 (PDT) Received: from [192.168.119.254] (078088045245.garwolin.vectranet.pl. [78.88.45.245]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-672c4d4590asm6947034a12.19.2026.04.27.07.25.05 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 27 Apr 2026 07:25:07 -0700 (PDT) Message-ID: <7a39b2e4-d2b4-486d-a012-706f9ef86b07@oss.qualcomm.com> Date: Mon, 27 Apr 2026 16:25:04 +0200 Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] arm64: dts: qcom: monaco-pmics: Add PON power key and reset inputs To: Rakesh Kota Cc: Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Conor Dooley , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, kamal.wadhwa@oss.qualcomm.com References: <20260122-add_pwrkey_and_resin-v1-1-a9fe87537816@oss.qualcomm.com> <0b4ac3c1-11b3-4991-83c2-0c39a81baa8f@oss.qualcomm.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-GUID: AzMv9Yqg6IQ4Y0nL5MNnj78SpSzETTjC X-Proofpoint-ORIG-GUID: AzMv9Yqg6IQ4Y0nL5MNnj78SpSzETTjC X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNDI3MDE1MiBTYWx0ZWRfX/QuX+xFpgN1s MIoUg7sJ3w9ganSfbYI2ktjmhHbYtq4feus559VbMwD48j0UoIpbg7gdEV54DB8k8EZq/MKI915 KTuB4eQZU+CyKhQL/Wp4ODlLz9xLtvOBQe20to1VfZ7QvTNj4Ma2O+x7ogHVSkfY65Bp9aoNzlg 8SJL4Vwwjon1ra/yy5GeqWFw3rjzNv/HOrgRYf/nBPho25by3QJGdIa491/gxHTZ1cprfk2OSgP dfZJs6iqIBE3om+Vrvw2ZYgGS4dOorCCrOdCUAd9a1Z+N0BFD28Eu0YUzUTiupZP9Tm+7i4BQV3 NqAogk3QOnEG0Tq1AXHbk4CoLmRqN9vS3cPX+VBYH4UqYqI1ogQdvb69EMPIbzBI01GvIsP32TJ +wz8WYmf61ZwzK34L5ro9k0esz7yeSjb+eavr5/slLQl5tMARu19L+1B/5XvxbpaXEJJFspZbDd +dQ0vFnmPG1JOa3lIbQ== X-Authority-Analysis: v=2.4 cv=bJsm5v+Z c=1 sm=1 tr=0 ts=69ef71c5 cx=c_pps a=ULNsgckmlI/WJG3HAyAuOQ==:117 a=FpWmc02/iXfjRdCD7H54yg==:17 a=IkcTkHD0fZMA:10 a=A5OVakUREuEA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=_glEPmIy2e8OvE2BGh3C:22 a=VwQbUJbxAAAA:8 a=EUspDBNiAAAA:8 a=6bjU-TzPh-P_-KBABl0A:9 a=QEXdDO2ut3YA:10 a=1WsBpfsz9X-RYQiigVTh:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-04-27_04,2026-04-21_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 impostorscore=0 adultscore=0 suspectscore=0 malwarescore=0 spamscore=0 bulkscore=0 lowpriorityscore=0 phishscore=0 clxscore=1015 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2604200000 definitions=main-2604270152 On 4/15/26 12:24 PM, Rakesh Kota wrote: > On Fri, Jan 30, 2026 at 12:18:53PM +0100, Konrad Dybcio wrote: >> On 1/22/26 7:59 AM, Rakesh Kota wrote: >>> Add the Power On (PON) peripheral with power key and reset input >>> support for the PMM8654AU PMIC on Monaco platforms. >>> >>> Signed-off-by: Rakesh Kota >>> --- >>> arch/arm64/boot/dts/qcom/monaco-pmics.dtsi | 20 ++++++++++++++++++++ >>> 1 file changed, 20 insertions(+) >>> >>> diff --git a/arch/arm64/boot/dts/qcom/monaco-pmics.dtsi b/arch/arm64/boot/dts/qcom/monaco-pmics.dtsi >>> index e990d7367719beaa9e0cea87d9c183ae18c3ebc8..051407cd83eef8eace8521084b1ad012a5192ace 100644 >>> --- a/arch/arm64/boot/dts/qcom/monaco-pmics.dtsi >>> +++ b/arch/arm64/boot/dts/qcom/monaco-pmics.dtsi >>> @@ -13,6 +13,26 @@ pmm8620au_0: pmic@0 { >>> #address-cells = <1>; >>> #size-cells = <0>; >>> >>> + pmm8654au_0_pon: pon@1200 { >>> + compatible = "qcom,pmk8350-pon"; >> >> I see pmm8655x has some slight changes vs pmk8350 (more configs but >> generally backwards compatible if we don't use them), let's add a >> separate compatible in bindings so that we can maybe handle these >> differences down the line: >> >> diff --git a/Documentation/devicetree/bindings/power/reset/qcom,pon.yaml b/Documentation/devicetree/bindings/power/reset/qcom,pon.yaml >> index 979a377cb4ff..14b85b0d97da 100644 >> --- a/Documentation/devicetree/bindings/power/reset/qcom,pon.yaml >> +++ b/Documentation/devicetree/bindings/power/reset/qcom,pon.yaml >> @@ -17,12 +17,16 @@ description: | >> >> properties: >> compatible: >> - enum: >> - - qcom,pm8916-pon >> - - qcom,pm8941-pon >> - - qcom,pms405-pon >> - - qcom,pm8998-pon >> - - qcom,pmk8350-pon >> + oneOf: >> + - enum: >> + - qcom,pm8916-pon >> + - qcom,pm8941-pon >> + - qcom,pms405-pon >> + - qcom,pm8998-pon >> + - qcom,pmk8350-pon >> + - items: >> + - const: qcom,pmm8654au-pon >> + - const: qcom,pmk8350-pon >> > > Hi Konrad, > > Based on the below discussion: > https://lore.kernel.org/all/872faa80-d323-4625-ab8f-50ab2e0e8e0f@kernel.org/ > > I understand that introducing new compatibles without a corresponding driver > change is not acceptable per upstream community guidelines. As Krzysztof pointed out, > neew compatibles must be accompanied by the necessary driver support. > > so,shall we use the old compatible in the current patch series for now ? > And Resume the patch series at https://lore.kernel.org/linux-arm-msm/9c7521fe-5008-4daa-945b-ce3f5c0f6dc0@kernel.org/ > once the driver changes are ready and upstreamed ? The last piece of feedback seems to be here: https://lore.kernel.org/all/9c7521fe-5008-4daa-945b-ce3f5c0f6dc0@kernel.org/ where I believe the diff you're asked to implement against your patch is: 1. Remove the new if:then: block (since by the presence of "contains:qcom,pmk8350-pon" in the existing one, the PMM8654AU entry (which falls back to it), will be taken into account too, and the "then:" part is identical) 2. In the existing if:pmk8350/then: block, the 'reg' part of "then:" is a repetition of the top-level constraints (i.e. it's a NOP). This is wrong, because PMK8350 clearly has two address spaces. This is further confusing, as the commit that originally introduced this (03fccdc76dce ("dt-bindings: power: reset: qcom-pon: Add new compatible "qcom,pmk8350-pon"")) specifically says "whereas GEN3 peripherals can have two register addresses" - the "can" was probably supposed to be an unconditional statement instead. The action from that is to create a separate, preceding commit, changing minItems:1/maxItems:2 into minItems: 2 for both the reg: and reg-names part 3. Run `make dt_binding_check DT_SCHEMA_FILES="reset/qcom,pon.yaml"` and b4 prep --check before your next submission, and squash any errors that show up Konrad