From: Johan Jonker <jbx6244@gmail.com>
To: Heiko Stuebner <heiko@sntech.de>, Tobias Schramm <t.schramm@manjaro.org>
Cc: Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Andy Yan <andy.yan@rock-chips.com>,
Douglas Anderson <dianders@chromium.org>,
Jagan Teki <jagan@amarulasolutions.com>,
Markus Reichl <m.reichl@fivetechno.de>,
Alexis Ballier <aballier@gentoo.org>,
Matthias Kaehlcke <mka@chromium.org>, Nick Xie <nick@khadas.com>,
Kever Yang <kever.yang@rock-chips.com>,
Vivek Unune <npcomplete13@gmail.com>,
Katsuhiro Suzuki <katsuhiro@katsuster.net>,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org,
Vasily Khoruzhick <anarsoul@gmail.com>,
Emmanuel Vadot <manu@freebsd.org>
Subject: Re: [PATCH v4 2/2] arm64: dts: rockchip: Add initial support for Pinebook Pro
Date: Fri, 6 Mar 2020 08:22:00 +0100 [thread overview]
Message-ID: <7a799284-92ab-ea04-285e-37d655064118@gmail.com> (raw)
In-Reply-To: <6168222.Wuk326WHQK@phil>
Hi,
Missing #address-cells, #size-cells
Can you still fix that?
On 3/6/20 1:23 AM, Heiko Stuebner wrote:
> Am Mittwoch, 4. März 2020, 22:30:23 CET schrieb Tobias Schramm:
>> This commit adds initial dt support for the rk3399 based Pinebook Pro.
>>
>> Signed-off-by: Tobias Schramm <t.schramm@manjaro.org>
>
> applied for 5.7
>
> Thanks
> Heiko
>
>
> +&edp {
> + force-hpd;
> + pinctrl-names = "default";
> + pinctrl-0 = <&edp_hpd>;
> + status = "okay";
> +
> + ports {
#address-cells = <1>;
#size-cells = <0>;
Don't forget that extra empty line here.
> + edp_out: port@1 {
> + reg = <1>;
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + edp_out_panel: endpoint@0 {
> + reg = <0>;
> + remote-endpoint = <&panel_in_edp>;
> + };
> + };
> + };
> +};
next prev parent reply other threads:[~2020-03-06 7:22 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-04 21:30 [PATCH v4 1/2] dt-bindings: Add doc for Pine64 Pinebook Pro Tobias Schramm
2020-03-04 21:30 ` [PATCH v4 2/2] arm64: dts: rockchip: Add initial support for " Tobias Schramm
2020-03-06 0:23 ` Heiko Stuebner
2020-03-06 7:22 ` Johan Jonker [this message]
2020-03-06 9:27 ` Heiko Stübner
2020-03-06 18:58 ` Tobias Schramm
2020-03-06 19:09 ` Heiko Stübner
2020-03-06 0:22 ` [PATCH v4 1/2] dt-bindings: Add doc for Pine64 " Heiko Stuebner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7a799284-92ab-ea04-285e-37d655064118@gmail.com \
--to=jbx6244@gmail.com \
--cc=aballier@gentoo.org \
--cc=anarsoul@gmail.com \
--cc=andy.yan@rock-chips.com \
--cc=devicetree@vger.kernel.org \
--cc=dianders@chromium.org \
--cc=heiko@sntech.de \
--cc=jagan@amarulasolutions.com \
--cc=katsuhiro@katsuster.net \
--cc=kever.yang@rock-chips.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=m.reichl@fivetechno.de \
--cc=manu@freebsd.org \
--cc=mark.rutland@arm.com \
--cc=mka@chromium.org \
--cc=nick@khadas.com \
--cc=npcomplete13@gmail.com \
--cc=robh+dt@kernel.org \
--cc=t.schramm@manjaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).