From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C8DB1C433F5 for ; Wed, 9 Mar 2022 12:07:15 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232343AbiCIMIM (ORCPT ); Wed, 9 Mar 2022 07:08:12 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54518 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232744AbiCIMIF (ORCPT ); Wed, 9 Mar 2022 07:08:05 -0500 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id C638117225D for ; Wed, 9 Mar 2022 04:07:06 -0800 (PST) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 8AAD71688; Wed, 9 Mar 2022 04:07:06 -0800 (PST) Received: from [10.57.41.254] (unknown [10.57.41.254]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 7A75E3FA4D; Wed, 9 Mar 2022 04:07:04 -0800 (PST) Message-ID: <7aa79c15-a758-1e9d-2e53-6dd03d4611b7@arm.com> Date: Wed, 9 Mar 2022 12:06:59 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; rv:91.0) Gecko/20100101 Thunderbird/91.6.2 Subject: Re: [PATCH v7 11/24] dt-bindings: display: rockchip: dw-hdmi: Add additional clock Content-Language: en-GB To: Sascha Hauer , dri-devel@lists.freedesktop.org Cc: linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, devicetree@vger.kernel.org, kernel@pengutronix.de, Andy Yan , Benjamin Gaignard , Michael Riesch , Sandy Huang , =?UTF-8?Q?Heiko_St=c3=bcbner?= , Peter Geis , Rob Herring References: <20220225075150.2729401-1-s.hauer@pengutronix.de> <20220225075150.2729401-12-s.hauer@pengutronix.de> From: Robin Murphy In-Reply-To: <20220225075150.2729401-12-s.hauer@pengutronix.de> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 2022-02-25 07:51, Sascha Hauer wrote: > The rk3568 HDMI has an additional clock that needs to be enabled for the > HDMI controller to work. The purpose of that clock is not clear. It is > named "hclk" in the downstream driver, so use the same name. Further to the clarification of the underlying purpose on the other thread, I suggest we call the new clock "niu" and describe it as something like "Additional clock required to ungate the bus interface on certain SoCs". Cheers, Robin. > Signed-off-by: Sascha Hauer > Acked-by: Rob Herring > --- > > Notes: > Changes since v4: > - Add Robs Ack > > .../bindings/display/rockchip/rockchip,dw-hdmi.yaml | 7 ++++++- > 1 file changed, 6 insertions(+), 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/display/rockchip/rockchip,dw-hdmi.yaml b/Documentation/devicetree/bindings/display/rockchip/rockchip,dw-hdmi.yaml > index 38ebb69830287..67a76f51637a7 100644 > --- a/Documentation/devicetree/bindings/display/rockchip/rockchip,dw-hdmi.yaml > +++ b/Documentation/devicetree/bindings/display/rockchip/rockchip,dw-hdmi.yaml > @@ -44,12 +44,13 @@ properties: > items: > - {} > - {} > - # The next three clocks are all optional, but shall be specified in this > + # The next four clocks are all optional, but shall be specified in this > # order when present. > - description: The HDMI CEC controller main clock > - description: Power for GRF IO > - description: External clock for some HDMI PHY (old clock name, deprecated) > - description: External clock for some HDMI PHY (new name) > + - description: hclk > > clock-names: > minItems: 2 > @@ -61,13 +62,17 @@ properties: > - grf > - vpll > - ref > + - hclk > - enum: > - grf > - vpll > - ref > + - hclk > - enum: > - vpll > - ref > + - hclk > + - const: hclk > > ddc-i2c-bus: > $ref: /schemas/types.yaml#/definitions/phandle