From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E4389C4332F for ; Sun, 20 Nov 2022 10:34:47 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229649AbiKTKeq (ORCPT ); Sun, 20 Nov 2022 05:34:46 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35814 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229642AbiKTKep (ORCPT ); Sun, 20 Nov 2022 05:34:45 -0500 Received: from mail-lf1-x12c.google.com (mail-lf1-x12c.google.com [IPv6:2a00:1450:4864:20::12c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9B7727CB85 for ; Sun, 20 Nov 2022 02:34:44 -0800 (PST) Received: by mail-lf1-x12c.google.com with SMTP id be13so14922637lfb.4 for ; Sun, 20 Nov 2022 02:34:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=8D4BClPP9qrwATF1t4nCunXzUqHb8yDxaV0KlH+7vLs=; b=ngHAa6H5aYEfS3vMjANdUuM9RsJdWy9RmqP1HxGhiDlqZzHX3bMuK5JHG7yjhKHMU9 41+DdKziUR4qZ0Jg2m6OxkucZzaC/z2rTF2766hh1O4sxASm9sHaaZup8FvZVV9IaHdc ObKMgReB3Ym325bcng3X/NNJXvSs4oJz9QymH9VVmZf0CeGfE+CqVop6efX552xJuiNN lV/XAtAsIcsyDwObFzlyrXidYxHA0If1H2ZiPZurHoTek8gXD+7wR2kvRQgb29vRj+jd WCcNeu9OJ7ehepkL3CUw+x+t4Ccka9BkJdI8Q/6HpFA3SohZd6OarmGaUZEnQU8lB4Ez x/gw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=8D4BClPP9qrwATF1t4nCunXzUqHb8yDxaV0KlH+7vLs=; b=cPCwga5p5xVO+pS1ohV6GT0ymxJ3rPs7my+WnnMtsHoYNM8JJlPogKNL9LeE05Zj9g BMJkxmOwS2fT8/h3EohWwKUT635ukCH/OszO9SBudSAR5Rqj0jkTnkP0lJAAJ1OKEspO sQ7cUJO9c9ejvDzY2BgbSxNMmt4bJ0F+4rARGDn1M6QaGlRLssCn7eDV779t6dyD2e+U ps3WrdXkhzC9Ehmmj0bFW/D/yIPbY15dKu4IXDTVlT3zZqVJrVNcTcJvc+Y5hGb78D1o 3ZUNaXW4lUNWPAnCkdzCprkkJQMDZW2cJR6v4RQ7EyGYITxZ4Iy83wapwu2UhMsRfI+Y UJ1Q== X-Gm-Message-State: ANoB5pkazeXwKn6Ba6UlqYG5jF2AbMJQeIzF0+IZkioh1fF6GFUItSnS R7ypJPDVED7KrYSSlRBEIp7wrQ== X-Google-Smtp-Source: AA0mqf7o759OuxPpc1jEao2vB98NHQHMxY3bsLWqPy3t+QLguIdEiBC/oMg307GKo5mtBXonCmHJYA== X-Received: by 2002:a19:ca0b:0:b0:4b1:7972:627a with SMTP id a11-20020a19ca0b000000b004b17972627amr4266924lfg.101.1668940482960; Sun, 20 Nov 2022 02:34:42 -0800 (PST) Received: from [192.168.0.20] (088156142067.dynamic-2-waw-k-3-2-0.vectranet.pl. [88.156.142.67]) by smtp.gmail.com with ESMTPSA id i5-20020a0565123e0500b004978e51b691sm1491759lfv.266.2022.11.20.02.34.41 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 20 Nov 2022 02:34:42 -0800 (PST) Message-ID: <7ab50a13-9711-2d77-ff47-ad4c2d9b4faf@linaro.org> Date: Sun, 20 Nov 2022 11:34:41 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.2 Subject: Re: [PATCH v3 02/14] dt-bindings: media: rkisp1: Add i.MX8MP ISP example Content-Language: en-US To: Laurent Pinchart Cc: Paul Elder , linux-media@vger.kernel.org, Dafna Hirschfeld , Mauro Carvalho Chehab , Rob Herring , Krzysztof Kozlowski , Heiko Stuebner , Helen Koike , linux-rockchip@lists.infradead.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org References: <20221118093931.1284465-1-paul.elder@ideasonboard.com> <20221118093931.1284465-3-paul.elder@ideasonboard.com> From: Krzysztof Kozlowski In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 19/11/2022 17:59, Laurent Pinchart wrote: > Hi Krzysztof, > > On Fri, Nov 18, 2022 at 02:06:14PM +0100, Krzysztof Kozlowski wrote: >> On 18/11/2022 10:39, Paul Elder wrote: >>> From: Laurent Pinchart >>> >>> Add an example to the rockchip-isp1 DT binding that showcases usage of >>> the parallel input of the ISP, connected to the CSI-2 receiver internal >>> to the i.MX8MP. >>> >>> Signed-off-by: Laurent Pinchart >> >> Missing SoB. >> >>> --- >>> .../bindings/media/rockchip-isp1.yaml | 72 +++++++++++++++++++ >>> 1 file changed, 72 insertions(+) >>> >> >> I don't know what do you demonstrate there... usage of endpoints? That's >> the only difference. Such usage is the same everywhere, nothing specific >> to this example. You already have two examples, so I don't think this >> brings anything more. > > The i.MX8MP is the only SoC integrating this ISP (and supported in > mainlineà that has an external CSI-2 receiver, as opposed to using the > CSI-2 receiver from the ISP. This patch this showcases the DT > integration for that use case. If you think it's not worth it, I'm fine > dropping it. The purpose of examples are not to demonstrate the SoC, but only this given binding. > Best regards, Krzysztof