Devicetree
 help / color / mirror / Atom feed
From: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
To: Adam Skladowski <a39.skl@gmail.com>,
	Bjorn Andersson <andersson@kernel.org>,
	Konrad Dybcio <konradybcio@kernel.org>,
	Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>, Kees Cook <kees@kernel.org>,
	Tony Luck <tony.luck@intel.com>,
	"Guilherme G. Piccoli" <gpiccoli@igalia.com>
Cc: linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org, linux-hardening@vger.kernel.org
Subject: Re: [PATCH v2 3/7] arm64: dts: qcom: Add Motorola One
Date: Thu, 20 Aug 2026 17:56:58 +0200	[thread overview]
Message-ID: <7ae2860b-aa9e-49f6-9856-e7e56290e8f6@oss.qualcomm.com> (raw)
In-Reply-To: <4dc461a9-68f8-407d-b458-695ac263ca37@gmail.com>

On 8/20/26 5:24 PM, Adam Skladowski wrote:
> 
> On 8/20/26 12:17, Konrad Dybcio wrote:
>> On 8/20/26 11:42 AM, Adam Skladowski wrote:
>>> Add a devicetree for the Motorola One smartphone, which is based
>>> on the Jacala/MSM8953 SoC.

[...]

>>> +			source-pdos = <PDO_FIXED(5000, 500,
>>> +						 PDO_FIXED_DUAL_ROLE |
>>> +						 PDO_FIXED_DATA_SWAP |
>>> +						 PDO_FIXED_USB_COMM)>;
>>> +			sink-pdos = <PDO_FIXED(5000, 3000,
>>> +					       PDO_FIXED_DUAL_ROLE |
>>> +					       PDO_FIXED_DATA_SWAP |
>>> +					       PDO_FIXED_USB_COMM)>;
>>> +			op-sink-microwatt = <2000000>;
>> This is inconsistent with the sink-PDOs you defined (5 V 3 A vs 2 W)
>>
>> Konrad
> To be honest i don't get what's this about.
> Based on docs it says its minimal W value taken by port
> and based on PMI8950 Charger it should be about 100mA@5V
> while SMB1351 can also take as low as 70mA@5V
> I could see it being higher when port is used to power SBC or something.

Ah sorry, I didn't read the docs and just guessed what this property
did.. 

Konrad

  reply	other threads:[~2026-08-20 15:57 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-20  9:42 [PATCH v2 0/7] arm64: dts: qcom: Add 3 new devices Adam Skladowski
2026-08-20  9:42 ` [PATCH v2 1/7] dt-bindings: vendor-prefixes: Add LeEco Adam Skladowski
2026-08-20  9:42 ` [PATCH v2 2/7] dt-bindings: arm: qcom: Document Motorola Moto One Adam Skladowski
2026-08-20  9:42 ` [PATCH v2 3/7] arm64: dts: qcom: Add Motorola One Adam Skladowski
2026-08-20  9:56   ` sashiko-bot
2026-08-20 10:17   ` Konrad Dybcio
2026-08-20 15:24     ` Adam Skladowski
2026-08-20 15:56       ` Konrad Dybcio [this message]
2026-08-20  9:42 ` [PATCH v2 4/7] dt-bindings: arm: qcom: Document LeEco Le2 Adam Skladowski
2026-08-20  9:42 ` [PATCH v2 5/7] arm64: dts: qcom: Add " Adam Skladowski
2026-08-20  9:59   ` sashiko-bot
2026-08-20 10:14   ` Konrad Dybcio
2026-08-20  9:42 ` [PATCH v2 6/7] dt-bindings: arm: qcom: Document Xiaomi Redmi 9T Adam Skladowski
2026-08-20  9:42 ` [PATCH v2 7/7] arm64: dts: qcom: Add " Adam Skladowski
2026-08-20  9:53   ` sashiko-bot
2026-08-20 10:14   ` Konrad Dybcio

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7ae2860b-aa9e-49f6-9856-e7e56290e8f6@oss.qualcomm.com \
    --to=konrad.dybcio@oss.qualcomm.com \
    --cc=a39.skl@gmail.com \
    --cc=andersson@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=gpiccoli@igalia.com \
    --cc=kees@kernel.org \
    --cc=konradybcio@kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-hardening@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=robh@kernel.org \
    --cc=tony.luck@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox