From: Dinh Nguyen <dinguyen@kernel.org>
To: Krzysztof Kozlowski <krzk@kernel.org>
Cc: bp@alien8.de, tony.luck@intel.com, rounakdas2025@gmail.com,
niravkumar.l.rabara@altera.com, robh@kernel.org,
krzk+dt@kernel.org, conor+dt@kernel.org,
linux-edac@vger.kernel.org, linux-kernel@vger.kernel.org,
devicetree@vger.kernel.org
Subject: Re: [PATCHv3 2/4] dt-bindings: edac: altera: agilex5: document new edac support
Date: Mon, 16 Nov 2026 08:50:29 -0600 [thread overview]
Message-ID: <7af64754-c1c0-4a5d-abb6-155013514bcc@kernel.org> (raw)
In-Reply-To: <cdde4ee5-930c-4982-ac79-ac52570c37e9@kernel.org>
On 11/13/26 08:57, Krzysztof Kozlowski wrote:
> On 13/11/2026 14:29, Dinh Nguyen wrote:
>> Hi Krzysztof,
>>
>> On 11/13/26 02:18, Krzysztof Kozlowski wrote:
>>> On Thu, Nov 12, 2026 at 03:53:40PM -0600, Dinh Nguyen wrote:
>>>> + - if:
>>>> + properties:
>>>> + compatible:
>>>> + contains:
>>>> + const: altr,socfpga-agilex5-ecc-manager
>>>> + then:
>>>> + properties:
>>>> + interrupts:
>>>> + minItems: 1
>>>> + maxItems: 7
>>>
>>> Why is this flexible? Wasn't before and changelog explains nothing.
>>>
>> Sorry, but I'm having difficulty understanding your comment here.
>> Doesn't the minItems as 1 specify that the
>> "altr,socfpga-agilex5-ecc-manager" must have at least 1 interrupts
>> specified, and up to 7?
>>
>> My changelog also specifies "up to 7 named interrupts".
>
> So is my question: why is this number flexible?
>
The driver was treating the 6 other interrupts as optional, but thanks
to your question, I went back and looked at the documentation. I am now
sure that these 7 interrupts are not optional and are required.
Appropriate changes will be made in v4.
Dinh
next prev parent reply other threads:[~2026-11-16 14:50 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-12 21:53 [PATCHv3 1/4] EDAC/altera: use flag to differentiate 64-bit platforms Dinh Nguyen
2026-11-12 21:53 ` [PATCHv3 2/4] dt-bindings: edac: altera: agilex5: document new edac support Dinh Nguyen
2026-11-12 22:01 ` sashiko-bot
2026-11-13 8:18 ` Krzysztof Kozlowski
2026-11-13 13:29 ` Dinh Nguyen
2026-11-13 14:57 ` Krzysztof Kozlowski
2026-11-16 14:50 ` Dinh Nguyen [this message]
2026-11-12 21:53 ` [PATCHv3 3/4] EDAC/altera: Add support for Agilex5 ECC manager Dinh Nguyen
2026-11-12 21:53 ` [PATCHv3 4/4] arm64: dts: socfpga: agilex5: add support for the " Dinh Nguyen
2026-11-12 22:11 ` sashiko-bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7af64754-c1c0-4a5d-abb6-155013514bcc@kernel.org \
--to=dinguyen@kernel.org \
--cc=bp@alien8.de \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzk+dt@kernel.org \
--cc=krzk@kernel.org \
--cc=linux-edac@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=niravkumar.l.rabara@altera.com \
--cc=robh@kernel.org \
--cc=rounakdas2025@gmail.com \
--cc=tony.luck@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox