From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ed1-f52.google.com (mail-ed1-f52.google.com [209.85.208.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7514A13FFB for ; Mon, 8 Jan 2024 09:06:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="mgHDyBS3" Received: by mail-ed1-f52.google.com with SMTP id 4fb4d7f45d1cf-555bd21f9fdso1689623a12.0 for ; Mon, 08 Jan 2024 01:06:37 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1704704796; x=1705309596; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:autocrypt:from:references:cc :to:content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=8MhYryk2qySQqP7ex6RCup+lRXCBNlYESjAZjDRfSeI=; b=mgHDyBS3ZBtkKBX1HDT0h5XeT+nAFo0s+jk2FjnzIIL+qqFEgfG2+ivcUc3JwDrJXI gEP4oOnzrRdxydoO6nngmR3qMdv7nOgIN5B/WMAcbNMCl4MUKt59pDjHhXiCwX5EFcdv 0kmAMW4Vpt8gZpPOF9HTxmrfArhVxaKzgJXbNJ3rshbCs6/Qj/dD0H76/pZgAR4elfgq /Pn/dsQ4memGGv/g3PL0VZ0R+ZC13+9qeXZhReRFx7/ZQNtdbi292zDsxFemOcNIsGdf eN85zdVJWkPq8nwN8cR1+tGoPV24fTLrnqIPCoeWSjELK+OqUlQVYULpAoalYsw5sH8Z eYPg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1704704796; x=1705309596; h=content-transfer-encoding:in-reply-to:autocrypt:from:references:cc :to:content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=8MhYryk2qySQqP7ex6RCup+lRXCBNlYESjAZjDRfSeI=; b=Z4F10JrcUYoRUHD/d+0Nj57Jsq14xfEwWzFW0FaJNeBEqpwkc6nQs5OulzY7zwZOrX brmB9NgMQHB9JhPyTR3Xnmf7Vf/TiaAIsRXox6KiCb+8yXDGKVOyqh3vegm+w33W4c3g 6ZoFKN5zVCjYdAnCSMNdEIM2R2f5cwWWCHe47O2BERXh5Sjkkqsh7RhztIaaLx/+Lqvc OnDNZl3LFP3gIuuzd43KjgHP20g3W5Oc+5RHXlJ7U14+oihqDMEUmCSmcO7LCdlt26gM TnKo3fIGBTGGNAtnhnpnxJuVzKpSIrh2F6HDjU8W0kjHgYzpZNsvmoZgGvOp8eXcZLFo JS1Q== X-Gm-Message-State: AOJu0YysnBxBzWrZ1EseUgbUijSdRnKeh5afbpaGIErv/T0odo4m3QFf 231+j1w+rPwiD18z71dePAYhHVpqne8ofg== X-Google-Smtp-Source: AGHT+IFoqVljZ0VxwInk7EYTS6yVo5fykVZqDgg7yXq5N1EyKu+ES8f0Lg0YjosI8AtBlbtSXopqsA== X-Received: by 2002:a50:d7d7:0:b0:553:2b04:14a2 with SMTP id m23-20020a50d7d7000000b005532b0414a2mr1931215edj.14.1704704795757; Mon, 08 Jan 2024 01:06:35 -0800 (PST) Received: from [192.168.1.20] ([178.197.223.112]) by smtp.gmail.com with ESMTPSA id en23-20020a056402529700b00557535489adsm2767091edb.37.2024.01.08.01.06.34 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 08 Jan 2024 01:06:35 -0800 (PST) Message-ID: <7af6c688-3d3e-4cd5-bbd6-4ca323d7edde@linaro.org> Date: Mon, 8 Jan 2024 10:06:33 +0100 Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v5 0/1] dt-bindings: riscv: sophgo: add RTC for CV1800 Content-Language: en-US To: Jingbao Qiu Cc: a.zummo@towertech.it, alexandre.belloni@bootlin.com, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org, paul.walmsley@sifive.com, palmer@dabbelt.com, aou@eecs.berkeley.edu, linux-rtc@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20240108072253.30183-1-qiujingbao.dlmu@gmail.com> <93695e92-233d-460c-a6bd-882b30f1dea8@linaro.org> From: Krzysztof Kozlowski Autocrypt: addr=krzysztof.kozlowski@linaro.org; keydata= xsFNBFVDQq4BEAC6KeLOfFsAvFMBsrCrJ2bCalhPv5+KQF2PS2+iwZI8BpRZoV+Bd5kWvN79 cFgcqTTuNHjAvxtUG8pQgGTHAObYs6xeYJtjUH0ZX6ndJ33FJYf5V3yXqqjcZ30FgHzJCFUu JMp7PSyMPzpUXfU12yfcRYVEMQrmplNZssmYhiTeVicuOOypWugZKVLGNm0IweVCaZ/DJDIH gNbpvVwjcKYrx85m9cBVEBUGaQP6AT7qlVCkrf50v8bofSIyVa2xmubbAwwFA1oxoOusjPIE J3iadrwpFvsZjF5uHAKS+7wHLoW9hVzOnLbX6ajk5Hf8Pb1m+VH/E8bPBNNYKkfTtypTDUCj NYcd27tjnXfG+SDs/EXNUAIRefCyvaRG7oRYF3Ec+2RgQDRnmmjCjoQNbFrJvJkFHlPeHaeS BosGY+XWKydnmsfY7SSnjAzLUGAFhLd/XDVpb1Een2XucPpKvt9ORF+48gy12FA5GduRLhQU vK4tU7ojoem/G23PcowM1CwPurC8sAVsQb9KmwTGh7rVz3ks3w/zfGBy3+WmLg++C2Wct6nM Pd8/6CBVjEWqD06/RjI2AnjIq5fSEH/BIfXXfC68nMp9BZoy3So4ZsbOlBmtAPvMYX6U8VwD TNeBxJu5Ex0Izf1NV9CzC3nNaFUYOY8KfN01X5SExAoVTr09ewARAQABzTRLcnp5c3p0b2Yg S296bG93c2tpIDxrcnp5c3p0b2Yua296bG93c2tpQGxpbmFyby5vcmc+wsGUBBMBCgA+FiEE m9B+DgxR+NWWd7dUG5NDfTtBYpsFAmI+BxMCGwMFCRRfreEFCwkIBwIGFQoJCAsCBBYCAwEC HgECF4AACgkQG5NDfTtBYptgbhAAjAGunRoOTduBeC7V6GGOQMYIT5n3OuDSzG1oZyM4kyvO XeodvvYv49/ng473E8ZFhXfrre+c1olbr1A8pnz9vKVQs9JGVa6wwr/6ddH7/yvcaCQnHRPK mnXyP2BViBlyDWQ71UC3N12YCoHE2cVmfrn4JeyK/gHCvcW3hUW4i5rMd5M5WZAeiJj3rvYh v8WMKDJOtZFXxwaYGbvFJNDdvdTHc2x2fGaWwmXMJn2xs1ZyFAeHQvrp49mS6PBQZzcx0XL5 cU9ZjhzOZDn6Apv45/C/lUJvPc3lo/pr5cmlOvPq1AsP6/xRXsEFX/SdvdxJ8w9KtGaxdJuf rpzLQ8Ht+H0lY2On1duYhmro8WglOypHy+TusYrDEry2qDNlc/bApQKtd9uqyDZ+rx8bGxyY qBP6bvsQx5YACI4p8R0J43tSqWwJTP/R5oPRQW2O1Ye1DEcdeyzZfifrQz58aoZrVQq+innR aDwu8qDB5UgmMQ7cjDSeAQABdghq7pqrA4P8lkA7qTG+aw8Z21OoAyZdUNm8NWJoQy8m4nUP gmeeQPRc0vjp5JkYPgTqwf08cluqO6vQuYL2YmwVBIbO7cE7LNGkPDA3RYMu+zPY9UUi/ln5 dcKuEStFZ5eqVyqVoZ9eu3RTCGIXAHe1NcfcMT9HT0DPp3+ieTxFx6RjY3kYTGLOwU0EVUNc NAEQAM2StBhJERQvgPcbCzjokShn0cRA4q2SvCOvOXD+0KapXMRFE+/PZeDyfv4dEKuCqeh0 hihSHlaxTzg3TcqUu54w2xYskG8Fq5tg3gm4kh1Gvh1LijIXX99ABA8eHxOGmLPRIBkXHqJY oHtCvPc6sYKNM9xbp6I4yF56xVLmHGJ61KaWKf5KKWYgA9kfHufbja7qR0c6H79LIsiYqf92 H1HNq1WlQpu/fh4/XAAaV1axHFt/dY/2kU05tLMj8GjeQDz1fHas7augL4argt4e+jum3Nwt yupodQBxncKAUbzwKcDrPqUFmfRbJ7ARw8491xQHZDsP82JRj4cOJX32sBg8nO2N5OsFJOcd 5IE9v6qfllkZDAh1Rb1h6DFYq9dcdPAHl4zOj9EHq99/CpyccOh7SrtWDNFFknCmLpowhct9 5ZnlavBrDbOV0W47gO33WkXMFI4il4y1+Bv89979rVYn8aBohEgET41SpyQz7fMkcaZU+ok/ +HYjC/qfDxT7tjKXqBQEscVODaFicsUkjheOD4BfWEcVUqa+XdUEciwG/SgNyxBZepj41oVq FPSVE+Ni2tNrW/e16b8mgXNngHSnbsr6pAIXZH3qFW+4TKPMGZ2rZ6zITrMip+12jgw4mGjy 5y06JZvA02rZT2k9aa7i9dUUFggaanI09jNGbRA/ABEBAAHCwXwEGAEKACYCGwwWIQSb0H4O DFH41ZZ3t1Qbk0N9O0FimwUCYDzvagUJFF+UtgAKCRAbk0N9O0Fim9JzD/0auoGtUu4mgnna oEEpQEOjgT7l9TVuO3Qa/SeH+E0m55y5Fjpp6ZToc481za3xAcxK/BtIX5Wn1mQ6+szfrJQ6 59y2io437BeuWIRjQniSxHz1kgtFECiV30yHRgOoQlzUea7FgsnuWdstgfWi6LxstswEzxLZ Sj1EqpXYZE4uLjh6dW292sO+j4LEqPYr53hyV4I2LPmptPE9Rb9yCTAbSUlzgjiyyjuXhcwM qf3lzsm02y7Ooq+ERVKiJzlvLd9tSe4jRx6Z6LMXhB21fa5DGs/tHAcUF35hSJrvMJzPT/+u /oVmYDFZkbLlqs2XpWaVCo2jv8+iHxZZ9FL7F6AHFzqEFdqGnJQqmEApiRqH6b4jRBOgJ+cY qc+rJggwMQcJL9F+oDm3wX47nr6jIsEB5ZftdybIzpMZ5V9v45lUwmdnMrSzZVgC4jRGXzsU EViBQt2CopXtHtYfPAO5nAkIvKSNp3jmGxZw4aTc5xoAZBLo0OV+Ezo71pg3AYvq0a3/oGRG KQ06ztUMRrj8eVtpImjsWCd0bDWRaaR4vqhCHvAG9iWXZu4qh3ipie2Y0oSJygcZT7H3UZxq fyYKiqEmRuqsvv6dcbblD8ZLkz1EVZL6djImH5zc5x8qpVxlA0A0i23v5QvN00m6G9NFF0Le D2GYIS41Kv4Isx2dEFh+/Q== In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit On 08/01/2024 10:00, Jingbao Qiu wrote: > On Mon, Jan 8, 2024 at 4:02 PM Krzysztof Kozlowski > wrote: >> >> On 08/01/2024 08:22, Jingbao Qiu wrote: >>> Real Time Clock (RTC) is an independently powered module >>> within the chip, which includes a 32KHz oscillator and >>> a Power On Reset/POR submodule. It can be used for time >>> display and timed alarm generation. >>> >>> Power On Reset/POR submodule only using register resources >>> so it should be empty. The 32KHz oscillator only provides >>> pulses for RTC in hardware. >>> >>> >>> Changes since v4: >>> - remove POR dt-bindings because it empty >>> - remove MFD dt-bindings because SoC does >>> not have MFDs >>> - add syscon attribute to share registers >>> with POR >>> >>> v4: https://lore.kernel.org/all/20231229090643.116575-1-qiujingbao.dlmu@gmail.com/ >>> >>> Changes since v3: >>> - temporarily not submitting RTC driver code >>> waiting for communication with IC designer >> >> Hm, why? >> >> We do not need bindings if nothing matches to them. If this binding is >> for other upstream open-source project, please provide references. >> >> See also: >> https://elixir.bootlin.com/linux/v6.7-rc8/source/Documentation/devicetree/bindings/submitting-patches.rst#L61 >> > > Hi! > > There is a function in the RTC driver code used to calibrate the > clock, which is define in the datasheet. > However, Alexandre Belloni raised concerns that clock calibration > should be done using GPS or similar > methods, rather than using other clock sources. I think what he said > makes sense. So it is necessary > to communicate with IC designers. > > link: https://lore.kernel.org/all/202312271350242a208426@mail.local/ Sure, this I get, but why sending bindings alone? There is no user of them. Best regards, Krzysztof