From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 425A2C47088 for ; Mon, 5 Dec 2022 08:03:45 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231848AbiLEIDn (ORCPT ); Mon, 5 Dec 2022 03:03:43 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55130 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231849AbiLEIDg (ORCPT ); Mon, 5 Dec 2022 03:03:36 -0500 Received: from mail-lf1-x133.google.com (mail-lf1-x133.google.com [IPv6:2a00:1450:4864:20::133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A8A095581 for ; Mon, 5 Dec 2022 00:03:34 -0800 (PST) Received: by mail-lf1-x133.google.com with SMTP id 1so3657700lfz.4 for ; Mon, 05 Dec 2022 00:03:34 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=H+uTtN8xZ5dZQSWV9r1hcnd1qKrZ8UQsR2z3ws2RHkA=; b=qtCmKK6E6PIgMLP7oCS0itWhZU0DwUy3/+Zhj0EnOeAGLNJFnp4XAcUXWeamyoyfEx l1IqmygGR+Uem/VweGGugEbuLSw6KmABGZOQ0puLC8vSZPfC8lGrKYixlqP8PQ2pw+bQ j0n9f2/3ySrOQgavcF22Qs3xTfov+0nVlPDJf9iJ/+1su9YQQ/F73b0dKJuzeyO/z8Ed 64liIYMO2F3L753Ym6QrWBcq0SwUXgPatJCmTdiTSSpCLbfJ/jhK1XruyV4ofAzB9WOb HTPj1IU2w8gaRhiAACPRDX9rG58N6x+Pa77gSVRcHEc/r+K45XW7LotU9mXZBSaOzpl5 DoyA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=H+uTtN8xZ5dZQSWV9r1hcnd1qKrZ8UQsR2z3ws2RHkA=; b=0GOsBC89tWJLxg8qelaoY+lTONqq7uenQK4jB9raeALDRDWRFHev1H/0HpcIp0ID9n vwUwWPZGowdNV/ggJJFB4WCIPH7G8APRrb8d9YwQcTSq1DFGYQ4cp8ykI8Pauw4cz4Ae DqWkSIzTYR2j0RdtA6pykJAYf0oSMRCnBY/oITU8a9CvYRnyUZUWF+L5ojkGVvYKlh+K cvwkWmVXx1AWZlQ76tqwidcOyePJFuD9KS6M/6/CsxQjVH0PUOjymVcJyLaoAHAvkQL/ PGLMBoirm7so16RZ8cabw1hbF0kSetmwdaXRFrlhTkCkBEYWf2jD6WVSsi72461O4PQb 7SdA== X-Gm-Message-State: ANoB5plRAQJewUKpPmFL2b5uI8G0wCru1BwXo2tQAUXG6ijsl8f2RKe1 Bl6aSVqSRpFO3MHuibJyQQaEGw== X-Google-Smtp-Source: AA0mqf5E/SarGgr2D2OXWZ/49zr2poOvPBDCHCLckhu/QV0t+EvkWqhoBZaJJ/UxTIbBIxDCzY/tjQ== X-Received: by 2002:ac2:53a2:0:b0:4b5:29f5:8635 with SMTP id j2-20020ac253a2000000b004b529f58635mr8203988lfh.282.1670227412997; Mon, 05 Dec 2022 00:03:32 -0800 (PST) Received: from [192.168.0.20] (088156142067.dynamic-2-waw-k-3-2-0.vectranet.pl. [88.156.142.67]) by smtp.gmail.com with ESMTPSA id z15-20020a056512370f00b004b4b69af17dsm1623100lfr.214.2022.12.05.00.03.31 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 05 Dec 2022 00:03:32 -0800 (PST) Message-ID: <7b024087-cf20-a14e-2ab1-8bba71493135@linaro.org> Date: Mon, 5 Dec 2022 09:03:31 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.5.1 Subject: Re: [RFC PATCH v1 2/2] usb: host: add xhci-exynos to support Exynos SOCs Content-Language: en-US To: Jung Daehwan Cc: Mathias Nyman , Arnd Bergmann , Greg Kroah-Hartman , Rob Herring , Krzysztof Kozlowski , Alim Akhtar , Mathias Nyman , Linus Walleij , Colin Ian King , Artur Bujdoso , Juergen Gross , Tomer Maimon , "open list:USB SUBSYSTEM" , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , "moderated list:ARM/SAMSUNG S3C, S5P AND EXYNOS ARM ARCHITECTURES" , "open list:ARM/SAMSUNG S3C, S5P AND EXYNOS ARM ARCHITECTURES" , open list , sc.suh@samsung.com, taehyun.cho@samsung.com, jh0801.jung@samsung.com, eomji.oh@samsung.com References: <1669860811-171746-1-git-send-email-dh10.jung@samsung.com> <1669860811-171746-3-git-send-email-dh10.jung@samsung.com> <20221205023413.GD54922@ubuntu> <92df8e1d-eb7b-ec0b-264f-a1a090cececc@linaro.org> <20221205075342.GG54922@ubuntu> From: Krzysztof Kozlowski In-Reply-To: <20221205075342.GG54922@ubuntu> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 05/12/2022 08:53, Jung Daehwan wrote: > On Mon, Dec 05, 2022 at 08:33:39AM +0100, Krzysztof Kozlowski wrote: >> On 05/12/2022 03:34, Jung Daehwan wrote: >> >>>>> Am I missing something here? >>>> >>>> Because it is not a driver for Exynos... it's a driver for wakelocks for >>>> their specific Android use-cases which the manufacturer ships for their >>>> Android devices. Due to Google GKI, they try to squeeze into upstream. >>>> But this is huge misconception what should go to upstream and Samsung >>>> does not want to keep discussing. They just send random patches and >>>> disappear... >>>> >>>> Best regards, >>>> Krzysztof >>>> >>>> >>> >>> No. It's driver for Exynos. Currently It only has wakelocks but I will >>> submit one by one. Please think as the first patch of exynos not >>> squeezed. >> >> That's not how upstream kernel development works... Your code has >> nothing for Exynos. It's Android driver, not Exynos. If you say there is >> something for Exynos it must be visible here. Wakelocks are not relevant >> to Exynos, so after dropping them there would be empty stub in upstream >> kernel which obviously cannot be accepted. >> >> Best regards, >> Krzysztof >> >> > > Well, Exynos only uses wakelocks when I see mainline because it seems no Exynos does not use wakelocks at all. Please explain me for what hardware feature the wakelocks are needed when you do not use Android on Exynos? Stop mixing Exynos with Android. One is hardware, second is operating system. > other driver use it. That's why I thought it could be a exynos specific. > Do you agree that if I put wakelocks into xhci platform driver? It's not related problem. Whether it suits there, I don't know. Best regards, Krzysztof