From: "Nuno Sá" <noname.nuno@gmail.com>
To: "Ceclan, Dumitru" <mitrutzceclan@gmail.com>,
dumitru.ceclan@analog.com, Lars-Peter Clausen <lars@metafoo.de>,
Michael Hennerich <Michael.Hennerich@analog.com>,
Jonathan Cameron <jic23@kernel.org>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>
Cc: linux-iio@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 2/2] iio: adc: ad7173: add support for ad4113
Date: Fri, 09 Aug 2024 16:12:12 +0200 [thread overview]
Message-ID: <7b032190f3009dfac9ef88c972362b9dc0f6ead5.camel@gmail.com> (raw)
In-Reply-To: <39fa2711-7bd6-4c12-a668-9a3af33283d8@gmail.com>
On Fri, 2024-08-09 at 15:32 +0300, Ceclan, Dumitru wrote:
> On 09/08/2024 15:26, Nuno Sá wrote:
> > On Fri, 2024-08-09 at 13:33 +0300, Dumitru Ceclan via B4 Relay wrote:
> > > From: Dumitru Ceclan <dumitru.ceclan@analog.com>
> > >
> > > This commit adds support for the AD4113 ADC.
> > > The AD4113 is a low power, low noise, 16-bit, Σ-Δ analog-to-digital
> > > converter (ADC) that integrates an analog front end (AFE) for four
> > > fully differential or eight single-ended inputs.
> > >
> > > Signed-off-by: Dumitru Ceclan <dumitru.ceclan@analog.com>
> > > ---
> >
> > Any reason to drop my tag :)? There a b4 command that can help you with it.
> >
> > - Nuno Sá
> >
> >
>
> Yes, I added a new field to the device info struct and changed dt parsing
> because I missed in V1 that this model actually has a 16 bit data register.
> I considered that the rb would not apply anymore and it would need a re-review.
>
> Thanks for the b4 suggestion but this was intentional :))
Got it. Next time mention that in the cover...
Reviewed-by: Nuno Sa <nuno.sa@analog.com>
next prev parent reply other threads:[~2024-08-09 14:12 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-09 10:33 [PATCH v2 0/2] Add support for AD4113 Dumitru Ceclan via B4 Relay
2024-08-09 10:33 ` [PATCH v2 1/2] dt-bindings: adc: ad7173: add support for ad4113 Dumitru Ceclan via B4 Relay
2024-08-09 14:21 ` Conor Dooley
2024-08-09 14:32 ` Ceclan, Dumitru
2024-08-09 15:09 ` Conor Dooley
2024-08-17 10:12 ` Jonathan Cameron
2024-08-09 10:33 ` [PATCH v2 2/2] iio: " Dumitru Ceclan via B4 Relay
2024-08-09 12:26 ` Nuno Sá
2024-08-09 12:32 ` Ceclan, Dumitru
2024-08-09 14:12 ` Nuno Sá [this message]
2024-08-09 14:30 ` Christophe JAILLET
2024-08-09 14:40 ` Ceclan, Dumitru
2024-08-09 15:34 ` Christophe JAILLET
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7b032190f3009dfac9ef88c972362b9dc0f6ead5.camel@gmail.com \
--to=noname.nuno@gmail.com \
--cc=Michael.Hennerich@analog.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dumitru.ceclan@analog.com \
--cc=jic23@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mitrutzceclan@gmail.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).