From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ed1-f45.google.com (mail-ed1-f45.google.com [209.85.208.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B850E168A9 for ; Mon, 15 Jan 2024 12:57:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="gt6mzu67" Received: by mail-ed1-f45.google.com with SMTP id 4fb4d7f45d1cf-555bd21f9fdso9707003a12.0 for ; Mon, 15 Jan 2024 04:57:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1705323444; x=1705928244; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:autocrypt:from:references:cc :to:content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=iVzF8C/6HG6CFkGeWOtmqNfxcQ/XO75kr+E1fd0CXSc=; b=gt6mzu67rCZZUTAPSzi2aNE5wShn89/0ybp535Td9M+h6lxIqRHBU+5Wgq97mn8A4+ gZN2Y85SD67cmeG6pbCiAh6i1bFhbeOQIhhvsX4LDwVny03y7xUnzbu3lTM7EXYUoDqn BWQuw8tCs0YY6o+gln82mpsn6Bt8cHWODxgm1P/09F68TAYaqNoHS4UC2RCaRYCAnCZF vRWExHVfuLi4PMafVpOT20yInoKaFgGt+lUXmD3Sr8ar/uFIiSxNT6s9IZAB9EnuBj5S Sb+rfF/Qzazm6XHs488M+CfMqhrbBFnVEs5fecMCe7r+61fLPA4DElBTUn5zhphzWXSx 1Eig== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1705323444; x=1705928244; h=content-transfer-encoding:in-reply-to:autocrypt:from:references:cc :to:content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=iVzF8C/6HG6CFkGeWOtmqNfxcQ/XO75kr+E1fd0CXSc=; b=D/PP2jZyCoIKL1wsl7z52XpHIbaVjv1ev5nS5fM4l5WlCFgUsC5FMqQrE7T7Pstm1x 1h2FnkQoRvGuk0hCLBhYO/jY1uhT7QcP9H2YzEsVGBpvRRpxGhi/A6UGHWtPF+8YVXRU DrzO4xp4DZ8yJoRw1dHrtqafnEgFAovvZDgSNKzqtbnbVGxdTuPETy6mUQoRrSqTguCu ogGJzyisNrTi2K6DQ5BN1DGpMCR9FydHZQ+KcOiWbOluj8vs34oJZuD6UST+KdoPa59x aY+5t9I2FGHPP4XxIOm9fyR7vhRdUJze7fUMJ0GrhWUam1Oc9l7hjkj1jqvvojx3HBbW A8zA== X-Gm-Message-State: AOJu0YzyO+eIQNa0hhZNvor4sQU9vs4tomfMWYe6cLgu3eq6xDl3JgvO 3fnpaagIU4MrH9HpJt3m+eU7bMlf3PV7XQ== X-Google-Smtp-Source: AGHT+IEvbCXbHuEd5QzN4ARJ83ctVC27a0o1jy67k1ZrTNbg+gD4msqicIzEv35JzQ/q0N/Kdteqig== X-Received: by 2002:a05:6402:948:b0:558:30df:b183 with SMTP id h8-20020a056402094800b0055830dfb183mr2439321edz.22.1705323444057; Mon, 15 Jan 2024 04:57:24 -0800 (PST) Received: from [192.168.1.20] ([178.197.215.66]) by smtp.gmail.com with ESMTPSA id q8-20020a056402040800b0055703db2c9fsm5468958edv.1.2024.01.15.04.57.21 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 15 Jan 2024 04:57:23 -0800 (PST) Message-ID: <7b0a4e42-6d34-491a-9ec2-0df61dbe2b19@linaro.org> Date: Mon, 15 Jan 2024 13:57:21 +0100 Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH RFC 2/3] dt-bindings: clock: Document T-Head TH1520 AP clock controller Content-Language: en-US To: Drew Fustini , Jisheng Zhang , Guo Ren , Fu Wei , Michael Turquette , Stephen Boyd , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Yangtao Li Cc: linux-kernel@vger.kernel.org, linux-riscv@lists.infradead.org, linux-clk@vger.kernel.org, devicetree@vger.kernel.org, Emil Renner Berthing , Han Gao , Xi Ruoyao , Robert Nelson , Jason Kridner References: <20240110-clk-th1520-v1-0-8b0682567984@tenstorrent.com> <20240110-clk-th1520-v1-2-8b0682567984@tenstorrent.com> From: Krzysztof Kozlowski Autocrypt: addr=krzysztof.kozlowski@linaro.org; keydata= xsFNBFVDQq4BEAC6KeLOfFsAvFMBsrCrJ2bCalhPv5+KQF2PS2+iwZI8BpRZoV+Bd5kWvN79 cFgcqTTuNHjAvxtUG8pQgGTHAObYs6xeYJtjUH0ZX6ndJ33FJYf5V3yXqqjcZ30FgHzJCFUu JMp7PSyMPzpUXfU12yfcRYVEMQrmplNZssmYhiTeVicuOOypWugZKVLGNm0IweVCaZ/DJDIH gNbpvVwjcKYrx85m9cBVEBUGaQP6AT7qlVCkrf50v8bofSIyVa2xmubbAwwFA1oxoOusjPIE J3iadrwpFvsZjF5uHAKS+7wHLoW9hVzOnLbX6ajk5Hf8Pb1m+VH/E8bPBNNYKkfTtypTDUCj NYcd27tjnXfG+SDs/EXNUAIRefCyvaRG7oRYF3Ec+2RgQDRnmmjCjoQNbFrJvJkFHlPeHaeS BosGY+XWKydnmsfY7SSnjAzLUGAFhLd/XDVpb1Een2XucPpKvt9ORF+48gy12FA5GduRLhQU vK4tU7ojoem/G23PcowM1CwPurC8sAVsQb9KmwTGh7rVz3ks3w/zfGBy3+WmLg++C2Wct6nM Pd8/6CBVjEWqD06/RjI2AnjIq5fSEH/BIfXXfC68nMp9BZoy3So4ZsbOlBmtAPvMYX6U8VwD TNeBxJu5Ex0Izf1NV9CzC3nNaFUYOY8KfN01X5SExAoVTr09ewARAQABzTRLcnp5c3p0b2Yg S296bG93c2tpIDxrcnp5c3p0b2Yua296bG93c2tpQGxpbmFyby5vcmc+wsGUBBMBCgA+FiEE m9B+DgxR+NWWd7dUG5NDfTtBYpsFAmI+BxMCGwMFCRRfreEFCwkIBwIGFQoJCAsCBBYCAwEC HgECF4AACgkQG5NDfTtBYptgbhAAjAGunRoOTduBeC7V6GGOQMYIT5n3OuDSzG1oZyM4kyvO XeodvvYv49/ng473E8ZFhXfrre+c1olbr1A8pnz9vKVQs9JGVa6wwr/6ddH7/yvcaCQnHRPK mnXyP2BViBlyDWQ71UC3N12YCoHE2cVmfrn4JeyK/gHCvcW3hUW4i5rMd5M5WZAeiJj3rvYh v8WMKDJOtZFXxwaYGbvFJNDdvdTHc2x2fGaWwmXMJn2xs1ZyFAeHQvrp49mS6PBQZzcx0XL5 cU9ZjhzOZDn6Apv45/C/lUJvPc3lo/pr5cmlOvPq1AsP6/xRXsEFX/SdvdxJ8w9KtGaxdJuf rpzLQ8Ht+H0lY2On1duYhmro8WglOypHy+TusYrDEry2qDNlc/bApQKtd9uqyDZ+rx8bGxyY qBP6bvsQx5YACI4p8R0J43tSqWwJTP/R5oPRQW2O1Ye1DEcdeyzZfifrQz58aoZrVQq+innR aDwu8qDB5UgmMQ7cjDSeAQABdghq7pqrA4P8lkA7qTG+aw8Z21OoAyZdUNm8NWJoQy8m4nUP gmeeQPRc0vjp5JkYPgTqwf08cluqO6vQuYL2YmwVBIbO7cE7LNGkPDA3RYMu+zPY9UUi/ln5 dcKuEStFZ5eqVyqVoZ9eu3RTCGIXAHe1NcfcMT9HT0DPp3+ieTxFx6RjY3kYTGLOwU0EVUNc NAEQAM2StBhJERQvgPcbCzjokShn0cRA4q2SvCOvOXD+0KapXMRFE+/PZeDyfv4dEKuCqeh0 hihSHlaxTzg3TcqUu54w2xYskG8Fq5tg3gm4kh1Gvh1LijIXX99ABA8eHxOGmLPRIBkXHqJY oHtCvPc6sYKNM9xbp6I4yF56xVLmHGJ61KaWKf5KKWYgA9kfHufbja7qR0c6H79LIsiYqf92 H1HNq1WlQpu/fh4/XAAaV1axHFt/dY/2kU05tLMj8GjeQDz1fHas7augL4argt4e+jum3Nwt yupodQBxncKAUbzwKcDrPqUFmfRbJ7ARw8491xQHZDsP82JRj4cOJX32sBg8nO2N5OsFJOcd 5IE9v6qfllkZDAh1Rb1h6DFYq9dcdPAHl4zOj9EHq99/CpyccOh7SrtWDNFFknCmLpowhct9 5ZnlavBrDbOV0W47gO33WkXMFI4il4y1+Bv89979rVYn8aBohEgET41SpyQz7fMkcaZU+ok/ +HYjC/qfDxT7tjKXqBQEscVODaFicsUkjheOD4BfWEcVUqa+XdUEciwG/SgNyxBZepj41oVq FPSVE+Ni2tNrW/e16b8mgXNngHSnbsr6pAIXZH3qFW+4TKPMGZ2rZ6zITrMip+12jgw4mGjy 5y06JZvA02rZT2k9aa7i9dUUFggaanI09jNGbRA/ABEBAAHCwXwEGAEKACYCGwwWIQSb0H4O DFH41ZZ3t1Qbk0N9O0FimwUCYDzvagUJFF+UtgAKCRAbk0N9O0Fim9JzD/0auoGtUu4mgnna oEEpQEOjgT7l9TVuO3Qa/SeH+E0m55y5Fjpp6ZToc481za3xAcxK/BtIX5Wn1mQ6+szfrJQ6 59y2io437BeuWIRjQniSxHz1kgtFECiV30yHRgOoQlzUea7FgsnuWdstgfWi6LxstswEzxLZ Sj1EqpXYZE4uLjh6dW292sO+j4LEqPYr53hyV4I2LPmptPE9Rb9yCTAbSUlzgjiyyjuXhcwM qf3lzsm02y7Ooq+ERVKiJzlvLd9tSe4jRx6Z6LMXhB21fa5DGs/tHAcUF35hSJrvMJzPT/+u /oVmYDFZkbLlqs2XpWaVCo2jv8+iHxZZ9FL7F6AHFzqEFdqGnJQqmEApiRqH6b4jRBOgJ+cY qc+rJggwMQcJL9F+oDm3wX47nr6jIsEB5ZftdybIzpMZ5V9v45lUwmdnMrSzZVgC4jRGXzsU EViBQt2CopXtHtYfPAO5nAkIvKSNp3jmGxZw4aTc5xoAZBLo0OV+Ezo71pg3AYvq0a3/oGRG KQ06ztUMRrj8eVtpImjsWCd0bDWRaaR4vqhCHvAG9iWXZu4qh3ipie2Y0oSJygcZT7H3UZxq fyYKiqEmRuqsvv6dcbblD8ZLkz1EVZL6djImH5zc5x8qpVxlA0A0i23v5QvN00m6G9NFF0Le D2GYIS41Kv4Isx2dEFh+/Q== In-Reply-To: <20240110-clk-th1520-v1-2-8b0682567984@tenstorrent.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 10/01/2024 17:35, Drew Fustini wrote: > From: Yangtao Li > > Document devicetree bindings for the T-HEAD TH1520 AP sub-system > clock controller. > > Signed-off-by: Yangtao Li > [add link to reference manual] > [fixed dt_binding_check warnings] > [revised commit description] > Signed-off-by: Drew Fustini > --- > .../bindings/clock/thead,th1520-clk-ap.yaml | 65 ++++++++++++++++++++++ > MAINTAINERS | 1 + > 2 files changed, 66 insertions(+) > > diff --git a/Documentation/devicetree/bindings/clock/thead,th1520-clk-ap.yaml b/Documentation/devicetree/bindings/clock/thead,th1520-clk-ap.yaml > new file mode 100644 > index 000000000000..53e7802a4ad7 > --- /dev/null > +++ b/Documentation/devicetree/bindings/clock/thead,th1520-clk-ap.yaml If this is for the header, then two patches should be squashed and you should use the same name for the header. > @@ -0,0 +1,65 @@ > +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/clock/thead,th1520-clk-ap.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: T-HEAD TH1520 AP sub-system clock controller > + > +description: | > + The T-HEAD TH1520 AP sub-system clock controller configures the > + CPU, DPU, GMAC and TEE PLLs. > + > + SoC reference manual > + https://openbeagle.org/beaglev-ahead/beaglev-ahead/-/blob/main/docs/TH1520%20System%20User%20Manual.pdf > + > +maintainers: > + - Jisheng Zhang > + - Wei Fu > + - Yangtao Li > + > +properties: > + compatible: > + const: thead,th1520-clk-ap > + > + reg: > + maxItems: 1 > + > + clocks: > + items: > + - description: main oscillator (24MHz) > + > + clock-names: > + items: > + - const: osc > + > + "#clock-cells": > + const: 1 > + description: > + See for valid indices. > + > +required: > + - compatible > + - reg > + - clocks > + - clock-names > + - "#clock-cells" > + > +additionalProperties: false > + > +examples: > + - | > + #include > + soc { > + Drop redundant blank line. > + #address-cells = <2>; > + #size-cells = <2>; > + > + clk: clock-controller@ffef010000 { Drop unused label. Best regards, Krzysztof