Re: 回复: 回复: [PATCH 2/3] dt-bindings: pinctrl: Add cix,sky1-pinctrl

[Krzysztof Kozlowski <krzk@kernel.org>]

On 28/08/2025 10:58, Gary Yang wrote:
>>>
>>>>> @@ -0,0 +1,592 @@
>>>>> +/* SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) */
>>>>> +/*
>>>>> + * Copyright 2024-2025 Cix Technology Group Co., Ltd.
>>>>> + */
>>>>> +
>>>>> +#ifndef __SKY1_PADS_H
>>>>> +#define __SKY1_PADS_H
>>>>> +
>>>>> +#define CIX_PAD_GPIO001_OFFSET                       0x0
>>>>> +#define CIX_PAD_GPIO002_OFFSET                       0x4
>>>>
>>>> Not bindings. Drop all this.
>>>>
>>>
>>> Do you mean those macros not used need to delete?
>>
>> Really, what is unlcear in "drop all this"? Drop means to remove.
>>
>> You ask for confirmation for some really obvious comments.
>>
>> BTW, if you disagree provide arguments (in terms of bindings) why these are
>> bindings.
> 
> Sorry, make you misunderstand again. I know drop means remove. I want to know whether "all this" mean all macros in the file or not.

All of these defines are not suitable for bindings, because they do not
represent any ABI for Linux.

> These macros will be used by client in the dtsi and dts file. If remove them, maybe add them again when they are used in the further.
> It looks like the file which locate include/dt-bindings/pinctrl/pads-imx8qm.h

Please take the newest contributions as example, not something 10 year old.


Best regards,
Krzysztof