From: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
To: Doug Anderson <dianders@chromium.org>,
Cheng-Yi Chiang <cychiang@chromium.org>
Cc: Taniya Das <tdas@codeaurora.org>,
ALSA Development Mailing List <alsa-devel@alsa-project.org>,
Banajit Goswami <bgoswami@codeaurora.org>,
Takashi Iwai <tiwai@suse.com>,
Rohit kumar <rohitkr@codeaurora.org>,
Patrick Lai <plai@codeaurora.org>,
Ajit Pandey <ajitp@codeaurora.org>,
Tzung-Bi Shih <tzungbi@google.com>,
Andy Gross <agross@kernel.org>, Dylan Reid <dgreid@chromium.org>,
"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
<devicetree@vger.kernel.org>,
tzungbi@chromium.org, Stephan Gerhold <stephan@gerhold.net>,
linux-arm-msm <linux-arm-msm@vger.kernel.org>,
Rob Herring <robh+dt@kernel.org>,
Bjorn Andersson <bjorn.andersson@linaro.org>,
Linux ARM <linux-arm-kernel@lists.infradead.org>,
Liam Girdwood <lgirdwood@gmail.com>,
LKML <linux-kernel@vger.kernel.org>,
Mark Brown <broonie@kernel.org>,
Srini Kandagatla <srinivas.kandagatla@linaro.org>
Subject: Re: [PATCH v6 2/2] ASoC: qcom: sc7180: Add machine driver for sound card registration
Date: Fri, 28 Aug 2020 19:11:51 -0500 [thread overview]
Message-ID: <7b3bb666-c53e-e385-e153-1383f2831c2e@linux.intel.com> (raw)
In-Reply-To: <CAD=FV=XaCt6V+VXfk8T+2mS4d5sKQzMC12AcH9a=MNkgguvmjQ@mail.gmail.com>
>> +config SND_SOC_SC7180
>> + tristate "SoC Machine driver for SC7180 boards"
>> + depends on SND_SOC_QCOM
this depends is probably not necessary, the code is already in an if case.
>> + select SND_SOC_QCOM_COMMON
>> + select SND_SOC_LPASS_SC7180
>> + select SND_SOC_MAX98357A
>> + select SND_SOC_RT5682
>
> I haven't done any significant testing / review of your patch (I'm
> mostly sound-clueless), but I believe that the above needs to be
> "select SND_SOC_RT5682_I2C" atop the current top of the sound tree.
> When I fix that I can confirm that I see the rt5682 probe on
> sc7180-trogdor with Rob Clark's dts patch.
Ack, no one should select SND_SOC_RT5682 directly in machine drivers.
now that the code is split between I2C and SoundWire parts.
There should probably be a depends on I2C as well?
prev parent reply other threads:[~2020-08-29 0:12 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-26 11:04 [PATCH v6 0/2] Add documentation and machine driver for SC7180 sound card Cheng-Yi Chiang
2020-08-26 11:04 ` [PATCH v6 1/2] ASoC: qcom: dt-bindings: Add sc7180 machine bindings Cheng-Yi Chiang
2020-08-28 21:52 ` Rob Herring
2020-08-26 11:04 ` [PATCH v6 2/2] ASoC: qcom: sc7180: Add machine driver for sound card registration Cheng-Yi Chiang
2020-08-26 11:28 ` Cheng-yi Chiang
2020-08-26 14:47 ` Stephan Gerhold
2020-08-27 8:28 ` Cheng-yi Chiang
2020-08-28 23:06 ` Doug Anderson
2020-08-29 0:11 ` Pierre-Louis Bossart [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7b3bb666-c53e-e385-e153-1383f2831c2e@linux.intel.com \
--to=pierre-louis.bossart@linux.intel.com \
--cc=agross@kernel.org \
--cc=ajitp@codeaurora.org \
--cc=alsa-devel@alsa-project.org \
--cc=bgoswami@codeaurora.org \
--cc=bjorn.andersson@linaro.org \
--cc=broonie@kernel.org \
--cc=cychiang@chromium.org \
--cc=devicetree@vger.kernel.org \
--cc=dgreid@chromium.org \
--cc=dianders@chromium.org \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=plai@codeaurora.org \
--cc=robh+dt@kernel.org \
--cc=rohitkr@codeaurora.org \
--cc=srinivas.kandagatla@linaro.org \
--cc=stephan@gerhold.net \
--cc=tdas@codeaurora.org \
--cc=tiwai@suse.com \
--cc=tzungbi@chromium.org \
--cc=tzungbi@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).