From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from codeconstruct.com.au (pi.codeconstruct.com.au [203.29.241.158]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A0D6F2F4323; Fri, 13 Jun 2025 05:29:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=203.29.241.158 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1749792592; cv=none; b=MtA4y9Cuc1EgGAYCtoBJN3uieJMh7c0mjeSDHIKrRrz0l1++VLBJhUucyeF5uUbHQ5484i5wBN+xI+jbegg9GkVAn+n89dA0ZhwT7A7t7c/toz7nSzE6JkrB1gFe9QVubmkpAs8MU3uvihip9rg95U/7fzIO9l9m+IgK4gUcJcs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1749792592; c=relaxed/simple; bh=o+ZXJK5vabVpIbj4thHc31K5dbmHYYZH1fC2DzTsqBo=; h=Message-ID:Subject:From:To:Cc:Date:In-Reply-To:References: Content-Type:MIME-Version; b=W4LFE6Z9z8IlOrhOycnuywSu1i7aHBLY/HmV6jnNZ9wyscVLEZxw1ncwdMyIe9RUadxWebqv95i9d6gUvqQGqB3qXazxSrfn4Fy6V/JhBhddcTq86SIeRDLdTJLFFuPcNTji3Yezm/2KYMTCGJuAWXQeeP2UdK0ljRTWuQHVqeQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=codeconstruct.com.au; spf=pass smtp.mailfrom=codeconstruct.com.au; dkim=pass (2048-bit key) header.d=codeconstruct.com.au header.i=@codeconstruct.com.au header.b=N9MssL99; arc=none smtp.client-ip=203.29.241.158 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=codeconstruct.com.au Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=codeconstruct.com.au Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=codeconstruct.com.au header.i=@codeconstruct.com.au header.b="N9MssL99" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=codeconstruct.com.au; s=2022a; t=1749792588; bh=o+ZXJK5vabVpIbj4thHc31K5dbmHYYZH1fC2DzTsqBo=; h=Subject:From:To:Cc:Date:In-Reply-To:References; b=N9MssL99BFu955VaFR1nkL3xaUvn26A3cCWyDm62uEGpqkx1vySP1F20rcycQXUTW C3h2aiWfBMTAVnAiYTzmm69r/fFhc+oyh6X2lEKQqmCFyyjkIN4vgVde9cWkpwcbTg UtYCrdl/gEYRPNb7mm09wWg1aO56GKqYSi0TWK91uB+DrwzxoMDwm51hOd8aKJoNzL maC+IuhtEB4uQsMHZpx22saMCLYYuyw9aODFECe6Qy534RqU2XS8iZqcxi1CqCCPxT F8cp4Maxs7BCyZOL8TMUkdYFG5bw/hlkF3LR+/u60Y6p5rkfqMvWYcK9KHDRv1JuVB sDfDKwY2bN9ZA== Received: from [192.168.68.112] (unknown [180.150.112.166]) by mail.codeconstruct.com.au (Postfix) with ESMTPSA id BDC42680F3; Fri, 13 Jun 2025 13:29:44 +0800 (AWST) Message-ID: <7b3be5c104b1fe1033570f2f3e2391991b6d9d42.camel@codeconstruct.com.au> Subject: Re: [PATCH v0 0/5] Add initial AST2700 SoC support From: Andrew Jeffery To: Ryan Chen Cc: "Rob Herring (Arm)" , Catalin Marinas , soc@lists.linux.dev, Mo Elbadry , Arnd Bergmann , William Kennington , Taniya Das , linux-kernel@vger.kernel.org, spuranik@nvidia.com, Eric Biggers , Joel Stanley , linux-aspeed@lists.ozlabs.org, Will Deacon , Conor Dooley , Krzysztof Kozlowski , Nishanth Menon , Lad Prabhakar , nfraprado@collabora.com, linux-arm-kernel@lists.infradead.org, Kuninori Morimoto , Rom Lemarchand , devicetree@vger.kernel.org, Geert Uytterhoeven , leohu@nvidia.com, Bjorn Andersson , Yuxiao Zhang , dkodihalli@nvidia.com, wthai@nvidia.com Date: Fri, 13 Jun 2025 14:59:43 +0930 In-Reply-To: <174975871838.2916138.1953670783794758715.robh@kernel.org> References: <20250612100933.3007673-1-ryan_chen@aspeedtech.com> <174975871838.2916138.1953670783794758715.robh@kernel.org> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.46.4-2 Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 On Thu, 2025-06-12 at 15:12 -0500, Rob Herring (Arm) wrote: >=20 > On Thu, 12 Jun 2025 18:09:28 +0800, Ryan Chen wrote: > > This patch series introduces initial support for the Aspeed AST2700 SoC > > and the AST2700 Evaluation Board (EVB) to the Linux kernel. The AST2700 > > is the 7th generation Baseboard Management Controller (BMC) SoC from As= peed, > > featuring improved performance, enhanced security, and expanded I/O > > capabilities compared to previous generations. > >=20 > > The patchset includes the following changes: > > - Device tree bindings for AST2700 boards. > > - Addition of the AST2700 platform to the Kconfig menu. > > - Basic device tree for the AST2700 SoC. > > - Device tree for the AST2700-EVB. > > - Updated defconfig to enable essential options for AST2700. > >=20 > > Ryan Chen (5): > > =C2=A0 dt-bindings: arm: aspeed: Add AST2700 board compatible > > =C2=A0 arm64: Kconfig: Add Aspeed SoC family (ast2700) platform option > > =C2=A0 arm64: dts: aspeed: Add initial AST2700 SoC device tree > > =C2=A0 arm64: dts: aspeed: Add AST2700 EVB device tree > > =C2=A0 arm64: configs: Update defconfig for AST2700 platform support > >=20 > > =C2=A0.../bindings/arm/aspeed/aspeed.yaml=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 |=C2=A0=C2=A0 5 + > > =C2=A0arch/arm64/Kconfig.platforms=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 |=C2=A0= =C2=A0 6 + > > =C2=A0arch/arm64/boot/dts/Makefile=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 |=C2=A0= =C2=A0 1 + > > =C2=A0arch/arm64/boot/dts/aspeed/Makefile=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 |=C2=A0=C2=A0 4 + > > =C2=A0arch/arm64/boot/dts/aspeed/aspeed-g7.dtsi=C2=A0=C2=A0=C2=A0=C2=A0= | 380 ++++++++++++++++++ > > =C2=A0arch/arm64/boot/dts/aspeed/ast2700-evb.dts=C2=A0=C2=A0=C2=A0 |=C2= =A0 54 +++ > > =C2=A0arch/arm64/configs/defconfig=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 |=C2=A0= =C2=A0 1 + > > =C2=A07 files changed, 451 insertions(+) > > =C2=A0create mode 100644 arch/arm64/boot/dts/aspeed/Makefile > > =C2=A0create mode 100644 arch/arm64/boot/dts/aspeed/aspeed-g7.dtsi > > =C2=A0create mode 100644 arch/arm64/boot/dts/aspeed/ast2700-evb.dts > >=20 > > -- > > 2.34.1 > >=20 > >=20 > >=20 >=20 >=20 > My bot found new DTB warnings on the .dts files added or changed in this > series. >=20 > Some warnings may be from an existing SoC .dtsi. Or perhaps the warnings > are fixed by another series. Ultimately, it is up to the platform > maintainer whether these warnings are acceptable or not. No need to reply > unless the platform maintainer has comments. >=20 > If you already ran DT checks and didn't see these error(s), then > make sure dt-schema is up to date: >=20 > =C2=A0 pip3 install dtschema --upgrade >=20 >=20 > This patch series was applied (using b4) to base: > =C2=A0Base: attempting to guess base-commit... > =C2=A0Base: tags/v6.16-rc1 (exact match) >=20 > If this is not the correct base, please add 'base-commit' tag > (or use b4 which does this automatically) >=20 > New warnings running 'make CHECK_DTBS=3Dy for arch/arm64/boot/dts/aspeed/= ' for 20250612100933.3007673-1-ryan_chen@aspeedtech.com: >=20 > arch/arm64/boot/dts/aspeed/ast2700-evb.dtb: serial@14c33b00 (ns16550a): '= pinctrl-0' is a dependency of 'pinctrl-names' > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0from schema $id: http://d= evicetree.org/schemas/pinctrl/pinctrl-consumer.yaml# > arch/arm64/boot/dts/aspeed/ast2700-evb.dtb: interrupt-controller@100 (asp= eed,ast2700-intc-ic): interrupts-extended: [[6, 0, 3844]] is too short > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0from schema $id: http://d= evicetree.org/schemas/interrupt-controller/aspeed,ast2700-intc.yaml# > arch/arm64/boot/dts/aspeed/ast2700-evb.dtb: interrupt-controller@110 (asp= eed,ast2700-intc-ic): interrupts-extended: [[6, 1, 3844]] is too short > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0from schema $id: http://d= evicetree.org/schemas/interrupt-controller/aspeed,ast2700-intc.yaml# > arch/arm64/boot/dts/aspeed/ast2700-evb.dtb: interrupt-controller@120 (asp= eed,ast2700-intc-ic): interrupts-extended: [[6, 2, 3844]] is too short > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0from schema $id: http://d= evicetree.org/schemas/interrupt-controller/aspeed,ast2700-intc.yaml# > arch/arm64/boot/dts/aspeed/ast2700-evb.dtb: interrupt-controller@130 (asp= eed,ast2700-intc-ic): interrupts-extended: [[6, 3, 3844]] is too short > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0from schema $id: http://d= evicetree.org/schemas/interrupt-controller/aspeed,ast2700-intc.yaml# > arch/arm64/boot/dts/aspeed/ast2700-evb.dtb: interrupt-controller@140 (asp= eed,ast2700-intc-ic): interrupts-extended: [[6, 4, 3844]] is too short > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0from schema $id: http://d= evicetree.org/schemas/interrupt-controller/aspeed,ast2700-intc.yaml# > arch/arm64/boot/dts/aspeed/ast2700-evb.dtb: interrupt-controller@150 (asp= eed,ast2700-intc-ic): interrupts-extended: [[6, 5, 3844]] is too short > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0from schema $id: http://d= evicetree.org/schemas/interrupt-controller/aspeed,ast2700-intc.yaml# >=20 To draw a line in the sand here: while the existing Aspeed devicetrees (AST2600 and below) produce warnings, I won't accept devicetree patches for the AST2700 and related boards unless they are warning-free. Please make sure to test with the dt_binding_check and dtbs_check targets (or equivalent) before sending your patches. Andrew