From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=205.220.180.131 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1795010711; b=mKzKWycNWzGPf0gyoKM0pnLLnC/4YhtXzox1bDORZIURfngZSQrRhJvGl1en6Z3VfnzG jssB+lXpmOvJbh1dA8KkY0KrhXN8KP+Y5/lTwBpc84ABiPNaofeFjq2ygLHNtv1jlqtlt 8kdgYGpidmiCpombwaChF4iG4Ahp8jzhp4+BEt5ZKsXrvSNAj0UxMuVOqRP1VU6ykbgBg qlYPiIsPol8FfQDF+GjEKAfjqy4ILVV2Qx0XSDk5dJEGavQ6QHTbNPOCafn9fyh7xrXqw me3aQqtcMVnRKS1vbZdS91iyhp/ysgZ5riHWpu+3xYJSCSJxug1gJxkMDcjjuHYhcBg== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1795010711; h=DMARC-Filter:Received:DKIM-Signature:Received:Received: DKIM-Signature:X-Google-DKIM-Signature:X-Forwarded-Encrypted: X-Gm-Message-State:X-Gm-Gg:X-Received:X-Received:Received:Message-ID: Date:MIME-Version:User-Agent:Subject:To:Cc:References: Content-Language:From:In-Reply-To:Content-Type: Content-Transfer-Encoding:X-Proofpoint-Spam-Info:X-Authority-Analysis: X-Proofpoint-Spam-Details-Enc:X-Proofpoint-ORIG-GUID: X-Proofpoint-GUID:X-Proofpoint-Virus-Version: X-Proofpoint-Spam-Details; bh=irAuZERJgfy5oKYpVBoCTW7OMNAhM+U1gISjyPpKtA0=; b=WLtlJzxReirSm8Iz1YW4QiOm8bf9JvQsp+5CARjdfmP1HYXvxZAoYCNoWZKwwfOyAo5M +FE4MDfD1za0Qb99lqOssxYv1DWyVqlgfBvHM2wU5Pdg2U2By3DdisVt+U6VsCgUD1+kU GpEKp3rIp1xRcnPPHf5o8RRA+IR8xTsdE1mCG7txTp9rAEjMoxVDokTV5QVP+1zejDx9E fUV5T19euupnmtxALmNX2nm9pm58dSCwUYOftF4y+kNZsNgpMsZhqD3ZfaWW5azLjBtHV XPxACFPDjZDMAlZ+EDDuz3cuXYvcqscSMTjZ/MhKPGRsGKAaOrW+OvUiyCOObtu9EXA== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass header.d=qualcomm.com header.i=@qualcomm.com header.a=rsa-sha256 header.s=qcppdkim1 header.b=lVw4OGBI; dkim=pass header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.a=rsa-sha256 header.s=google header.b=V0Chfiyd; arc=none smtp.remote-ip=205.220.180.131 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BF1F8606A33B for ; Wed, 18 Nov 2026 14:05:10 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org BF1F8606A33B Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.a=rsa-sha256 header.s=qcppdkim1 header.b=lVw4OGBI; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.a=rsa-sha256 header.s=google header.b=V0Chfiyd Received: from pps.filterd (m0279870.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 6AIDQ9VF3912222 for ; Wed, 18 Nov 2026 14:05:09 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= irAuZERJgfy5oKYpVBoCTW7OMNAhM+U1gISjyPpKtA0=; b=lVw4OGBI//R0O3GC y0xtCNFAPqPFkKBCtFpt4YLH/8Zer++4XHZMZv8ReqbmkNVmWlVi/PMBg4YJwS+l evTvKOjcxIi4rEcsDI4U4EQv1YePooiLDCGpdKqgAQcvI3Og8wzszVmumcJb451n cYf3vmZhEu3g0Uvzsx1t5zLdF+8A0RKeJdzxToyM1w7qyfTtwRPtvmjMInDW1dta yTM05peS0dRl3S1GReMXA7CdmzLHr5kHisPNKDv/hLnVnmOYR/YmoYXFrfJZE6Bu I3sv/MgSTlPzf7K5WrirH8oOPh6L5B4sGGhEsCg+JxDQlw7eYIck6LIzQvebCG/4 I16eVA== Received: from mail-pg1-f198.google.com (mail-pg1-f198.google.com [209.85.215.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4j0yv9b9hb-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 18 Nov 2026 14:05:09 +0000 (GMT) Received: by mail-pg1-f198.google.com with SMTP id 41be03b00d2f7-cdb8c46e240so707393a12.1 for ; Wed, 18 Nov 2026 06:05:09 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1795010708; x=1795615508; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=irAuZERJgfy5oKYpVBoCTW7OMNAhM+U1gISjyPpKtA0=; b=V0Chfiyd8RFmI/jweYojn+cPEBptqLIIaNT/htNHmcWIGKCKNB5FxGms2QgvJ0Y0Xg 2/0YZVv80H4UhATbYo98vHVthOvxOnKLjY7ed0nvKCDpSE3KDicuRaiit6S55YcTXLAI U/NjhY9ggldLfbGlPgSGuzAqqOLIDF5TkKJp8Annmo1QIyqMLBGgt8ZC9AH4tGJeXlJr fuMQiVJuR1Nawahc3p8wQdrfbmiyplARNUip3Eeu7YZtn73He7A+ppkLTrxz7sbEkmE0 GICv57xeGtweNPvHRJ0zTmX/i+eSNK1v/VtLXmM3J/1bonWSqXn0a8ggpvBxgIkSF74z F6AA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1795010708; x=1795615508; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=irAuZERJgfy5oKYpVBoCTW7OMNAhM+U1gISjyPpKtA0=; b=DfrbgSvnPXFS+NKqSEAElUZUjpXWJPPvRuJTtdOBjNd2ejlV7+WogVTrdCfCW7Hy97 AzJd7Uj0UA4ZVYbhs04LKlMMprnVj1xXHlJnDgNwaAOY1BeGPOPXBXq385Cn7H2wCDOk aTR/XjrsXdyBUmNpX38Ip3b+hEZaa8HMhPHNUGxIuq+C8HaWREw1292IawiH6AxSASaO YZrUmSK+Y69VgEka/otNSRdeEw5T5MCQZhvdsmaiGeNOLcHq1fEuTUoCN7S9WJSnYCGk 4H1pFvVNQN40L3U7ltIdVp2LA38YcWBXJtS/YfUFA9AnYDTPA7OhesBxcasDuYF/gJ8J hoJA== X-Forwarded-Encrypted: i=1; AL+hErG4+Zpyzt9c30dsGOevl5XMo/rM6DgrzoQBBmvdcAwZQPqFgWwqJPXClrrMs8QWKS5ipeNHC1q+cpyw@vger.kernel.org X-Gm-Message-State: APuU4Z9169UVXD1WQQWgaIStce6KM61FJg/lYPDf+NlrwQBhlneKXGk7 gwuMIKfjZcAIU+ZeVLQuiO8ea9Uz7VlkDBxsz36MRLehnI4GyqESm46PN3wzMa0z7zJhQs5YQBK Zq1el6WcpNVsh7vAxCrkunAmHS/jkfvMmPlSg1taOBYxsDQ6a7QNJfJsi87iI+3ypW/94x8Dy X-Gm-Gg: AZFdTZdp9PkQGYJ4gWk9ujKAArSI6w9rfRIfHsdVDLx5jnKwjKRu73E7TBoIFJvOOTM RAz11K3WTHdxCcpw+Ci5zZvFwbAJaklv/ysFOuZGuuMbkRR0lmy2KekknH/97lcY3JJ52TrjheV RVBuGJXnFKGY93Afc81Bxvk6Ch9C7O/CfliiRSn1LrX2BKRYWNBjCZEiB43BnwiLgcvwG8uq5pd kHZSA/UR8V7FHokv6uS4S5q2kIgYHcWK60X6LaBkviAI+f5GpaPRvVjXc/z8HTydIejCHaHnI3H QFYqzhul8bcEZ2saFUpjMAEeD9q+xFO46DRnNKOTzs4kcj0+UabfLbeLtj0ZrE7SG70xv6QhtQ3 1q9gVQ+DmK/98VwO42OMPBCRA8Kloj/v83U/I0nEXfRFMSGI/XkLPEjx81IIJNAARK+uoWRqqlZ pRC/oGIw== X-Received: by 2002:a17:90b:180c:b0:3aa:f2c4:12e9 with SMTP id 98e67ed59e1d1-3b3d06a3a73mr3027609a91.3.1795010707870; Wed, 18 Nov 2026 06:05:07 -0800 (PST) X-Received: by 2002:a17:90b:180c:b0:3aa:f2c4:12e9 with SMTP id 98e67ed59e1d1-3b3d06a3a73mr3027545a91.3.1795010707249; Wed, 18 Nov 2026 06:05:07 -0800 (PST) Received: from [10.218.9.75] ([202.46.22.19]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-3b3d0b6b42dsm4695853a91.0.2026.11.18.06.04.55 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 18 Nov 2026 06:05:06 -0800 (PST) Message-ID: <7b409fd8-2bb1-4e4b-aa68-a13c30ed3c2c@oss.qualcomm.com> Date: Wed, 18 Nov 2026 19:34:53 +0530 X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v27 06/10] power: reset: Add psci-reboot-mode driver To: Sebastian Reichel Cc: Lorenzo Pieralisi , Arnd Bergmann , Bjorn Andersson , Rob Herring , Souvik Chakravarty , Krzysztof Kozlowski , Matthias Brugger , Mark Rutland , Conor Dooley , Konrad Dybcio , John Stultz , Moritz Fischer , "Rafael J. Wysocki" , Daniel Lezcano , Christian Loehle , Lee Jones , Ulf Hansson , Pavan Kondeti , Abel Vesa , Bartosz Golaszewski , Sudeep Holla , Andy Yan , Florian Fainelli , Krzysztof Kozlowski , Dmitry Baryshkov , Mukesh Ojha , Andre Draszik , Greg Kroah-Hartman , Kathiravan Thirumoorthy , linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, Srinivas Kandagatla , Ulf Hansson , Bartosz Golaszewski References: <20261029-arm-psci-system_reset2-vendor-reboots-v27-0-fa4b3ff1359b@oss.qualcomm.com> <20261029-arm-psci-system_reset2-vendor-reboots-v27-6-fa4b3ff1359b@oss.qualcomm.com> Content-Language: en-US From: Shivendra Pratap In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Proofpoint-Spam-Info: AW1haW4tMjYxMTE4MDA1NSBTYWx0ZWRfX8CBmGAOO6L8R WwY6pBUs4Sa6FMhEGsr/ojKw4NoY+NjxtBg8yC2xHHrtKp/yRvQxIJkmFRA9eowxjJpmaq918dc kYQsI2wWvBNuOX4bQg1BJVhaladgI2A= X-Authority-Analysis: v=2.4 cv=acT0Dhot c=1 sm=1 tr=0 ts=6afdb095 cx=c_pps a=Qgeoaf8Lrialg5Z894R3/Q==:117 a=fChuTYTh2wq5r3m49p7fHw==:17 a=IkcTkHD0fZMA:10 a=zJRp6_cAMcgA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=gowsoOTTUOVcmtlkKump:22 a=EUspDBNiAAAA:8 a=VwQbUJbxAAAA:8 a=JfrnYn6hAAAA:8 a=_jzlLvw-XOvhGuOIOIMA:9 a=QEXdDO2ut3YA:10 a=x9snwWr2DeNwDh03kgHS:22 a=1CNFftbPRP8L7MoqJWF3:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYxMTE4MDA1NSBTYWx0ZWRfX8A85Xj3Hu8p6 0+bfXnq69FVrauEukR0rTjsmO0NeUBdeHUsF/3yACbyr7oEH+lz1QFR6j8k/GglV1sypos7iUiK XsWc1PhLlq/3lI8RorcLNt4+4MEOdHV54KIgkDZ/LI0qI4Yik4cV/9bOxmZ/NEa7uHSXjWYRE4a jgvNwGXz17bwNBAeCKSqo8O1Gm8bQ8qYWM060jnH6JcsimenpOqdgqozl7VY7zxbmDWvWY9OJDY LjZUXOaxXiTQnsGGNUeYelIxU/8LLuPvqG65OREywnxNRuUIB/wC1pQbO+vdKPxvauOuv6CzjwV oPirTmsjPbyvQL5UB18Ot33p3YuLZocMSEO+KMNEhAVvmsvjuGxHUzfJqch4+umpRuaGx7uZhUH ZhBCPS7gYW4lB0n+XAsjFQhv2vJF7h7DdpwFFdgtbTukg9OHUGXbvwU6hxFNLDF/tUbdBqzfRFA ZsOy3mK8tLf4w92nN5Q== X-Proofpoint-ORIG-GUID: a1L48_Zk23N1RubKLemVxeNqNyflht0D X-Proofpoint-GUID: a1L48_Zk23N1RubKLemVxeNqNyflht0D X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.138,FMLib:17.12.100.49 definitions=2026-11-18_04,2026-11-16_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 lowpriorityscore=0 suspectscore=0 phishscore=0 impostorscore=0 bulkscore=0 malwarescore=0 priorityscore=1501 spamscore=0 clxscore=1015 adultscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2611040001 definitions=main-2611180055 On 11/16/2026 4:38 AM, Sebastian Reichel wrote: > Hi, > > On Thu, Oct 29, 2026 at 02:31:00PM +0530, Shivendra Pratap wrote: >> PSCI supports different types of resets like SYSTEM_RESET, SYSTEM_RESET2 >> ARCH WARM reset and SYSTEM_RESET2 vendor-specific resets. Currently >> there is no common driver that handles all supported psci resets at one >> place. Additionally, there is no common mechanism to issue the supported >> psci resets from userspace. >> >> Add psci-reboot-mode as an auxiliary device created by the psci-devices >> driver. Define two types of PSCI resets, predefined-resets and >> vendor-specific resets. Predefined-resets are defined by psci driver >> and vendor-specific resets are defined by SoC vendors, under the >> psci:reboot-mode node of SoC device tree. >> >> Register the driver with the reboot-mode framework to interface these >> resets to userspace. When userspace initiates a supported command, pass >> the reset arguments to the PSCI driver to enable command-based reset. >> >> This change allows userspace to issue supported PSCI reset commands >> using the standard reboot system calls while enabling SoC vendors to >> define their specific resets for PSCI. >> >> Suggested-by: Ulf Hansson >> Suggested-by: Lee Jones >> Suggested-by: Bartosz Golaszewski >> Reviewed-by: Bartosz Golaszewski >> Signed-off-by: Shivendra Pratap >> --- >> MAINTAINERS | 1 + >> drivers/firmware/psci/psci-devices.c | 4 ++ >> drivers/power/reset/Kconfig | 11 ++++ >> drivers/power/reset/Makefile | 1 + >> drivers/power/reset/psci-reboot-mode.c | 101 +++++++++++++++++++++++++++++++++ >> 5 files changed, 118 insertions(+) >> >> diff --git a/MAINTAINERS b/MAINTAINERS >> index e4ca41cdd872..0e03826eec48 100644 >> --- a/MAINTAINERS >> +++ b/MAINTAINERS >> @@ -22292,6 +22292,7 @@ L: linux-arm-kernel@lists.infradead.org (moderated for non-subscribers) >> S: Maintained >> F: Documentation/devicetree/bindings/arm/psci.yaml >> F: drivers/firmware/psci/ >> +F: drivers/power/reset/psci-reboot-mode.c >> F: include/linux/psci.h >> F: include/uapi/linux/psci.h >> >> diff --git a/drivers/firmware/psci/psci-devices.c b/drivers/firmware/psci/psci-devices.c >> index d23befc490ed..04f24b8d9943 100644 >> --- a/drivers/firmware/psci/psci-devices.c >> +++ b/drivers/firmware/psci/psci-devices.c >> @@ -20,6 +20,10 @@ static const struct arm_psci_device_info arm_psci_devices[] = { >> { >> .name = "psci-cpuidle-domain", >> }, >> + { >> + .name = "psci-reboot-mode", >> + .of_node_name = "reboot-mode", >> + }, >> }; >> >> static void arm_psci_auxiliary_device_release(struct device *dev) >> diff --git a/drivers/power/reset/Kconfig b/drivers/power/reset/Kconfig >> index bce996bbef28..f165a41d40ed 100644 >> --- a/drivers/power/reset/Kconfig >> +++ b/drivers/power/reset/Kconfig >> @@ -360,6 +360,17 @@ config NVMEM_REBOOT_MODE >> then the bootloader can read it and take different >> action according to the mode. >> >> +config PSCI_REBOOT_MODE >> + bool "PSCI reboot mode driver" >> + depends on ARM_PSCI_DEVICES >> + select AUXILIARY_BUS >> + select REBOOT_MODE >> + help >> + Say y here to enable the PSCI reboot mode driver. The driver >> + registers with the reboot-mode framework to configure PSCI >> + reset commands, which are executed by the PSCI driver during >> + psci_sys_reset(). >> + >> config POWER_MLXBF >> tristate "Mellanox BlueField power handling driver" >> depends on (GPIO_MLXBF2 || GPIO_MLXBF3) && ACPI >> diff --git a/drivers/power/reset/Makefile b/drivers/power/reset/Makefile >> index e31cab4ba78e..45d8aaaffaa1 100644 >> --- a/drivers/power/reset/Makefile >> +++ b/drivers/power/reset/Makefile >> @@ -41,5 +41,6 @@ obj-$(CONFIG_REBOOT_MODE) += reboot-mode.o >> obj-$(CONFIG_SYSCON_REBOOT_MODE) += syscon-reboot-mode.o >> obj-$(CONFIG_POWER_RESET_SC27XX) += sc27xx-poweroff.o >> obj-$(CONFIG_NVMEM_REBOOT_MODE) += nvmem-reboot-mode.o >> +obj-$(CONFIG_PSCI_REBOOT_MODE) += psci-reboot-mode.o >> obj-$(CONFIG_POWER_MLXBF) += pwr-mlxbf.o >> obj-$(CONFIG_POWER_RESET_QEMU_VIRT_CTRL) += qemu-virt-ctrl.o >> diff --git a/drivers/power/reset/psci-reboot-mode.c b/drivers/power/reset/psci-reboot-mode.c >> new file mode 100644 >> index 000000000000..c5dcfc40392a >> --- /dev/null >> +++ b/drivers/power/reset/psci-reboot-mode.c >> @@ -0,0 +1,101 @@ >> +// SPDX-License-Identifier: GPL-2.0-only >> +/* >> + * Copyright (c) Qualcomm Technologies, Inc. and/or its subsidiaries. >> + */ >> + >> +#include >> +#include >> +#include >> +#include >> +#include >> +#include >> +#include >> +#include >> + >> +/* >> + * Predefined modes use two arguments. arg1/magic[0] is always zero and >> + * arg2/magic[1] is one of the values defined by enum psci_standard_resets. >> + */ >> +static const struct reboot_mode_entry psci_resets[] = { >> + { >> + .name = "psci-system-reset", >> + .magic = { 0, PSCI_SYSTEM_RESET_COLD_RESET }, >> + .count = 2, >> + }, >> + { >> + .name = "psci-system-reset2-arch-warm-reset", >> + .magic = { 0, PSCI_SYSTEM_RESET2_ARCH_WARM_RESET }, >> + .count = 2, >> + }, >> +}; >> + >> +static u64 psci_reboot_mode_get_cookie(const u32 *magic, int count) >> +{ >> + u64 cookie = 0; >> + int i; >> + >> + /* >> + * For a 3-cell magic, arg2 is the high 32 bits and arg3 is the low 32 bits. >> + * For a 2-cell magic, arg2 is the low 32 bits. >> + */ >> + for (i = 1; i < count; i++) >> + cookie = (cookie << 32) | magic[i]; >> + >> + return cookie; >> +} >> + >> +static int psci_reboot_mode_write(struct reboot_mode_driver *reboot, >> + const u32 *magic, u32 count) >> +{ >> + if (count < 2 || count > 3) >> + return -EINVAL; >> + >> + /* Unexpected value at magic[1]/arg2 on a 32-bit system. */ >> + if (!IS_ENABLED(CONFIG_64BIT) && count == 3 && magic[1]) >> + return -EINVAL; >> + >> + return psci_set_reset_cmd(magic[0], >> + psci_reboot_mode_get_cookie(magic, count)); >> +} >> + >> +static int psci_reboot_mode_probe(struct auxiliary_device *auxdev, >> + const struct auxiliary_device_id *id) >> +{ >> + struct reboot_mode_driver *reboot; >> + struct device *dev = &auxdev->dev; >> + size_t count; >> + int ret; >> + >> + reboot = devm_kzalloc(dev, sizeof(*reboot), GFP_KERNEL); >> + if (!reboot) >> + return -ENOMEM; > > reboot = devm_kzalloc_obj(dev, *reboot); will update in next post. thanks, Shivendra