From: Gavin Shan <gshan@redhat.com>
To: Randy Dunlap <rdunlap@infradead.org>, devicetree@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, robh+dt@kernel.org,
drjones@redhat.com, shan.gavin@gmail.com
Subject: Re: [PATCH v2] Documentation, dt, numa: Add note to empty NUMA node
Date: Fri, 25 Jun 2021 14:27:02 +1000 [thread overview]
Message-ID: <7b49ad10-10a8-a20a-fce3-9fb113bcac54@redhat.com> (raw)
In-Reply-To: <834b6b3a-c56b-b8e3-f401-30fdc689d6a2@infradead.org>
On 6/25/21 11:49 AM, Randy Dunlap wrote:
> On 6/24/21 7:03 PM, Gavin Shan wrote:
>> The empty NUMA nodes, where no memory resides in, are allowed. For
>> these empty NUMA nodes, the 'len' of 'reg' property is zero. These
>> empty NUMA node IDs are still valid and parsed. I finds difficulty
>> to get where it's properly documented.
>>
>> So lets add note to empty NUMA nodes in the NUMA binding doc.
>>
>> Signed-off-by: Gavin Shan <gshan@redhat.com>
>> ---
>> v2: Update to address Randy's comments
>
> Hi Gavin,
>
> Sorry, there has been some misunderstanding. Please see below.
>
>
>> ---
>> Documentation/devicetree/bindings/numa.txt | 4 ++++
>> 1 file changed, 4 insertions(+)
>>
>> diff --git a/Documentation/devicetree/bindings/numa.txt b/Documentation/devicetree/bindings/numa.txt
>> index 21b35053ca5a..08e361f9954c 100644
>> --- a/Documentation/devicetree/bindings/numa.txt
>> +++ b/Documentation/devicetree/bindings/numa.txt
>> @@ -109,6 +109,10 @@ Example:
>> Dual socket system consists of 2 boards connected through ccn bus and
>> each board having one socket/soc of 8 cpus, memory and pci bus.
>>
>> +Note that the empty NUMA nodes, which no memory resides in period, are
>
> In patch v1, this was:
>
> +Note that the empty NUMA nodes, which no memory resides in, are allowed
>
> and I said:
>
> Missing period at end of the sentence above.
>
> What I meant by that was "Missing 'period' ('.') punctuation at the end
> of the sentence above. So it should simply be changed to:
>
>
> +Note that the empty NUMA nodes, which no memory resides in, are allowed.
>
Thanks, Randy. v3 will be posted shortly to have everything corrected.
Sorry about the misunderstanding.
I thought "in period" means "temporarily" and it makes sense to me :)
>
>> +allowed. Their NUMA node IDs are still valid so that memory can be added
>> +into these NUMA nodes through hotplug afterwards.
>> +
>> memory@c00000 {
>> device_type = "memory";
>> reg = <0x0 0xc00000 0x0 0x80000000>;
>
> Sorry about the confusion.
>
Sorry to take more of your time to review :)
Thanks,
Gavin
prev parent reply other threads:[~2021-06-25 2:25 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-25 2:03 [PATCH v2] Documentation, dt, numa: Add note to empty NUMA node Gavin Shan
2021-06-25 1:49 ` Randy Dunlap
2021-06-25 4:27 ` Gavin Shan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7b49ad10-10a8-a20a-fce3-9fb113bcac54@redhat.com \
--to=gshan@redhat.com \
--cc=devicetree@vger.kernel.org \
--cc=drjones@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rdunlap@infradead.org \
--cc=robh+dt@kernel.org \
--cc=shan.gavin@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).